Matrix modulation connection is broken in exported plugin

[ustk]

@Christoph-Hart AI said that it was initillay because Hise already prepared all the processes (or something like this) so modules are well ready to work.
But exported plugins needs to do it at init so prepare to play was not ready yet (or reset with bad samplerate) when the modules are initialising, if it ever make sense to you...

[Christoph Hart]

@ustk ah yes sure, now I'm back on track. Let me just check the current example as exported plugin, but I checked this exact setup back when I fixed it last week.

[ustk]

@Christoph-Hart I expect your binary to crash if you don't have samplerate fix from above. Or something is definitely weird...
I you need I can provide you with my project.

[Christoph Hart]

@ustk no my test never touches that codepath. I'm loading a compiled network in a hardcoded fx - all your changes are modifying the script FX modules. What's your exact setup?

[ustk]

@Christoph-Hart Mmmm... Maybe because I am still using a basic ScriptFX in the project that I don't compile (but I can compile it and use it in a hcfx) that the crash happens without the samplerate fix. I'll try to place it in a HCFX to sse if it's at least stable without the fix.
But yeah that's not related to the HCFX module thing

The setup is:

• FXs are hardcoded modules
• They make use of NUM_HARDCODED_FX_MODS=8
• Extra mod slots are receiving a matrix modulator
• UI components have a matrixTargetId set to the corresponding matrix modulator name of the corresponding hcfx

In the networks:

• there are extra_mod nodes set to the index of the extra mod slot
• Corresponding network parameters have their ExternalModulation property set to Combined

HCFX modules are bypassed from UI buttons.

So at init, the state of the project has been saved with the init preset, that has all modules unbypassed by default. Then other presets are bypassing/unbypassing the modules as you load them. It's only when a module has been cycled bypassed/unbypassed at least once that is actually able to modify the sound

[Christoph Hart]

I'm testing pretty much this setup:

1. global mod => LFO
2. hardcoded FX in master chain with network:
   • 1 parameter, set to combined
   • modulates a osc.freqRatio
   • extra_mod slot has a MatrixModulator connected to the LFO
   • no preset, nothing, just the default state

Load VST3 instance => pitch wobbles. Before the fix it didn't.

[ustk]

@Christoph-Hart Are you exporting an FX or INSTRUMENT?

[ustk]

@Christoph-Hart Any snippet for me to test out?

[ustk]

@Christoph-Hart I've made this simple snippet and it doesn't work. Not from UI parameter, not from LFO...
What did I do wrong?

HiseSnippet 1946.3oc2Y0rbibaDFinfVsZW63s104PpbfGksWqZFpgTRUNXt5OaVdoDsHsbpjCJPy.RhRy.LYFvUhNUtma4UxOB4IHUdDxafciAyOXjHszxUVdKSUEKBz.n+Pit+5FP8hEdzjDQLxZsASinHqmh6OkKGu2XBii5rOx5CwRZhrgciV1MscQ6NMhjjP8QVV09R0Xrd7xnzO++uXWR.g6QK6BgNUv7nulExjk8F09qYAAGR7oCXgFi1scGOAeOQfXBfmZXaTDw6BxH5QD0vVBi9JRxXj0mh8caQItt9dzFCota277s1bys8Z4Z6a2pAsYqgD6la4NzEYsxA9LoHtuj.6Bj0x6J7m1er3RtVAmxRXmGPUMbP8AMq69PQfuZKp5Es2XVfeubCUBBYg6UZ1poMau.2k4yJ5uz78QoBpWNCSCn0RUgWsJvywDd1FvaFPxx.RKqgzyv88hYQxRIJ77DbGtjFOj.mSlPQOVj0Of2S.CfK2HjbA8vXnQwDVuks8KqCe8I+ogS3dRlfWWvORHoGyW+SV6er1iW6etV8qKZ3vYJSolXQP.MdlhUtFw+bSbc9jvyowur9aHASnECD19Uso34aSMOx8z6ZiAJ3c3L4wQT97bDPYlJk8OCUvPkoV+OLy52Of4SiQLvH+H7WyEm6fRAbla++66ew+8KPeam8IRR9x.qHnkHZrjo1.V6SeCDDoOTeLdeZxERQT5XCiDbk9sV8VU5UkwYr1SKZ7Cm2NjHiYWMfDOhJ63qTwgwz+9Yc6hjzqf0dE7gmbv2ftj4KGWLu1+s1iorQiMBq6zFcSmPv8W3OIfHqFSnXNxD.GpUbDUda7DlbpIyx8VfxcEhOC2iI8FOaLtzLvHb38KAFynW9.7ACGR8jk.bY7g+4eg3RV5l1n0xbr.cpIQzMqWECKkSh7uvkArQwzHRLcfnW.Y55Ijvn.5I.DeY8yCDdWzm88zaFkGoQvtpQrt2XBmSCRVDxfUtyFEm2ZB1Y53rJ9fqjwDmGRe5SDSjL9ntoAx.i2QSB6C4P8n6kY4f9rVRwWoaaqZq.QeJ2OswOBexD5nZakIzIWXIUG5Hp7RQ7EoFkreCaasaQRpCvYCuBcJMNQE1.DP1a.+gdUPf3REkEKKfJcSBYzGPXA5sV5P5IBlFMVvYdJKmdB4ajWEJlnn6z6lxfycy8jJ1XSR.da+i48gImVRBDfXcjvG90iNj3Al8o8HJ9rmgUL+voGMdCuhSQycR4AoBi5ZQLkqNx5Qhg9gzjI5skRS4ExnQDrQBSopgxXrpojmFpogzJZVwKiIQTk2yYgBvzWAmerANCgJJzXcVX6FqycELVFf4I3hEnJN9H.GwzMJkNaySo7aQ6KWdJpSAkjkFjS8ztIo1HUhomhEIdPkip.NTgEWI4Ioorl.mzSQHiyBEWVdKP6cY7S04dwJmRTWxUYsWA6zB5nujFk4Fgcf1JKwifBl7ofCs4LQ2skUuJyZU+c40P1mMhSBt1pq75CnWkWTv9rjHf7b2IPN.MYTkdf1ZHBIE9bmzzG4EOT0ZTQRJilpEPJsjBROE2I4TkTuR7.wYFNEUN.tQTD3UXHdVtEUl+s4U9NZCLcBV4tdZ4NmSqUTL8z46BrZ4h9briMHV8wwcGaGmVNFp343l4R2xsocyssaYnvW.Krisc0I2+B5kZasd.MZryN1tMa0nwltau01My3qJC.F.wdCDoJDBidCbhpfn4H1mNjLIPVfoFMxvzlM1Z6FMa1D8pIRATWXwcflmAz4tFE8zT0W+DUfNpxzemCkVAplTReGVTcTduwjD5bLd+d7Qh3PR.nY+dTHwJvDOh9NPIjiafBOq+OPc12vcycfav17ZmP46o4EWCgxF5Vu1JyM51fA3UWdcaGDT4BMFXiLp5Ep7CBDOGR63WgVdQYSVja5XVOLVK743uhD66AAk9cII.pyJL8iK6utVv0JQsVQEKlovSMVlkxW6gtrQHefS8eUtQTEHtV9SGnqkr.noXr7hglnqqfKxqWqDdmPg4OZjxgrryx8WJcZFs+L2d6MIAXfT41gjAmd8KL2OTHjigRdq9.RcZeucvo04IDNDlq7n4QSj5VV3PyW8BgBIWYh7NZViTaSRAcU4vULL2N0B53Ix6MU9sIztL+dBvHC19Wk7WnwB0XePt3fg20pZuq+.9KCDmWPy.gA4U1l5l8GyDWuPd8xAL+me7+b++7iW+ojV9t4McKud3xu285g20GE4423jI4WKhpmogIF+5CONi.E9UIvtcbsKKRDPTENVqrxnB4q1V4fzoz+p8+t82QdCcHDrlkepXkdMcDnRydFPCiD8mx8L8EmCo0KZ+ZgH5.NALB9lKRZAIGObXBUVYYfkcfPmbaO08dME1YDGpCW+hrl8qoSy2.ojppRoRyEa8Wwsb2.9L7yTeuydvWad78S62lGEy4s9UoliSpxQn3HW4R7d36KpQYgi26on7m8UPq8a5WA8AI2ndw0UD+fnvPhWr3LO8ilphpVMsGvHvSug9igB+f10q9OoPWyAjH5LOupK0MlXiEchatnSzcQmXyEchsVzIt0hNwsu8IppSH6V6p3TDpauCzz6VE4VfJ99If8wJvB

[ustk]

@Christoph-Hart Nothing that I can test make it work, using develop branch. (note that it crashes with develop when a scriptFX is present in the tree)

A macro or a flag I missed perhaps?

[resonant]

@ustk said in Matrix modulation connection is broken in exported plugin:

@Christoph-Hart Are you exporting an FX or INSTRUMENT?

I have the same issue on the exported fx plugin and reported a while ago: https://forum.hise.audio/topic/13977/modulation-matrix-fx-plugin-crashes-in-daw?_=1777946560667

[ustk]

@Christoph-Hart Another strange behaviour, I am currently trying with AU export, which is working aside of the current problem we are trying to solve. I guess it's related to MacOS (me) vs Windows (you?)
But that same snippet exported as VST3, and ableton live says:

[David Healey]

@ustk Could all your problems be related to this juce 8 thing?

[ustk]

@David-Healey Perhaps... But I am JUCE 6... Or schizophrenic...

[David Healey]

@ustk Why is xcode referencing 8.0.3

[ustk]

@David-Healey To this day I have no answer for this...

[David Healey]

@ustk Definitely only got one copy of the source?

[ustk]

@David-Healey yes, always had (custom branches but one folder/repo)
Also I just re-aligned develop origin onto upstream to be sure (I had some merge commits because of past manual fork syncing) but no changes regarding the issue and the VST3 crash.

[ustk]

@David-Healey said in Matrix modulation connection is broken in exported plugin:

@ustk Why is xcode referencing 8.0.3

After analysing everything, AI confirmed Hise is built and running on Juce 6, and it says:

The assertion you hit is most likely thrown by the JUCE-8 plugin's code (in the v8.0.3 message thread), not by HISE's JUCE 6.

Since I am debugging using pluginval which is built on Juce8, that's 99% the origin of XCode reporting Juce8 message thread

[Christoph Hart]

@ustk yup that's the plugin host telling his version number.

I tried to load your snippet, but the hardcoded FX is empty (of course, I don't have compiled your network) - is it just the script_fx network in the Script FX that I need to compile?

This looks remarkably equivalent to my snippet though (which worked).