C++ External Node & XML Issues

[HISEnberg]

@Christoph-Hart

Github issue: https://github.com/christophhart/HISE/issues/866

I've been getting a lot of these errors lately (maybe since the last 3-4 weeks?)

XML file is not valid. Loading aborted

Usual context is having a hardcoded FX module with a custom C++ node (or Scriptnode Networking containing a C++ node). If I remove the reference in a text editor (.xml), the project will load and I can add my node back in. But resaving and opening again will reproduce this issue. Mind you it isn't a matter of updating HISE or recompiling the FX, this happens on any build from this year.

[Christoph Hart]

@HISEnberg Probably an issue with your parameter names. Note that using eg. "Type" is illegal because it clashes with the XML element for the module type (HISE!).

[HISEnberg]

@Christoph-Hart Hmm that seems reasonable. Do any of these raise any flags? I'll try changing the parameter name but I can't imagine this causing issues (it's from one of the C++ modules causing me troubles).

        void createParameters(ParameterDataList& data)
        {
            {
                parameter::data p("PreGain (dB)", { -24.0, 24.0, 0.1 });
                registerCallback<0>(p);
                p.setDefaultValue(0.0);
                data.add(std::move(p));
            }
            {
                parameter::data p("Hold (ms)", { 0.0, 100.0, 1.0 });
                registerCallback<1>(p);
                p.setDefaultValue(5.0);
                p.setSkewForCentre(30.0f);
                data.add(std::move(p));
            }
            {
                parameter::data p("Release (ms)", { 1.0, 2500.0, 1.0 });
                registerCallback<2>(p);
                p.setDefaultValue(80.0);
                p.setSkewForCentre(800.0f);
                data.add(std::move(p));
            }
            {
                parameter::data p("Ceiling (dB)", { -60.0, 0.0, 0.1 });
                registerCallback<3>(p);
                p.setDefaultValue(0.0);
                data.add(std::move(p));
            }
        }