Settings Window Bugs

[David Healey]

Some of these have been mentioned elsewhere but I just wanted to gather them all here.

• Sample Rate box is always restored blank
• Buffer Size always shows 512
• Selected MIDI channel isn't restored - all channels are enabled on each start. I also don't see the channel in DeviceSettings.xml

[dannytaurus]

@David-Healey said in Settings Window Bugs:

Selected MIDI channel isn't restored - all channels are enabled on each start. I also don't see the channel in DeviceSettings.xml

That's because it isn't saved to the XML. I've got a fix for it, just need to make a PR

EDIT: for clarity, MIDI channel is stored in GeneralSettings.xml, not DeviceSettings.xml but the code is missing to update it when you update in Settings. My PR should fix that issue.

[dannytaurus]

@David-Healey

Should we remove the Extra Definitions IOS field entirely? Same for App Group ID?

Just for kicks, should we update the (c)2017 default in Company Copyright to the current year?

Should Visual Studio Version be updated to 2022 if it's the new default?

The tooltip icon for the MIDI Device still shows when there's no MIDI Device connected, nor field visible.

Tooltips:

Tweak the Embed Image Files tooltip to mention image files instead of audio files.

Extra Definitions has empty Examples section, either add examples or remove the header.

We should probably update the tooltip on VST3 Support now that it's standard.

Enable Callstack has a broken Examples section.

[David Healey]

@dannytaurus said in Settings Window Bugs:

MIDI channel is stored in GeneralSettings.xml, not DeviceSettings.xml

Seems odd.

@dannytaurus said in Settings Window Bugs:

Should we remove the Extra Definitions IOS field entirely? Same for App Group ID?

Yes, and what about the team ID? I don't think that's used.

@dannytaurus said in Settings Window Bugs:

Should Visual Studio Version be updated to 2022 if it's the new default?

Once IPP is updated I think will be 2026 since Microsoft have discontinued the community version of 2022.

@dannytaurus said in Settings Window Bugs:

We should probably update the tooltip on VST3 Support now that it's standard.

Makes more sense to remove this and add enable VST2 support check box :D but probably more hassle than it's worth to actually do that.

[dannytaurus]

@David-Healey said in Settings Window Bugs:

MIDI channel is stored in GeneralSettings.xml, not DeviceSettings.xml

Seems odd.

It's been there for 9 years, so I guess it's just where it started out.

Here's the PR: https://github.com/christophhart/HISE/pull/850

[dannytaurus]

@David-Healey said in Settings Window Bugs:

what about the team ID? I don't think that's used.

Looks like only in the redundant iOS code, but Christoph would know best on that. Just in case it messes with Mac exports.

[Christoph Hart]

The team ID is used to automatically codesign macOS builds.

[David Healey]

@dannytaurus said in Settings Window Bugs:

@David-Healey said in Settings Window Bugs:

MIDI channel is stored in GeneralSettings.xml, not DeviceSettings.xml

Seems odd.

It's been there for 9 years, so I guess it's just where it started out.

Here's the PR: https://github.com/christophhart/HISE/pull/850

Great thanks, this one's been bugging me for years!

[dannytaurus]

@Christoph-Hart Wait.. does that actually work? I thought we had to do that manually?

We're talking about plugin builds, right - not HISE builds?

[David Healey]

@dannytaurus Xcode can code sign for you. I always do it manually though. Also if you have multiple certificates installed how does it know which to use?

[ulrik]

@David-Healey said in Settings Window Bugs:

@dannytaurus Xcode can code sign for you. I always do it manually though. Also if you have multiple certificates installed how does it know which to use?

You have to select which certificate each time you compile