Modulation range not absolute?

[Oli Ullmann]

@ustk
Couldn't you use Math.range in the LAF to define the minimum and maximum?

[ustk]

Also, the intensity sliders are not really reflecting reality.
The knob is set to 1500Hz, so the intensity slider is going from -1500 to 18,5khz (20k-1k5). But those min/max values are reached before the 0% and 100% of the intensity slider

[ustk]

@Oli-Ullmann But you have only one range that is pre-computed for you. It would have been possible if an array of all ranges would have been passed to the LAF object (and this would be great for painting the different modulation ranges with different colours )

[ustk]

Another one
When moving the freq knob, once modulated, the sound doesn't change. The modulation range that is heard is still the same no matter the knob's value, for all the modulation modes (but different per mode, of course)

Ok it's a gif so there's no sound, but trust me as I move the knob the filter to which it is connected doesn't change
But the intensity value updates, meaning something might be off somewhere...

[Oli Ullmann]

@ustk
Yes, but you set a start and end point when you draw the modulation arc. You could use the range function here, couldn't you? Unfortunately, I'm not at my computer and can't try it out myself.

[ustk]

@Oli-Ullmann perhaps the answer is here... I have to work more on this since I thought it would have been easier at first. But there seems to be quite some complex things to understand and take care about

[Oli Ullmann]

@ustk
Good luck!
Please let us know if you find a solution.

[Christoph Hart]

• lastModValue is smoothed so it might not be cancelled out perfectly.
• can you make a minimal example where the knob stops working when modulated?

and this would be great for painting the different modulation ranges with different colours

Yes I thought about that, but in the end it's too complicated to get it to work as it's pretty complex to calculate the ranges with the different modulation modes as it is already.

But those min/max values are reached before the 0% and 100% of the intensity slider

Yes, with bipolar mode an intensity of 50% will already cover the entire range if the knob position is in the middle. 100% intensity will modulate the double range so that if the knob is all the way to the left it will still go full to the right.

[DanH]

@Christoph-Hart

Yes, with bipolar mode an intensity of 50% will already cover the entire range if the knob position is in the middle. 100% intensity will modulate the double range so that if the knob is all the way to the left it will still go full to the right.

IMO this is incorrect, it should only go up to the midway point. This is how other devs do it and seems the most intuitive way.

[ustk]

@Christoph-Hart said in Modulation range not absolute?:

• lastModValue is smoothed so it might not be cancelled out perfectly.

That is not the problem, in fact it seems to be at the right position, it's the modMin and modMax that are cancelling each other, giving the wrong modulation range to be displayed (see first gif)

• can you make a minimal example where the knob stops working when modulated?

When I reopened the snippet everything was fine... dunno what happened

and this would be great for painting the different modulation ranges with different colours

Yes I thought about that, but in the end it's too complicated to get it to work as it's pretty complex to calculate the ranges with the different modulation modes as it is already.

But (as explained above), having them combined returns a wrong displayed range (as it can even be totally cancelled visually while still hearable)

But those min/max values are reached before the 0% and 100% of the intensity slider

Yes, with bipolar mode an intensity of 50% will already cover the entire range if the knob position is in the middle. 100% intensity will modulate the double range so that if the knob is all the way to the left it will still go full to the right.

I understand that. I agree with @DanH though, even if both visions are defendable...

[Christoph Hart]

IMO this is incorrect, it should only go up to the midway point.

Now is the time to change that before people have projects with this out there - at least with the matrix modulator, the behaviour of the intensity of the modulation system is carved in stone by now.

I have to check this with all target types (I vaguely remember there was something that didn't work with 50% intensity, maybe something related to pitch modulation), but if the majority of users prefer it this way I'm happy to follow suit.

[ustk]

This post is deleted!

[DanH]

@Christoph-Hart Thanks. I also remember something strange about bi-polar and pitch modulation, but perhaps it was the range thing we just discussed. I'll check again...

[Oli Ullmann]

@Christoph-Hart
@ustk
@DanH

Could we hold a vote on this in the forum?
I must admit that I find the current implementation logical and intuitive...

[DanH]

@Oli-Ullmann let's take the below example on a pitch knob. The knob's range is +/- 24. The modulation range is already set to 50%. Visually the modulation range is drawn and covers the whole knob's range. But remember this is only 50%, so the modulation is between -12 and + 12 semitones, not -24 and +24 semitones (as IMO it looks like).

To get the maximum range (and the range that it looks like it's already doing) you have to increase the modulation slider to 100%, whilst receiving no visual clues as to what you're modulating other than the text box. Since the text box only appears when you move the modulation range slider you can't simply look at the knob and know what it's modulation range is. It could be anywhere between +/- 12 and +/- 24.

If you need 100% modulation on one half of the bi-polar modulation then you should be using scaled / unipolar modes.

Also I think it's better to stick to 'popular', tried and tested methods (see further example below)

[Oli Ullmann]

@DanH
Okay, I totally understand what you mean!