@hisefilo said in Audiowaveform repaint failed:
I wasn't able to repaint the AudioWaveform floating tile. I think it's a bug. I had to do something like this to make it work:
ftAudioWaveForm.set("visible", false);
Content.callAfterDelay(30, function()
{
ftAudioWaveForm.set("visible", true);
});
@d-healey Thanks, I removed the extra preset handler, but it still keeps crashing for him. I think my code is pretty clean now.
I'm starting to think the issue might be with the macros. I was thinking of disabling the macro modulation source before the preset change and re-enabling it afterward. Any other ideas regarding macros? I saw another post where @hisefilo had issues with preset changes involving macros.
@d-healey I will check. And is it bad to use Engine.createUserPresetHandler and PresetHandler.setPostCallback in two different namespaces?
@d-healey Great, thanks. I changed that but it keep crashing for him. This time it crashed right after he pressed the next button; the plugin didnt load anything more (I can see from the debug log).
This is my script for next preset:
inline function onbtnNextPresetControl(component, value)
{
if (value)
{
Engine.loadNextUserPreset(0);
LookAndFeel.presetDisplayName = Engine.getCurrentUserPresetName();
LookAndFeel.btnPresetSelect.sendRepaintMessage();
}
};
Content.getComponent("btnNextPreset").setControlCallback(onbtnNextPresetControl);
presetDisplayName is a variable I have in the LookAndFeel namespace where I store the name of the current preset.
And btnPresetSelect is the button to display the preset name and to open the preset browser.
Oh and the LookAndFeel namespace has 2600 lines. I'm not sure if this is relevant.
Is there something wrong here that could cause a crash?
@d-healey Ok, cool — I'll give it a try, thanks! But do you think removing the conditional for searching audio files in the source code, just to be able to declare the empty hardcoded master FXs on init, is a bad idea? I compiled it and it seems to work fine :) I'm not sure yet if it solves the crashes though.
@d-healey said in Preset Crash:
createAndRegisterAudioFile
So, instead of using getAudioSampleProcessor for loading the impulse responses, I can use Engine.createAndRegisterAudioFile(), and I should compile the convolution reverb with 36 different external slots?
@d-healey I have 6 layers and 6 hardcoded master FX slots per layer. Users can load any effect into these hardcoded master FX slots. There are like 8 available networks, including the convolution reverb. Any of these effects—convolution included—can be loaded into any of the 36 hardcoded master FX slots :)
@d-healey I found the source code for that API. https://github.com/christophhart/HISE/blob/372a9e682cff2f3b52ee432ae50977fc95d9173c/hi_scripting/scripting/api/ScriptingApi.cpp#L5997
If I remove this check (Line 6009) I can declare an empty Hardcoded Master FX on init.
if (asp->getNumDataObjects(ExternalData::DataType::AudioFile) > 0)
Is this safe to do? Or there is a better way to handle it? @Christoph-Hart ? Thanks
Only after I load the Convolution Reverb network on HardcodedMasterFX1 I can get Synth.getAudioSampleProcessor. And in my plugin all hardcoded master fxs are empty on init.
HiseSnippet 760.3ocuU00SaCCE0tsFs1MlFRr2i3IXBgRnsrhPSCneLp1ZoZkg3MjqiC0pI1QINvpl1+48OXyNIzzR6ftpskGp58q3SN2y85dABBMLTD.fktXrOE.eAp+XtbX8gXFGztA.9RTGbnjFXj35zw93vPpM.By+AsCXwBf3me79SwtXNgl4B.tTvHzOw7XxLu8N9iLW2VXa5ELuoxtxwsIBdcgqHRgm7HSfOlLBeCsKVmVND3Lb3P.7MnA16aZac.olk09UqVybPsxjCGT1AWtBEO3PyZV3Cq5XVA.WqoMSJB5KwRZn5kdpvdb+gh63IGvkrP1.Wp1vBzWcxItA0Gxbs6cO4DB.vB8xnp7IT0lnNLa1D+YT1qhCXjUwzjFL2iAIq+.HAmBRERfzFn9j.luLKhFOOG0lq5fNXUuYZnjjKH25PTcgJCtbOO7HZq.kwjJ19.SycMT+ryQkJo5OgRiShrYhIGgw6LhkL6cCUFGoO1y2kNI91acFNvlHro1IJoVWYs0NG4DwIRlfaH3cER547s2oz2JUrz2KY7vPNNKLlFyABWWZvBCqEWAOVgayi7FPC103VraDcRhJxb1NzZKWGhjPgSknf2lyjm6SSsaIbs0Lu9+y2OAo8.0+9R6FXIV2hS8oxymFHYZ3.aPuUMTkzvKhZPCGIE9pwp4TCJcnvNxEKmUbpGaSCn3iYTD5tNOjIGO8X8CUrE987g4T7wS70tjvcCTOljLbw3M2Bvqh09Wi2z4+0QMcbnDYFXKfZc0iNrWX4jRYPYYG7eMZxPlQ59ZETzXZSz7ieyfwtT4chfQ5U+cEF76sx+WZME3yhHIieSGrLf8U.D0MxquZCOgp3MNm5pd4HXNs9Ow1Taq6i8ob6XiepdRCZosgoAstO3+kyvCSBDWSR1cnaCOK1i56lGe+TQ0EkJaCKP79joUjdpqCtlPl8UMWg6upEVdUKrxpVX0UsvCV0Be6pVXsmtP8s0mDIEdIKX.fN8ZFu.FBaxwJUd7bB3W.WeCizC
@d-healey Yes, but the problem with this one is that Hise returns error if I declare on init, because there's no effect loaded on the hardcoded master fx.
@d-healey I think I found the issue. I included "Debug mode" on the floating tile, and the beta tester sent me the log.
Most crashes happen when the convolution reverb combo box is loaded. The problem is that I'm using a convolution reverb inside a hardcoded master FX (created with Scriptnode).
In the combo box's inline function, I call Synth.getAudioSampleProcessor() only when the convolution is active. But audio processors can't be declared inside inline functions. The issue is I also can't declare them in onInit, because the convolution reverb is not loaded yet in the hardcoded master FX—so I can't call Synth.getAudioSampleProcessor()
I'm testing my plugin with a beta tester, and it occasionally crashes for him when changing a preset. The plugin passed validation with pluginval.
I can't reproduce the crash on my Mac mini M4, but he has a 2017 Mac which is a bit slower.
The presets contain approximately 600 lines each. About 500 lines are components, 50 to 100 lines are modules, and finally, about 10 lines are macros.
The plugin shows no errors in the Hise console when changing presets. My only thought is that it crashes because his computer is slower. What do you think? Is there a way to load presets more slowly so they load properly on slower computers? Or is this already optimized with Hise?
PS: I already re-saved all the presets with the actual parameters with saveInPreset.
@Christoph-Hart said in Locking parameters out of Presets...:
saveInPreset is not a dynamic property and you'll run into undefined behaviour and glitches.
Is it a bad idea to use saveInPreset dynamically for dynamic modules? I mean, I’m adding the sliders dynamically to control the hardcoded master FXs, and I only want to enable saveInPreset when a slider is active. Is that a bad approach? I’ve been testing it and it seems to work fine.
I want to keep it dynamic because I have 216 sliders, and one of the beta testers occasionally experiences crashes when switching presets. I’m think it might be due to the large number of parameters that have saveInPreset enabled.
Edit: Nop, it doesnt work well using it dynamically :(
@d-healey Oh, but I can't place it on init. Because I have just one inline function for 36 comboboxes. So I'm using getSlotFX depending the selected combobox index.
@d-healey It's a inline function of a combobox.
inline function onEffectComboboxControl(component, value)
I have a lot of things inside because it's for changing the hardcoded module networks
Sometimes when I load a preset, HISE prints the following error:
Call of getScriptingAudioSampleProcessor() outside of onInit callback
It points to a line where I'm using Synth.getSlotFX inside an inline function.
It happens once in a while. Why?
@Christoph-Hart Yes sure, something like this
HiseSnippet 1135.3oc6VstaiSDEdbabEM.KrR7.LJ7mTTakcurzlJzl1zFHPuD1TVsRHzpwiGmLpimwxdx1FVsh8IhmMdCJmw1I1tIzKHw+vQJIybt8cNymOmoerhxRRTwHq5WNIhgr9L6ASj5QcFQ3RTuiQVOy9LRhlEiy15nIQjjDlOxxZ4u2rg0p0PoO+0KOhHHRJqXKD50JNkcJOjqK1se6ehKDcI9rK4gkzdm18nJYGkPMFvyx1NnHB8JxP14DiZKYi9ARxHj02X64ukiu6Kn645t0t6tmi2daS22a6.x16vHd66rmKY+cCb1AYsxI9bsJdflnYIfSOR4OYvH00xr.7ZdB2SvLKbQCfHmsMpyHtvu+zhSBBYUqeQoZ4rR0WYeF2mOa+hR1WlJ.WXQ4hl0R2GjbeBPxpDjpkAomaOfFyizERL34Ss6IgSv.Bb1TFJY5hVJnlcGEngTuYH4JV2XXwLKZ9BGm0wvWqcP85v4ShF+NRL9LBMVcJI.+c3o1RiYPJcphRDmpTWcnzuKiIZB1chbHWx1LgoS8MS5mZdRyeswocunw5XyOtM9MSHl5Xi18jBvtA5IB1fQLltYi5X3YSAe3HMVOB+9z0lm.vuaDPB4hIsvGFyIh0wuhMbrfDevLknP4LtE1S.7pCpZZB+2YsvteazM2Qv0LSvZg20woPhlcidCB.CYKLkYJUExhH99b4PvYNQ2f2srC8Tw9r3M7TZsJDT.jmnDbe7Wu0glOYZ9gzuyxTeR7UUSzGcxVJgudDWyNXdWrnj99S7GJ4efBviuHjUHZTkz0UnHZv0WxEL2RLugLcGUXjRBKZ1nhVodnxNFh0bjzorNi17TVGNXrjp4JIVIOZLfUoqIbwJQS5zXsNfJwX1Z0ee8UmKFEz1NB3UtlopheItQF8sAtE7Wy4qAhe.h6hyl7X2XMiOyQPGhP3Ab3l2EZF3WB2mqzrKjMSwWcfVcWQAAKTVtyDr3EJ1z0N99LrobbnGKtb0wnHzkpZquUdbs9nY0kRJpj8jb8EQr70cUBeSKMy+muQIJuvZZYliPPUcZCymk2vLqLh3fSV0NulhRge4oYneo2wDMYpi.eBwIhEq4lzw5X16focYchW09XVxUZUDL3Z1oIzJVmO5HKrkIMoA+KrqviP2LK7e7maOo7hb.LcTTkFq8IRl.4Mb5rzUWYZB.8ABK181au8iU2cqxaadQedkul6qgov1V+oEBMJsIgY0OZkVomko0dDE3hrqMqT109OZile1FLUU4Cs3zUG0ZtDRt.fDVY9lYFlLgqmT9RJOg4uN2672GKDetcetlNZwXboEfQfd8eAFyu0xmaeRP.ipK.XM6tu4e6UTdfv+J0XCW9LhNlCG11mONb.PmnLH5RfilXXNKYHNYqcLqMUfA.UNcAv5tMWnqYsUtP2oBQgFF+aoYuXatWzmjtCfIY58FssgKWL+6xgvUzdKkV0MyLZEiQtOUqfqn9+V7OZg4RwGNFF5m8V.BcV+SRamZYchj.DpTxG5uAT1EgiA
I would like to add class selectors to all elements, including th, tr, td, button, and others.
Is it possible to change the local LookAndFeel of a component dynamically?
Something like:
.setLocalLookAndFeel(value ? MacroLafLight : MacroLafDark);
I can apply the LookAndFeel, but the changes don’t take effect unless I recompile HISE. I’ve tried using sendRepaintMessage(), changed(), and even reloading the contentType, but none of them work.
P.S.: I need this because I want to change the colors of the CSS-styled FrontEndMacroPanel, but class selectors don’t seem to work with this FloatingTile.
@bendurso Fixed. The problem was actually caused by my filters script, which overloaded the system with macros.