HISE Logo Forum
    • Categories
    • Register
    • Login

    [bug] Expansion version number not correct

    Scheduled Pinned Locked Moved Bug Reports
    6 Posts 2 Posters 221 Views
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • d.healeyD
      d.healey
      last edited by d.healey

      @Christoph-Hart This seems to be a new thing but perhaps it's always been there.

      I have set the version of my expansion (in its xml file) to 1.0.0. But in HISE the command e.getProperties().Version returns 1.0.

      Christoph HartC 1 Reply Last reply Reply Quote 0
      • Christoph HartC
        Christoph Hart @d.healey
        last edited by

        @d-healey Oh yeah, good catch, I introduced this when rewriting the ValueTree to JSON converter.

        The check for double numbers was wrong, so it interpreted "1.0.0" as a double number (I didn't count the number of dots as criteria to parse it as String). Rookie mistake.

        1 Reply Last reply Reply Quote 2
        • d.healeyD
          d.healey
          last edited by

          I love the comments and variable names in that commit :D

          1 Reply Last reply Reply Quote 0
          • d.healeyD
            d.healey
            last edited by

            This post is deleted!
            1 Reply Last reply Reply Quote 0
            • d.healeyD
              d.healey
              last edited by d.healey

              And I just noticed this wonderful thing Can't declare var statement in inline function :D

              Christoph HartC 1 Reply Last reply Reply Quote 0
              • Christoph HartC
                Christoph Hart @d.healey
                last edited by

                @d-healey Ah yes, I sneaked that one in a few commits ago. The problem with declaring var statements in an inline function is that they pollute the global scope which leads to all kinds of weird issues and there is no reasonable use case where you would want to declare a var instead of a local variable in an inline function.

                1 Reply Last reply Reply Quote 1
                • First post
                  Last post

                21

                Online

                1.8k

                Users

                12.1k

                Topics

                104.9k

                Posts