[bug] Expansion version number not correct

[David Healey]

@Christoph-Hart This seems to be a new thing but perhaps it's always been there.

I have set the version of my expansion (in its xml file) to 1.0.0. But in HISE the command e.getProperties().Version returns 1.0.

[Christoph Hart]

@d-healey Oh yeah, good catch, I introduced this when rewriting the ValueTree to JSON converter.

The check for double numbers was wrong, so it interpreted "1.0.0" as a double number (I didn't count the number of dots as criteria to parse it as String). Rookie mistake.

[David Healey]

I love the comments and variable names in that commit :D

[David Healey]

This post is deleted!

[David Healey]

And I just noticed this wonderful thing Can't declare var statement in inline function :D

[Christoph Hart]

@d-healey Ah yes, I sneaked that one in a few commits ago. The problem with declaring var statements in an inline function is that they pollute the global scope which leads to all kinds of weird issues and there is no reasonable use case where you would want to declare a var instead of a local variable in an inline function.