Scriptnode Oversample Error

[DanH]

Just built latest New Layout and my script FX has a new error message that wasn't there before:

I'm pretty sure it isn't a Polyphonic Script FX

[DanH]

@danh Does anyone know if this is a legit error or a bug?

If I create a normal Script FX and insert the Oversample node the error comes up

[ustk]

@danh I can't help much but I've seen this too. I think it is related to another node/container that is inside and is not meant to be oversampled.
Or the other way round, the oversampling container is inside a container that can't accept it.

[DanH]

@ustk Well even if I just put it as the very first node / thing in an empty script fx (i.e in the main green box) the error appears...

Will probably dissapear in the next update

[Matt_SF]

@danh can't really tell without seeing what's in the graph. But as @ustk said, some nodes won't be accepted in others, i.e. a modChain can't sit in an oversampleChain.

[DanH]

@matt_sf Thanks, have a look below if you can Not sure I can make a more basic example lol

[lalalandsynth]

@danh Yep , same problem here , moving from an existing project in older version of HISE.
I am using the oversampling for the convolution reverb and getting the error "it cannot use the oversample in a polyphonic network."

If I try to move the Convolution out of the oversample it crashes.

Also for my "Ensemble FX " Oversample error as well as "samplerate mismatch" on a few of the modules inside of the oversample , makes sense as it expects a higher sample rate.
But this one had modchains within the oversample - to be honest, not sure why I was using the oversample here ?

[DanH]

@lalalandsynth latest develop?

[lalalandsynth]

@danh
Pretty sure , is this fixed for you ?

Downloaded a couple of days ago.
https://github.com/christophhart/HISE/tree/develop

[Christoph Hart]

@lalalandsynth I fixed the oversampling nodes throwing errors in monophonic contexts, but you can't use oversampling (or convolution) in a polyphonic context.

[lalalandsynth]

@christoph-hart Jus using it for a convolution reverb , when was this fixed , maybe i need to build again.

[Christoph Hart]

@lalalandsynth https://github.com/christophhart/HISE/commit/d02067242dc1a19289614d566441fba3adfafb79