OpenGL ComboBox, And "NO" By Default

[Dan Korneff]

@Christoph-Hart where can we find this setting in the source? Would like to have the OpenGL combo box visible, and default to OFF on plugin init (or at least set to the project setting when you export).

[Dan Korneff]

EDIT: this isn't working :(

nevermind... changing StandalonePopupComponents.cpp 128
from

#if !HISE_USE_OPENGL_FOR_PLUGIN

to

#if HISE_USE_OPENGL_FOR_PLUGIN

is working here.

[Christoph Hart]

@dustbro Yeah, I need to add another preprocessor (something like HISE_ENABLE_OPENGL_BY_DEFAULT). This macro will deactivate the entire OpenGL thing.

[Dan Korneff]

@Christoph-Hart

[DanH]

@dustbro could you not include the general settings xml in your installer and set the opengl to 0?

[Dan Korneff]

@DanH That's a short term solution that would work... but then I have to update a bunch of installers, write post-install scripts for the new files, answer endless tech support emails about why their default GUI zoom setting reset to 100% because the script accidentally overwrote an existing xml with their most favorite zoom setting in the world, then defend my product on SlutSpace cause if I can't keep track of a single xml file how can the customer trust the DSP under the hood. This, of course, would coincide with an unplanned ilOk Cloud outage that prompts 35.7% of my customer base to set their studios on fire.
Not good for business

[DanH]

@dustbro lol! It shouldn't overwrite the existing settings file though, should it? Anway, let's hope this can be added :)

[Christoph Hart]

@DanH Crisis averted:

- added HISE_DEFAULT_OPENGL_VALUE preprocessor · christophhart/HISE@424b619

The open source framework for sample based instruments - - added HISE_DEFAULT_OPENGL_VALUE preprocessor · christophhart/HISE@424b619

GitHub (github.com)

[Dan Korneff]

@Christoph-Hart yay!!

[Dan Korneff]

@Christoph-Hart Do we have to make any additional changes to get this to work? I have HISE_USE_OPENGL_FOR_PLUGIN=1 set in Extra Definitions cause the combo box doesn't show up inthe export without it.
The GeneralSettings.xml is still being created with OPEN_GL=1 even if the plug-in is set to "no" when exporting.

[Christoph Hart]

@dustbro You have to add HISE_DEFAULT_OPENGL_VALUE=1

[Dan Korneff]

@Christoph-Hart
Setting HISE_DEFAULT_OPENGL_VALUE=1 exports with openGL enabled by default.
I have set:

HISE_USE_OPENGL_FOR_PLUGIN=1 
HISE_DEFAULT_OPENGL_VALUE=0

Now the OPEN_GL property is initializing properly, but the combo box disappears.

[Christoph Hart]

@dustbro yeah, it's Big brain time over here.

Should be fixed now.

[Dan Korneff]

@Christoph-Hart Thanks! confirmed