HISE Logo Forum
    • Categories
    • Register
    • Login

    Pretty weird problem with the Preset Browser ?

    Scheduled Pinned Locked Moved General Questions
    45 Posts 5 Posters 2.9k Views
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • ustkU
      ustk @lalalandsynth
      last edited by

      @lalalandsynth I might have found the problem for the 2 columns renaming issue

      Not sure for the prev/next selection issue though…
      Can you please tell if this happens in 2 columns mode as well?

      Hise made me an F5 dude, browser just suffers...

      lalalandsynthL 1 Reply Last reply Reply Quote 0
      • lalalandsynthL
        lalalandsynth @ustk
        last edited by

        @ustk You mean 3 columns mode as well ?
        I tested 3 columns the other day , no renaming problem there but I will verify .

        https://lalalandaudio.com/

        https://lalalandsynth.com/

        https://www.facebook.com/lalalandsynth

        https://www.facebook.com/lalalandsynth

        ustkU 1 Reply Last reply Reply Quote 0
        • ustkU
          ustk @lalalandsynth
          last edited by

          @lalalandsynth Ok so I fixed the 2 columns renaming issue as well as preset highlighting inconsistency on prev/next (for both 2 & 3 cols)
          Although I'm still struggling with preset disappearing on prev/next in 2 columns mode...
          But it's late and night is the mother of counsel! I'll have fun with that tomorrow :)

          Hise made me an F5 dude, browser just suffers...

          lalalandsynthL 1 Reply Last reply Reply Quote 3
          • lalalandsynthL
            lalalandsynth @ustk
            last edited by lalalandsynth

            @ustk excellent !!

            https://lalalandaudio.com/

            https://lalalandsynth.com/

            https://www.facebook.com/lalalandsynth

            https://www.facebook.com/lalalandsynth

            1 Reply Last reply Reply Quote 0
            • ustkU
              ustk
              last edited by ustk

              Ok so now it's working, so I'm trying to extend this to the 1 column style that is broken too...

              Hise made me an F5 dude, browser just suffers...

              lalalandsynthL 1 Reply Last reply Reply Quote 1
              • lalalandsynthL
                lalalandsynth @ustk
                last edited by lalalandsynth

                @ustk Are you somehow fixing this within Hise or in c++ ?

                https://lalalandaudio.com/

                https://lalalandsynth.com/

                https://www.facebook.com/lalalandsynth

                https://www.facebook.com/lalalandsynth

                ustkU 1 Reply Last reply Reply Quote 0
                • ustkU
                  ustk @lalalandsynth
                  last edited by

                  @lalalandsynth In the source code so C++

                  Hise made me an F5 dude, browser just suffers...

                  lalalandsynthL 1 Reply Last reply Reply Quote 1
                  • lalalandsynthL
                    lalalandsynth @ustk
                    last edited by

                    @ustk yep, thought so , sweet !

                    https://lalalandaudio.com/

                    https://lalalandsynth.com/

                    https://www.facebook.com/lalalandsynth

                    https://www.facebook.com/lalalandsynth

                    1 Reply Last reply Reply Quote 0
                    • ustkU
                      ustk
                      last edited by

                      Now everything works except I have just noticed another bug. (actually, we can see it in your screen gif)
                      In 2 columns mode, you can't rename the Bank...
                      Taking a pause then back on it :)

                      Hise made me an F5 dude, browser just suffers...

                      1 Reply Last reply Reply Quote 2
                      • ustkU
                        ustk
                        last edited by

                        Ok so after scrutinizing the code for hours, I need help for this one (rename & delete don't appear in 2 columns mode)

                        I know it is because listbox->getNumSelectedRows() > 0 returns false for some reason... But what reason is beyond my skills 🙃

                        void PresetBrowserColumn::updateButtonVisibility()
                        {
                        	editButton->setVisible(false);
                        
                        	const bool buttonsVisible = showButtonsAtBottom && !isResultBar && currentRoot.isDirectory();
                        	const bool fileIsSelected = listbox->getNumSelectedRows() > 0;
                        
                        	addButton->setVisible(buttonsVisible);
                        	deleteButton->setVisible(buttonsVisible && fileIsSelected);
                        	renameButton->setVisible(buttonsVisible && fileIsSelected);
                        }
                        

                        Hise made me an F5 dude, browser just suffers...

                        lalalandsynthL 1 Reply Last reply Reply Quote 0
                        • lalalandsynthL
                          lalalandsynth @ustk
                          last edited by lalalandsynth

                          @ustk What do you mean by "delete" not appearing in 2 columns ?
                          Delete works for me...

                          Although its annoying that if I delete it goes back to category and I have to select that to see the presets again.

                          EDIT: This going back to category is another sometimes issue..?

                          https://lalalandaudio.com/

                          https://lalalandsynth.com/

                          https://www.facebook.com/lalalandsynth

                          https://www.facebook.com/lalalandsynth

                          ustkU 1 Reply Last reply Reply Quote 0
                          • ustkU
                            ustk @lalalandsynth
                            last edited by

                            @lalalandsynth said in Pretty weird problem with the Preset Browser ?:

                            @ustk What do you mean by "delete" not appearing in 2 columns ?
                            Delete works for me...

                            Bottom of the left column, there are no Rename and Delete only in 2 columns mode:

                            Although its annoying that if I delete it goes back to category and I have to select that to see the presets again.

                            EDIT: This going back to category is another sometimes issue..?

                            Will check that tomorrow, might be a lucky day :)

                            Hise made me an F5 dude, browser just suffers...

                            lalalandsynthL 1 Reply Last reply Reply Quote 1
                            • lalalandsynthL
                              lalalandsynth @ustk
                              last edited by

                              @ustk Ah, You mean delete and rename Category ! hehe.
                              I hadnt even noticed that yet ....indeed

                              https://lalalandaudio.com/

                              https://lalalandsynth.com/

                              https://www.facebook.com/lalalandsynth

                              https://www.facebook.com/lalalandsynth

                              ustkU 1 Reply Last reply Reply Quote 1
                              • ustkU
                                ustk @lalalandsynth
                                last edited by ustk

                                @lalalandsynth Yep, I meant:

                                In 2 columns mode, you can't rename the Bank....

                                :)

                                Hise made me an F5 dude, browser just suffers...

                                1 Reply Last reply Reply Quote 1
                                • ustkU
                                  ustk
                                  last edited by

                                  The preset browser is fixed. Although I'm a C++ noob, so it certainly could have been done in a better way, so feel free to make it better and teach me at the same time :)

                                  Here's my fork so it can be tested before I make a pull request to Dave's fork:
                                  (My fork is up to date with Dave's one, so only the preset browser is different...)
                                  https://github.com/ustk/HISE/tree/develop

                                  Still, the last remaining issue is that Rename and Delete buttons don't appear in the bank column when in 2 columns mode. I still need help with this one...

                                  Hise made me an F5 dude, browser just suffers...

                                  d.healeyD 1 Reply Last reply Reply Quote 2
                                  • d.healeyD
                                    d.healey @ustk
                                    last edited by

                                    @ustk Good work, I'll have a look later today and see if I can track down the rename/delete buttons.

                                    Libre Wave - Freedom respecting instruments and effects
                                    My Patreon - HISE tutorials
                                    YouTube Channel - Public HISE tutorials

                                    ustkU 2 Replies Last reply Reply Quote 1
                                    • ustkU
                                      ustk @d.healey
                                      last edited by ustk

                                      @d-healey Cool! if you haven't seen my post about it, here it is:
                                      https://forum.hise.audio/topic/2766/pretty-weird-problem-with-the-preset-browser/28
                                      When removing the second condition (fileIsSelected), they are showing back...

                                      Hise made me an F5 dude, browser just suffers...

                                      ustkU 1 Reply Last reply Reply Quote 1
                                      • ustkU
                                        ustk @ustk
                                        last edited by

                                        @ustk I think listboxmight be the issue...

                                        Hise made me an F5 dude, browser just suffers...

                                        1 Reply Last reply Reply Quote 1
                                        • ustkU
                                          ustk @d.healey
                                          last edited by ustk

                                          @d-healey That's all fixed, the buttons were not updated when there's no category column...
                                          I'm working to make the column width customizable

                                          Hise made me an F5 dude, browser just suffers...

                                          lalalandsynthL 1 Reply Last reply Reply Quote 3
                                          • lalalandsynthL
                                            lalalandsynth @ustk
                                            last edited by lalalandsynth

                                            @ustk is there a build for these fixes , my plugin is nearing completion, would love to have a fix for this issue.

                                            Edit: just saw there is a fork but is everything working now ?

                                            https://lalalandaudio.com/

                                            https://lalalandsynth.com/

                                            https://www.facebook.com/lalalandsynth

                                            https://www.facebook.com/lalalandsynth

                                            ustkU 1 Reply Last reply Reply Quote 0
                                            • First post
                                              Last post

                                            14

                                            Online

                                            1.9k

                                            Users

                                            12.3k

                                            Topics

                                            106.9k

                                            Posts