HISE Logo Forum
    • Categories
    • Register
    • Login

    Essential- choke / exclusive/ voice note groups

    Scheduled Pinned Locked Moved Feature Requests
    drumsessentialchoke groupexclusive groupvoice group
    32 Posts 5 Posters 4.5k Views
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • Dan KorneffD
      Dan Korneff @gorangrooves
      last edited by

      @gorangrooves @Christoph-Hart
      I've already noted this previously. It's currently impossible to create a drum plugin until it's sorted :(

      Dan Korneff - Producer / Mixer / Audio Nerd

      gorangroovesG 1 Reply Last reply Reply Quote 0
      • Dan KorneffD
        Dan Korneff
        last edited by

        Here was my thread

        Link Preview Image
        Sample not triggered if MIDI overlaps

        I've just started going thru all of the JUCE tutorials. Very interesting stuff. Also thumbing thru the HISE code to learn how you're handling these situation...

        favicon

        Forum (forum.hise.audio)

        Dan Korneff - Producer / Mixer / Audio Nerd

        1 Reply Last reply Reply Quote 0
        • gorangroovesG
          gorangrooves @Dan Korneff
          last edited by

          @dustbro Oh, man. This is no good. This is an essential feature we can't do without. This is standard on every professional sampler.
          @Christoph-Hart How quickly and what will it take to get this resolved, please?

          Goran Rista
          https://gorangrooves.com

          Handy Drums and Handy Grooves
          https://library.gorangrooves.com

          1 Reply Last reply Reply Quote 0
          • Christoph HartC
            Christoph Hart
            last edited by

            Alright, I‘ll ramp it up on my priority list then - I think the problem is that the system that assigns the event IDs is not supposed to accept multiple notes at the same time, but it shouldn‘t be too hard to fix this.

            gorangroovesG 1 Reply Last reply Reply Quote 1
            • gorangroovesG
              gorangrooves @Christoph Hart
              last edited by

              @Christoph-Hart Thank you so much. I have full confidence that you will nail it. And i promise you that it will be well worth your time. I will be releasing 15 drum instruments this year, as long as i get the first one working 100%. We are almost there!

              Goran Rista
              https://gorangrooves.com

              Handy Drums and Handy Grooves
              https://library.gorangrooves.com

              1 Reply Last reply Reply Quote 0
              • Dan KorneffD
                Dan Korneff
                last edited by

                giphy.gif

                Dan Korneff - Producer / Mixer / Audio Nerd

                1 Reply Last reply Reply Quote 0
                • Christoph HartC
                  Christoph Hart
                  last edited by

                  Check the develop branch :)

                  gorangroovesG 1 Reply Last reply Reply Quote 1
                  • gorangroovesG
                    gorangrooves @Christoph Hart
                    last edited by

                    Hey @Christoph-Hart, the hi-hat choke script you provided a while back has been working great for the regular hi-hat. I have since created an advanced version for variable hats which has several stages of open and close (tight, close, 25% open, 50%, 75%, 100% open). These are nested containers and I switch between them using CC64 controller. I have altered your original choke script to allows CC64 to choke notes. It works great.

                    Now, the next step where I am failing is that I am trying to add a choke script on the parent container (that contains 6 child containers) which would choke a note using another note. Basically, the same as what we achieved with your original script. However, it is not working properly. It starts working, then it fails. It gives me a number of warnings, such as:

                    Shank100 Script:! onNoteOn() - Line 28, column 36: Illegal operation in audio thread: String creation {U2hhbmsxMDAgU2NyaXB0fG9uTm90ZU9uKCl8NzQ0fDI4fDM2}
                    

                    The line of code in question is:

                    Synth.addVolumeFade(eventId, decayValue, -100);
                    

                    This happens for all child containers that get played once I start using the controller. This "choke by controller" script is present in 4 child containers and works great until the parent "choke by note" script is enabled. I am guessing that there is some sort of double volume fade clash, but I don't know how to go around it.

                    Can you help, please?

                    Thank you!

                    Goran Rista
                    https://gorangrooves.com

                    Handy Drums and Handy Grooves
                    https://library.gorangrooves.com

                    Dan KorneffD 1 Reply Last reply Reply Quote 0
                    • Dan KorneffD
                      Dan Korneff @gorangrooves
                      last edited by

                      @gorangrooves Do you have a script you can share for your hi-hat implementation? Or maybe some hints on your experience? I'm updating some of my drum stuff and would like to have better compatibility with e-drum controllers.

                      Dan Korneff - Producer / Mixer / Audio Nerd

                      d.healeyD 1 Reply Last reply Reply Quote 0
                      • d.healeyD
                        d.healey @Dan Korneff
                        last edited by

                        @Dan-Korneff There is a built in choke group script now, will that do what you need?

                        11c01958-0d49-408b-96f5-aa6d22c1fbc2-image.png

                        Libre Wave - Freedom respecting instruments and effects
                        My Patreon - HISE tutorials
                        YouTube Channel - Public HISE tutorials

                        Dan KorneffD 1 Reply Last reply Reply Quote 0
                        • Dan KorneffD
                          Dan Korneff @d.healey
                          last edited by

                          @d-healey Good question. I'll give that a look. Thanks!!

                          Dan Korneff - Producer / Mixer / Audio Nerd

                          gorangroovesG 1 Reply Last reply Reply Quote 0
                          • gorangroovesG
                            gorangrooves @Dan Korneff
                            last edited by

                            @Dan-Korneff Are you referring to the regular GM hats open/close/foot or the variable hats?
                            My plugins utilize both for compatibility.

                            The design I came up with for the variable hats is unique to my plugins, and they work with e-drums. The basic principle is that there are 2 notes: one for the hat tip and the other for the edge. You use CC4 to control the openness.

                            The way I accomplished that is by having parallel samplers: 6 for the tip and 6 for the edge. Each goes like: tightly closed/ closed/ 25% open/ 50% open/ 75% open/ 100% open. So, by operating CC4, you move between those samplers and mute notes in others that are not within a specified range.

                            This system is not 100% compatible with e-drums out of the box. They still need to set all of their tip to one note and all of their edge to another. I made the system that is the most practical, in my opinion, and can work with either e-drums or keyboard controllers, as well as being able to edit things easily with a mouse.

                            I'll gladly share the scripts with you if this is the system you want to implement.

                            Goran Rista
                            https://gorangrooves.com

                            Handy Drums and Handy Grooves
                            https://library.gorangrooves.com

                            1 Reply Last reply Reply Quote 1
                            • First post
                              Last post

                            22

                            Online

                            1.8k

                            Users

                            12.0k

                            Topics

                            104.8k

                            Posts