Calling functions in midi processors...

[Lindon]

@Stroggan yes I'm sure and thanks for that but Dave and I (I think) are trying to work out the Correct way to do this....

[Stroggan]

I'm looking forward to learn the correct way as well then

[Lindon]

I cant even get the "interface" to show up any more - all I get is Canvas:ScriptProcessor1

[Lindon]

@Lindon said in Calling functions in midi processors...:

const var Knob1 = Content.addKnob("Knob1", 0, 0);

heres the snippet now.... it all seems broken to me

HiseSnippet 1581.3oc6X0raaaDDdokYhsZTQSZNzC8.gQKfCpqgj0eIsnHx+GiDGqJ4DzCFHcM4J6ElbWVxkNQIH25ySQQeAZu0mi9Fj2f1YWRZtJV1gLINQso5f.2Ymg6Ly2ty7sra.2lDFxCPFyt6PeBx3Jl8GxDGt5gXJCs0ZHiOxTPBE83QBBZkg93vPhCxvnzlRELlcZj52Kt8JXWLyljIBgdHmZStG0iJxj1sycottafcH6R8zztQmsr4rU4t7HvYJYVE4isOBe.49XoZSYhLtz5NTAOnu.CdDxX5U3NC6eH+wrX8eHMjtuKQNnFpO7hhEuA20Q5wRonUOj55zMMnCQHCytYofRwofqatM0gdh7rTwmnlvJyB87gwTmm6US28ple2yPy8lN18tpYe6.puHalXXZKlfDL.aOJLEqKZpJFlqxAMXhE8vGQ1H.FbhEy2pZ0ErZVs5M91JkqTdPDyVP4LKN69bAYG172nR4mUorE7K9e3UExcIK5GPYh4mixr4dT1AyIse1Wx8psnuKd31CkuJXgVnV7x77SuNCFL+MJ+rxyV945SIc6.tqKIXbyJ2EEbNlMOKxaeRvBVGiciHo5AIyQQKyyFsz2LYGmB0Tjy1hQE63SXmEFhRx6vSOXq0vBrDVSjA54SBDToKXrF4X37RLHOq4ZjviDbe3Dyo1A.6C4NQtXwnaNkmHSl.RAirKPhzrPpXn9I1Kjcr40cupYWpv9vw6uSMF+ExZWz9ax4+JlqOX.wVj4rSatwObweXW2Ul4LpFOiopnZs2Fkh8ycoXiRugkdq9uuRu++4tODO284wtx0L6KBHXYOs9XOen2ixepn3BkJ4LNB9ie+C9s29GA6FPb4Xm9zmpo1ezYkHHkELpzesiZoV1iGwFYsRb7dDeBV.6.zrYlN85sY.Ox+ks5E2VseY2.fMFjMzmXGFAR8B8Xb0.dX3.HbTuqP8o5FEbfLWkIoG4XRP3nxtejG.+LFwU1T1vP1zLjHgap81XQ.8I5ZqVkp6hUP9WZtTiEG82w6.+M3qjOdqUUiiMoVwMYohaR8haRihaRyhaRqhaR6BYhg4nGSub9XWsM1uKFfdMMWglb.DlKVhdSkS1to7NsFRioayktn51TJeA2aB49OMQZlGUabj7M9SSnpQn.35FXcWFe+ZVemUJqeriiTz7yolXtEr.F+.Q7wv0+zboeeyNu7aK14oAYpjpnSBNcQYAktTUvLF0xDcdj+i47CpCpJTX8Gmfp8coNP6DJ.kW1TgNHU5PuR2q0UGj554yYx023JuxEMqzZ2epyHL.BECkY6KoTD4QcbbIc4.OAI+grNB+dnf3m1K5YW+W17ud5OeaOctoHjG9I58PBg9WxZ5v86GPc8BgJ79a4AW6W1CFp7a4PFfibEVgP2GjKkcDwYWtR+2cDzJkOVFuhS3yl5i8oxBZqyNF5nCRj930.LSEmoRG8781bF2+PNiZOZ+SHacvAj.ceerAzxBAz9NSx06zi3RvgZaw9hN2ixH3fQoETnbQwq1MV75yLicWK44Mq+aPrtzG7DqOuTGTSR0i2BV8.wDNNeESEgHKIo82Wtp7qwBjwSIDaBrl6C2TvlnycdJY2m3wUkikNTeByQM3ugeISVKknsbxZoShrSeUPrk7rpCjQIBSx1RceQWfBu6HcJxpmiBUfpGPbC5fGO.YLSOt7JCSa1nE5d76RFpdtA5NzzmuIH+gx2pLQbGp5QSyZK0FkbEkDdfT2juMrq4ZeydKG4P46kDR836yE6IKkEvngh81zkaeD.N9ThalXKKc4Vw6ACylWMKTUzA3TYUsQqEeL9XzZQ9tTa.LkgO5TQUyZZQ0sxhpl0mLipl0xUTogUM0vplSnXUybgUszvplZXUqITrpUtvpVZXUKMrp0DJV0JWXUaMrpkFV0dBEqZmKrpsFV0VCqZOghUsyEVUWCqVRCqpOghU0yEVUWCqpqgU0mPwp54BqZngU00vpFSnXUiwgUuKnC8tXM7v1A7GYG+YBjDulQIAxzLUJdVyskisN46CHwF313zGYaKAsutFBMdKVpvVTuvVznvVzrvVzpvVztvVbyywB4mEb4HA2K9FdfftqGyJ1X8SXEWB8O.k21wZ

[d.healey]

@Lindon

const var Knob1 = Content.addKnob("Knob1", 0, 0);

--- but of course when I go to my interface its nowhere to be seen....how do I make it show up in my interface? how do I even edit it.

Controls should only be added this way to MIDI processors that aren't the user interface script. Is that the interface you are talking about? If so did you click the interface button (the one to the left of the callback buttons)?

[d.healey]

@Lindon

heres the snippet now.... it all seems broken to me

There are no controls on the main interface. Did you add any in the interface designer? Or did I lead you to believe they were added by the other script?

[Lindon]

@d-healey yes thats what you led me to belive I think...

OK what is the process of adding a slider to the midi processor of a sampler and have it show up in the main interface?

[d.healey]

@Lindon You have to add them to each separately.

For example I have an instrument and it has a sampler with a MIDI processor for handling legato, and another MIDI processor for handling round robin (nice and modular).

On my user interface I want to give the user a control to bypass the round robin script and to adjust the xfade time of the legato. But I don't want them to have access to the other controls of those scripts such as setting the playable range or the legato volume etc. So on my user interface I add a button and I connect this via parameter ID in the interface designer to the bypass button of my RR script, I also add a knob which is connected to the xfade knob of my legato script.

It seems like more work duplicating controls and I was put off at first, but actually it's very fast to do and allows me to easily create scripted modules that can be used in different projects and with entirely different interfaces.

I have a load of modules here you can play with - https://github.com/davidhealey/HISE-Scripting-Framework/tree/master/modules - I use the Connect to external script option from the context menu that appears when right-clicking on a MIDI processor's header.

[Lindon]

@d-healey OK, thanks.

[Lindon]

So then just the one outstanding question:

why oh why cant I say this in my main interface script:

const var myScriptProcessor = Synth.getMidiProcessor("myScriptProcessor");

myScriptProcessor.myFunction(param,param);

instead of this I have to create a set of interface widgets in myScriptProcessor, one for each param of myFunction then call another widget to execute the logic in myFunction

What is wrong with exposing the method(sorry Function) and allowing me to call it from somewhere else?

Surely we can all agree the current approach (if it is all we have) is a bit broken?

[d.healey]

@Lindon said in Calling functions in midi processors...:

So then just the one outstanding question:

why oh why cant I say this in my main interface script:

Because scripts can't talk to each other directly. You can do that using Global variables but it really isn't necessary.

instead of this I have to create a set of interface widgets in myScriptProcessor, one for each param of myFunction then call another widget to execute the logic in myFunction

Create your module and get it to work exactly how you want (makes it really easy to test the code is working) then add the controls to your UI that you want the user to have access to and link them together in the interface designer. It's a 10 minute job...

What is wrong with exposing the method(sorry Function) and allowing me to call it from somewhere else?

I can see this being useful and can't see a downside to it (maybe Christoph will see a pitfall) but it will kind of collapse the tree paradigm.

Surely we can all agree the current approach (if it is all we have) is a bit broken?

I haven't encountered any problems with it so far. Just requires a different way of thinking about problems.

[Christoph Hart]

It‘s definitely not broken, it enforces encapsulation and moves the responsibilty to operate on data to where it belongs.

If you want to avoid multiple controls, store them in a global data object (or multiple variables) and use a single button in your target script that fetches all values and do the appropriate thing.

[Lindon]

@Christoph-Hart there is nothing about callable functions that breaks encapsulation, so thats not a fair assessment I think. The responsibility to operate on data remains in exactly the same place, in the object where the function resides. All in the end we are talking about is a parameter passing paradigm, function call vs filling in (otherwise unused) widget values.

in fact this

myScriptProcessor.setAttribute(0,12);

breaks encapsulation - so I can set an attribute in a midiProcessor but I cant call a function.

You may have to excuse me I'm a SmallTalk programmer by training - so I have a bit of a purist view...

[Christoph Hart]

Yes there is - if you recompile the target script without recompiling the caller script, the function will point to a invalid root object and it will crash badly as soon as you call any API method. The lifetime of a compiled function must never exceed the lifetime of its root and this would make it very easy to violate that rule.

Worst case in the current approach is calling setAttribute with an invalid ID.