Preset Crashes Standalone MacOS

[hisefilo]

@Christoph-Hart Maybe making kind of lazy preset loading? I just speaking my mind. Logic PRO does not crash but takes a while (1s) to load some presets. I guess is preventing the crash or something.

[Christoph Hart]

@hisefilo no, I need to fix the race condition - Logic is just not crashing because it's laggy, but that isn't a solution...

[hisefilo]

@Christoph-Hart said in Preset Crashes Standalone MacOS:

@hisefilo no, I need to fix the race condition - Logic is just not crashing because it's laggy, but that isn't a solution...

let the SampleLoadingThread win LOL
thanks Christoph for being there! Is super important for us :)

[hisefilo]

@Christoph-Hart any update?? Now Logic crashes with preset loading :o

[hisefilo]

@Christoph-Hart and AudioPluginHost also crashed

-------------------------------------
Translated Report (Full Report Below)
-------------------------------------

Process:               AudioPluginHost [1581]
Path:                  /Users/USER/*/AudioPluginHost.app/Contents/MacOS/AudioPluginHost
Identifier:            com.juce.pluginhost
Version:               1.0.0 (1.0.0)
Code Type:             ARM-64 (Native)
Parent Process:        launchd [1]
User ID:               501

Date/Time:             2023-04-05 13:31:27.6255 -0300
OS Version:            macOS 13.0 (22A8380)
Report Version:        12
Anonymous UUID:        1A53BBE3-57ED-73DB-15D5-619959A054A6


Time Awake Since Boot: 1800 seconds

System Integrity Protection: enabled

Crashed Thread:        0  JUCE Message Thread  Dispatch queue: com.apple.main-thread

[Christoph Hart]

@hisefilo Can you check two things?

1. Add another lock statement before this line: https://github.com/christophhart/HISE/blob/2deb09cfc20dbfa80d8db5c9201cc605e27cfd6c/hi_components/floating_layout/FrontendPanelTypes.cpp#L1003

        if (!getMainController()->getMacroManager().isMacroEnabledOnFrontend())
	{
                hise::SimpleReadWriteLock::ScopedWriteLock sl(connectionLock);
		connectionList.clear();
		return 0;
	}

1. If this doesn't work, remove this loop here: https://github.com/christophhart/HISE/blob/2deb09cfc20dbfa80d8db5c9201cc605e27cfd6c/hi_components/floating_layout/FrontendPanelTypes.cpp#L1009

This will break the macro functionality entirely but we can then at least confirm that it's the real cause and not masking something else.

[hisefilo]

@Christoph-Hart Hi Christoph! thanks for the time.

I still getting crashes after that. (Do I need to recompile HISE itself?, or just to point to the modified source)
Update. I did both with the same results

Termination Reason:    Namespace SIGNAL, Code 11 Segmentation fault: 11
Terminating Process:   exc handler [6043]

VM Region Info: 0x34 is not in any region.  Bytes before following region: 105553518919628
      REGION TYPE                    START - END         [ VSIZE] PRT/MAX SHRMOD  REGION DETAIL
      UNUSED SPACE AT START
--->  
      MALLOC_NANO (reserved)   600018000000-600020000000 [128.0M] rw-/rwx SM=NUL  ...(unallocated)

Thread 0 Crashed:: JUCE Message Thread Dispatch queue: com.apple.main-thread
0   SandStorm                     	       0x102fcdfb4 hise::FrontendMacroPanel::getNumRows() + 256
1   SandStorm                     	       0x102fcdf6c hise::FrontendMacroPanel::getNumRows() + 184
2   SandStorm                     	       0x103b710a4 juce::ListBox::updateContent() + 68
3   SandStorm                     	       0x102fce804 non-virtual thunk to hise::FrontendMacroPanel::macroConnectionChanged(int, hise::Processor*, int, bool) + 24
4   SandStorm                     	       0x1030cd8d8 std::__1::__function::__func<hise::MacroControlBroadcaster::sendMacroConnectionChangeMessageForAll(bool)::'lambda'(), std::__1::allocator<hise::MacroControlBroadcaster::sendMacroConnectionChangeMessageForAll(bool)::'lambda'()>, void ()>::operator()() + 252
5   SandStorm                     	       0x103a7a2d8 juce::MessageQueue::deliverNextMessage() + 288
6   SandStorm                     	       0x103a7a16c juce::MessageQueue::runLoopSourceCallback(void*) + 20
7   CoreFoundation                	       0x1b0981a34 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 28
8   CoreFoundation                	       0x1b09819c8 __CFRunLoopDoSource0 + 176
9   CoreFoundation                	       0x1b0981738 __CFRunLoopDoSources0 + 244
10  CoreFoundation                	       0x1b098033c __CFRunLoopRun + 836
11  CoreFoundation                	       0x1b097f8a4 CFRunLoopRunSpecific + 612
12  HIToolbox                     	       0x1b9ff43bc RunCurrentEventLoopInMode + 292

[hisefilo]

@Christoph-Hart still getting customers with crashes. Now Ableton joined the list. Any chance to get a patch or something?

[hisefilo]

@Christoph-Hart Hi sir!! Congrats on 3.5!!!
I found this commit. It fixes the race condition for preset loading?? Just wondering :)

- added UserPresetHandler.isCurrentlyLoadingPreset() · christophhart/HISE@6535012

The open source framework for sample based instruments - - added UserPresetHandler.isCurrentlyLoadingPreset() · christophhart/HISE@6535012

GitHub (github.com)

[hisefilo]

@Christoph-Hart Well, new project, new HISE 3.5.0 and crashed repeatedly on FrontendMacroPanel::getNumRows()

I added this (cardinal sin) and stoped crashing (by now).
on https://github.com/christophhart/HISE/blob/2deb09cfc20dbfa80d8db5c9201cc605e27cfd6c/hi_components/floating_layout/FrontendPanelTypes.cpp#L1009

It's there any other quick way to do it???

Please tell me you wont kick me out of the forum!!!

	for (int i = 0; i < 8; i++)
	{
        Thread::sleep(1); // Forgive me for this!!
        
		auto d = macroChain->getMacroControlData(i);
		for (int j = 0; j < d->getNumParameters(); j++)
		{
            
			newList.add(d->getParameter(j));
            
		}
	}

[Adam_G]

@hisefilo did you make any progress on this? im afraid i now have the same problem.. :(

[Christoph Hart]

@Adam_G I've rewritten some of the macro control code to reduce the multithreading issues, but I can't guarantee that it solves your problem). You might want to try out the latest state and see if it helps.

[Adam_G]

@Christoph-Hart thank you oh wise one this resolved my issue with the presets causing crashes. part of my script is now broken though - API call with undefined parameter 2. what was changed?

[d.healey]

@Adam_G said in Preset Crashes Standalone MacOS:

. what was changed?

Type safety!

Inb4 Dave says "tell me more"... https://github.com/christophhart/hise_documentation/blob/master/scripting/scripting-in-hise/additions-in-hise.md#type-safety

Forum (forum.hise.audio)

[Adam_G]

@d-healey oh boy

[Dan Korneff]

@Adam_G It's been driving me crazy all day :face_with_head-bandage:

[Adam_G]

@Dan-Korneff it doesnt seem like too much is broken in my project lucky for me but im lost trying to figure out how to make what IS broken not be hah

[ThinkTank]

Is this still an issue?

I got crashes on macOS, but not on preset loading, it just crashes on start.