[bug] Shortcut keys not working properly

[Christoph Hart]

@d-healey Maybe it's our old friend with the d and D mixup again. Can you check if you can reassign F2 / F3 keys?

[d.healey]

@Christoph-Hart Yeah it works with F keys :)

[d.healey]

Bumpy bumpy

[d.healey]

Bump again @Christoph-Hart Can you point me to where I need to be to fix this?

[d.healey]

While you're fixing annoying bugs, this one annoys me :)

[d.healey]

:D

[Dan Korneff]

@Christoph-Hart Any chance we can get some shortcuts working again, as well as the search function?
Really having a hard time without the search.

[d.healey]

@Dan-Korneff Search is working here. What is not working for you?

[Dan Korneff]

@d-healey I always get "0 occurrences found" when I use the search function. It works properly in Linux, but not Win or Mac here.

[d.healey]

@Dan-Korneff What if you change the ignore case option?

[Dan Korneff]

@d-healey Changing any of the options shows the same result

[Dan Korneff]

@d-healey It looks like it works if I manually type in the search term, but highlighting text and selecting "Find All Occurrences" doesn't

[ulrik]

@Dan-Korneff Yes it behaves the same for me

[Matt_SF]

@Dan-Korneff same here too

[Christoph Hart]

Ah yes, that's right, I broke this when I rewrote the search box logic.

BTW, you can use special search modes for

• namespaces (n)
• functions (fn)
• variables (reg, const and var) (v)
• symbols (namespaces, functions and variables) (s)
• files (f)

Just type the letters above, then a space and the search term, so if you're looking for a symbol named mySymbol, type in

s mySymbol

If you're looking for a file called MyFile.js, type in

f MyFi...

If you use the symbol / function / variables search mode it will also display a preview of the object when you select a line (this only works in symbol mode :

[d.healey]

@Christoph-Hart Excellent, thank you, this looks very useful! Did you fix the shortcut key issue too?

[Christoph Hart]

@d-healey I think the issue is in this line:

https://github.com/christophhart/HISE/blob/fcfdcda74348bf4723479ea92e5ac497dd60f21a/hi_tools/hi_tools/MiscToolClasses.h#L584

It checks if the current key press is in the list of assigned key presses, however something on Linux messes with the default comparison operator so you might have to compare them manually (I don't have access to a Linux system at the moment so you need to get your hands dirty yourself). So instead of this line, add something like

for(auto ak: t->keyMap.getKeyPressesAssignedToCommand(idx))
{
     if(ak.mods == k.mods &&
        ak.getKeyCode() == k.getKeyCode())
     {
          return true;
     }
}

(the condition is totally bogus and won't compile), but you might try different things until you find something that works reliably :)

[d.healey]

@Christoph-Hart Thank you, I'll play around with it.

[d.healey]

@Christoph-Hart I don't think that is where the problem is. I've been playing around with this some more and here are the steps to reproduce the problem and some things I notice.

Open HISE and go to File >> Edit Shortcuts

Scroll down to the Duplicate selection at cursor action, you will notice it is set to ctrl+ D and this does not work on GNU/Linux.

Click the + button and assign ctrl + D to the command.
It will look like this and will work on GNU/Linux.

Close HISE and open the KeyPressMappings.xml file. You will see ctrl + D has been added correctly.

Keep that file open and launch HISE, then close HISE. You'll see the mapping disappears from the xml file.

[Dan Korneff]

@Christoph-Hart said in [bug] Shortcut keys not working properly:

I don't have access to a Linux system at the moment

Do you need access to one? ;)