Problems with plugin and Logic

[ulrik]

@danial Thank you!

[resonant]

@ulrik
It crashes. Logic 10.4.1 / macOS Sierra / HISE 1.6.0 (29.04.2018 build). Here is the Crash report:

Dropbox - File Deleted - Simplify your life

(www.dropbox.com)

[ulrik]

@remarkablex Thanks for checking!

[Christoph Hart]

Seems indeed to be related to the issue of dustbro. Weird that I don‘t encounter this in my projects...

[ulrik]

@christoph-hart Yeah, strange.
Can I be of any assistance for finding what the issue is?
I am able to compile the plugin as a debug version, and it loads in Logic

[Christoph Hart]

I‘ll investigate it now but it seems that one of the threads is deleting a sample reference while the other one uses it.

I‘ll try your project and see if I can replicate it.

[Christoph Hart]

I think I've found the issue:

When the plugin is loaded the first time, it will be created and deleted very quickly. However the creation spins off the sample preloading on another thread which then tries to access the already deleted sampler.

I never ran into this issue because all plugins I've done so far do not load samples at the initialisation (instead they have an empty samplemap load samples dynamically when the sampleset is selected). This prevents the sample loading thread to start during initialisation.

The solution was rather easy: when the plugin is destroyed, make sure that the preloading is cancelled before proceeding with the deletion of the sampler.

@dustbro this should also fix your problems (I ran into the exact same locations only in release mode).

@ulrik I've fixed the issue on Windows, but I am pretty certain that it will solve it on macOS too, but please try again. BTW, nice samples. You might want to add some key noise sounds (also on release), these make these kind of organs much more organic.

[ulrik]

@christoph-hart Thank you for your clever investigation skills :) , yes I will try the new Hire source tonight.
And thank you for nice comments and suggestions for my pump organ! :)

[ulrik]

@christoph-hart It's working!! Thanks again for the fix! :)
I have no problems what so ever to launch it in Logic, no problems validating after compiling the plugin with the latest Hise

[Dan Korneff]

@christoph-hart It's like magic!! yay~!!