Problems with plugin and Logic

[A Former User]

Validates and plays fine in Logic 10.2.4 & Hise/SDK version 17.04.18
Love the organ GUI!

[ulrik]

@danial
Hmm, I run Logic 10.4.1 on MacOS 10.13.4, I wonder if it has something to do with my Logic or with the OS.
What is the SDK version you're referring to?
What version of Hise did you use to build it?

Thanks a lot for taking the time to try it on your system, it means a lot to be able to find what's causing the trouble I have, even if it doesn't give me any hints were to look :) , and thank you for the nice GUI comments :)

Cheers!

[Dan Korneff]

Your issues may be related to a problem I'm having with loading samples.
Check here:
https://forum.hise.audio/topic/684/reaper-vsti/10

[ulrik]

@dustbro Ah, ok, I'll keep an eye on that topic, thank you!

[A Former User]

Downloaded the hise-master available on the 18th April. Sierra 10.12 Xcode 8.32 Not the current version but auvaltool came up with this: Hope it helps.
aumu Trex Mubo - musikboden: Tramporgel Extended
JUCE v5.2.0
Initialising MainController
Checking license
Load images
Load impulses
Restoring main container
Compiling all scripts
Adding plugin parameters
Restoring global settings
Samples are validated. Skipping reference check
Loading samples
JUCE Assertion failure in juce_AudioProcessor.cpp:1220
Segmentation fault: 11

[ulrik]

@danial Thank you!

[resonant]

@ulrik
It crashes. Logic 10.4.1 / macOS Sierra / HISE 1.6.0 (29.04.2018 build). Here is the Crash report:

https://www.dropbox.com/s/8sifpj7bzuxaci2/Report.txt?dl=0

[ulrik]

@remarkablex Thanks for checking!

[Christoph Hart]

Seems indeed to be related to the issue of dustbro. Weird that I don‘t encounter this in my projects...

[ulrik]

@christoph-hart Yeah, strange.
Can I be of any assistance for finding what the issue is?
I am able to compile the plugin as a debug version, and it loads in Logic

[Christoph Hart]

I‘ll investigate it now but it seems that one of the threads is deleting a sample reference while the other one uses it.

I‘ll try your project and see if I can replicate it.

[Christoph Hart]

I think I've found the issue:

When the plugin is loaded the first time, it will be created and deleted very quickly. However the creation spins off the sample preloading on another thread which then tries to access the already deleted sampler.

I never ran into this issue because all plugins I've done so far do not load samples at the initialisation (instead they have an empty samplemap load samples dynamically when the sampleset is selected). This prevents the sample loading thread to start during initialisation.

The solution was rather easy: when the plugin is destroyed, make sure that the preloading is cancelled before proceeding with the deletion of the sampler.

@dustbro this should also fix your problems (I ran into the exact same locations only in release mode).

@ulrik I've fixed the issue on Windows, but I am pretty certain that it will solve it on macOS too, but please try again. BTW, nice samples. You might want to add some key noise sounds (also on release), these make these kind of organs much more organic.

[ulrik]

@christoph-hart Thank you for your clever investigation skills :) , yes I will try the new Hire source tonight.
And thank you for nice comments and suggestions for my pump organ! :)

[ulrik]

@christoph-hart It's working!! Thanks again for the fix! :)
I have no problems what so ever to launch it in Logic, no problems validating after compiling the plugin with the latest Hise

[Dan Korneff]

@christoph-hart It's like magic!! yay~!!