Aborting downloads = paused

[d.healey]

Thanks Matt, I already had a look at the C++ myself but I quickly got lost. The abort function calls the stop function which triggers the pause action and some other stuff. I shall wait for master Christoph :)

[Matt_SF]

@d-healey said in Aborting downloads = paused:

I already had a look at the C++ myself but I quickly got lost.

I thought you did. I ended up a bit lost too among these functions

[ustk]

@d-healey Just examined the source, it appears that abort is just a stop with delete file. I partly fixed it but the callback's still fired every 500ms... Will tell if I get somewhere ;)

EDIT sorry I started the message long ago so I haven't seen you looked at the code already :)

[ustk]

I should add that everything works if you call a clean after abort. so it is usable with a simple fix.
But it would be better handled automatically. Having a look...

[ustk]

Another problem, with a bad connection, the download often passes to "finished" state, with no resume option (except clean and start again). A timeout safety could be good, like waiting 10sec before declaring a download stopped (so internally it is not finished and could be resumed manually after fixing the "bad connection))

[d.healey]

Bump bump @Christoph-Hart :)

[d.healey]

@ustk Is this issue solved by your pull request?

[ustk]

@d-healey Yes it should be.

[d.healey]

@ustk Excellent, I'll try it out!

[d.healey]

@ustk Yeah that works great, thanks!

[d.healey]

@ustk said in Aborting downloads = paused:

@d-healey Yes it should be.

Is this still working for you? Seems to be broken in the latest commit for me.

HiseSnippet 1039.3ocsVstiaSDEd7l0.1PKTId.rxubjBNIksEDU.oIYCJhlsQ0sU7upI1i2LZGOi0LiCMTkGRdS3M.Niuj3.YWsJhleD4y8uyEeNdgTDQTJgDY475MYDj0WXGtgqWMdElxQylfrdn8DwuyYBb7DRp.MZSFVoHwHKqV+hQGKmyQE+9qedDlg4Qj8rPn2JnQjWPSo58bWL7WoL1TbL40zzFZewvYQB9XASjC3okceTFN5F70jqvF0NyFY8IWFS0BYnFqIJj04iDwaBWA3qT+2RUzkLhgX.JDbTI6oBVrAwFtnwqnr3E04sBAdYw9pPqxpvWaOmFS2wee03qJD3s2hl0CqyNDdsN.dCZBu9Mf2QfjUCHcdIjdjcXjjlo2KwfmO2dFWSjIXnr2DJk5hN6OaYOV.Zv0Ao3aHSk.wNK7eZ+9c8f+57LW2PhbMQFnH5QXE4Mu5E9sWo0Y+PudsAwPiQo8frROkxHd+nWaZ15KBhqFMBzqn7aVJgGWh4wAQhzdOt+7QA+AMq8ybkjq8vKERMXXBloHP750yaolWOa4R4LJm3kjyizTA2SvaH0jBRAyGbalfCISWu0XVNoi6GbcnId9UTN.oCSDgYdIPnLPMbiRSRCtlnKlBj9MXV6dUGi7htfQpeaSdV.cSgwwopzTmrE5TWJ558gsc8R5tC49.LJvQAvJxZCmRVNPcRETvzG7sgCjaJAiDjIobse6majQhaWJcagJt0dqv5XrFGjP4T0JRbCWWgxHFAymVIdWFdKQqVuCCG7fgdqi6VH+qmeLkn55ue6Fcm1cLSMU8nwXFaI7Zq+wZfc102C0hL2i2zMht2Mbm5wJsLGlptS7Zb7cf0FwEvYCLckPSdoouBw1cqq2+VTRxQkU4KFLycLwlcex6xPedd5RhrYlaTDVHb3VF6aeKSykfQkkkFJJ3y3T8KyH7aa0HppVBO8lYSf4NypoJdfdYDolZff0DxZXOe4hJG6ID0MPwDVYuqAfr9TcgzGVsFaTtVK3HJrs5A1MlTPue+AgIC2rm3mFpIuG7i6t6QHEdMYFegj.sTyROpZtHEBFVB1YcF5dEcG6pdeiHOTbrH+k1F07t2g++tCGtdHhyYX8gmTL2QqD.S.GrG2rqlqn5MMuy9+1cl6KDej8BpNZ0ww3YGAivbxGCLVcc9A1WljPhz6A341S+sONmhQuRjqo7qmi0RJLgXeUdZH7AJQDH5bNgYdCDZ1FSKn6anMUfPBOtf3ugeUBGXnspDNnVHJEGIEuKp78dy8+OqfCfIdwm93XO2P6M.UrK.rytePeTJ7oHuKJxj9eC756ws4wmfMe6IXyEmfMO4Dr4omfMe2IXy2em1X9JvmmqEokuN.LVbYwBRKqK4XXxpXJD8O.QDnMV.

[ustk]

@d-healey the pull request has been made on develop and I'm not sure it has been merged… I thought you had merged it yourself on your own branch. Not at my comp to verify…

[d.healey]

@ustk Ah that explains it! @Christoph-Hart Mergy mergy please :)

[d.healey]

This problem is still there

[d.healey]

@d-healey Bump bump

[Casey Kolb]

@d-healey Did we ever get this fixed?

[d.healey]

@Casey-Kolb Yeah I think this was fixed ages ago, at least I haven't had any issues with aborting downloads for a long time