HISE Logo Forum
    • Categories
    • Register
    • Login

    Aborting downloads = paused

    Scheduled Pinned Locked Moved Bug Reports
    23 Posts 4 Posters 1.7k Views
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • d.healeyD
      d.healey
      last edited by

      Bump bump - the snippet in the last post demonstates the issue.

      Libre Wave - Freedom respecting instruments and effects
      My Patreon - HISE tutorials
      YouTube Channel - Public HISE tutorials

      Matt_SFM ustkU 2 Replies Last reply Reply Quote 0
      • Matt_SFM
        Matt_SF @d.healey
        last edited by

        @d-healey Hi, I tried your snippet and faced the same issue. I wish I could be of some help but I didn't find any solution.
        As you said it seems that the file won't be cleared if its state is not set to 'isFinished'.

        I recently watched your c++ tinkering video and started to take a look at HISE's source code, so here it is :
        Tell me if I'm completely wrong, but in ScriptingApiObjects.cpp line 649 is this function :

        bool ScriptingObjects::ScriptDownloadObject::abort()
        {
        	shouldAbort.store(true);
        	return stop();
        }
        

        Wouldn't it be possible to add something like that to set the aborted download to Finished ?

        data->setProperty("finished", true);
        

        Really I don't know c++, I'm just taking a shot here :grinning_face_with_sweat:

        Develop branch
        Win10 & VS17 / Ventura & Xcode 14. 3

        d.healeyD 1 Reply Last reply Reply Quote 0
        • d.healeyD
          d.healey @Matt_SF
          last edited by

          Thanks Matt, I already had a look at the C++ myself but I quickly got lost. The abort function calls the stop function which triggers the pause action and some other stuff. I shall wait for master Christoph :)

          Libre Wave - Freedom respecting instruments and effects
          My Patreon - HISE tutorials
          YouTube Channel - Public HISE tutorials

          Matt_SFM 1 Reply Last reply Reply Quote 1
          • Matt_SFM
            Matt_SF @d.healey
            last edited by

            @d-healey said in Aborting downloads = paused:

            I already had a look at the C++ myself but I quickly got lost.

            I thought you did. I ended up a bit lost too among these functions 😆

            Develop branch
            Win10 & VS17 / Ventura & Xcode 14. 3

            1 Reply Last reply Reply Quote 0
            • ustkU
              ustk @d.healey
              last edited by ustk

              @d-healey Just examined the source, it appears that abort is just a stop with delete file. I partly fixed it but the callback's still fired every 500ms... Will tell if I get somewhere ;)

              EDIT sorry I started the message long ago so I haven't seen you looked at the code already :)

              Can't help pressing F5 in the forum...

              1 Reply Last reply Reply Quote 1
              • ustkU
                ustk
                last edited by ustk

                I should add that everything works if you call a clean after abort. so it is usable with a simple fix.
                But it would be better handled automatically. Having a look...

                Can't help pressing F5 in the forum...

                1 Reply Last reply Reply Quote 0
                • ustkU
                  ustk
                  last edited by ustk

                  Another problem, with a bad connection, the download often passes to "finished" state, with no resume option (except clean and start again). A timeout safety could be good, like waiting 10sec before declaring a download stopped (so internally it is not finished and could be resumed manually after fixing the "bad connection))

                  Can't help pressing F5 in the forum...

                  1 Reply Last reply Reply Quote 1
                  • d.healeyD
                    d.healey
                    last edited by

                    Bump bump @Christoph-Hart :)

                    Libre Wave - Freedom respecting instruments and effects
                    My Patreon - HISE tutorials
                    YouTube Channel - Public HISE tutorials

                    1 Reply Last reply Reply Quote 0
                    • d.healeyD
                      d.healey
                      last edited by

                      @ustk Is this issue solved by your pull request?

                      Libre Wave - Freedom respecting instruments and effects
                      My Patreon - HISE tutorials
                      YouTube Channel - Public HISE tutorials

                      ustkU 1 Reply Last reply Reply Quote 0
                      • ustkU
                        ustk @d.healey
                        last edited by

                        @d-healey Yes it should be.

                        Can't help pressing F5 in the forum...

                        d.healeyD 2 Replies Last reply Reply Quote 2
                        • d.healeyD
                          d.healey @ustk
                          last edited by

                          @ustk Excellent, I'll try it out!

                          Libre Wave - Freedom respecting instruments and effects
                          My Patreon - HISE tutorials
                          YouTube Channel - Public HISE tutorials

                          1 Reply Last reply Reply Quote 0
                          • d.healeyD
                            d.healey
                            last edited by

                            @ustk Yeah that works great, thanks!

                            Libre Wave - Freedom respecting instruments and effects
                            My Patreon - HISE tutorials
                            YouTube Channel - Public HISE tutorials

                            1 Reply Last reply Reply Quote 2
                            • d.healeyD
                              d.healey @ustk
                              last edited by

                              @ustk said in Aborting downloads = paused:

                              @d-healey Yes it should be.

                              Is this still working for you? Seems to be broken in the latest commit for me.

                              HiseSnippet 1039.3ocsVstiaSDEd7l0.1PKTId.rxubjBNIksEDU.oIYCJhlsQ0sU7upI1i2LZGOi0LiCMTkGRdS3M.Niuj3.YWsJhleD4y8uyEeNdgTDQTJgDY475MYDj0WXGtgqWMdElxQylfrdn8DwuyYBb7DRp.MZSFVoHwHKqV+hQGKmyQE+9qedDlg4Qj8rPn2JnQjWPSo58bWL7WoL1TbL40zzFZewvYQB9XASjC3okceTFN5F70jqvF0NyFY8IWFS0BYnFqIJj04iDwaBWA3qT+2RUzkLhgX.JDbTI6oBVrAwFtnwqnr3E04sBAdYw9pPqxpvWaOmFS2wee03qJD3s2hl0CqyNDdsN.dCZBu9Mf2QfjUCHcdIjdjcXjjlo2KwfmO2dFWSjIXnr2DJk5hN6OaYOV.Zv0Ao3aHSk.wNK7eZ+9c8f+57LW2PhbMQFnH5QXE4Mu5E9sWo0Y+PudsAwPiQo8frROkxHd+nWaZ15KBhqFMBzqn7aVJgGWh4wAQhzdOt+7QA+AMq8ybkjq8vKERMXXBloHP750yaolWOa4R4LJm3kjyizTA2SvaH0jBRAyGbalfCISWu0XVNoi6GbcnId9UTN.oCSDgYdIPnLPMbiRSRCtlnKlBj9MXV6dUGi7htfQpeaSdV.cSgwwopzTmrE5TWJ558gsc8R5tC49.LJvQAvJxZCmRVNPcRETvzG7sgCjaJAiDjIobse6majQhaWJcagJt0dqv5XrFGjP4T0JRbCWWgxHFAymVIdWFdKQqVuCCG7fgdqi6VH+qmeLkn55ue6Fcm1cLSMU8nwXFaI7Zq+wZfc102C0hL2i2zMht2Mbm5wJsLGlptS7Zb7cf0FwEvYCLckPSdoouBw1cqq2+VTRxQkU4KFLycLwlcex6xPedd5RhrYlaTDVHb3VF6aeKSykfQkkkFJJ3y3T8KyH7aa0HppVBO8lYSf4NypoJdfdYDolZff0DxZXOe4hJG6ID0MPwDVYuqAfr9TcgzGVsFaTtVK3HJrs5A1MlTPue+AgIC2rm3mFpIuG7i6t6QHEdMYFegj.sTyROpZtHEBFVB1YcF5dEcG6pdeiHOTbrH+k1F07t2g++tCGtdHhyYX8gmTL2QqD.S.GrG2rqlqn5MMuy9+1cl6KDej8BpNZ0ww3YGAivbxGCLVcc9A1WljPhz6A341S+sONmhQuRjqo7qmi0RJLgXeUdZH7AJQDH5bNgYdCDZ1FSKn6anMUfPBOtf3ugeUBGXnspDNnVHJEGIEuKp78dy8+OqfCfIdwm93XO2P6M.UrK.rytePeTJ7oHuKJxj9eC756ws4wmfMe6IXyEmfMO4Dr4omfMe2IXy2em1X9JvmmqEokuN.LVbYwBRKqK4XXxpXJD8O.QDnMV.
                              

                              Libre Wave - Freedom respecting instruments and effects
                              My Patreon - HISE tutorials
                              YouTube Channel - Public HISE tutorials

                              ustkU 1 Reply Last reply Reply Quote 0
                              • ustkU
                                ustk @d.healey
                                last edited by

                                @d-healey the pull request has been made on develop and I'm not sure it has been merged… I thought you had merged it yourself on your own branch. Not at my comp to verify…

                                Can't help pressing F5 in the forum...

                                d.healeyD 1 Reply Last reply Reply Quote 0
                                • d.healeyD
                                  d.healey @ustk
                                  last edited by

                                  @ustk Ah that explains it! @Christoph-Hart Mergy mergy please :)

                                  Libre Wave - Freedom respecting instruments and effects
                                  My Patreon - HISE tutorials
                                  YouTube Channel - Public HISE tutorials

                                  1 Reply Last reply Reply Quote 0
                                  • d.healeyD
                                    d.healey
                                    last edited by

                                    This problem is still there

                                    Peek 2021-12-01 12-38.gif

                                    Libre Wave - Freedom respecting instruments and effects
                                    My Patreon - HISE tutorials
                                    YouTube Channel - Public HISE tutorials

                                    d.healeyD 1 Reply Last reply Reply Quote 0
                                    • d.healeyD
                                      d.healey @d.healey
                                      last edited by

                                      @d-healey Bump bump

                                      Libre Wave - Freedom respecting instruments and effects
                                      My Patreon - HISE tutorials
                                      YouTube Channel - Public HISE tutorials

                                      Casey KolbC 1 Reply Last reply Reply Quote 0
                                      • Casey KolbC
                                        Casey Kolb @d.healey
                                        last edited by

                                        @d-healey Did we ever get this fixed?

                                        Casey Kolb
                                        Founder & CEO of Lunacy Audio
                                        Composer | Producer | Software Developer

                                        d.healeyD 1 Reply Last reply Reply Quote 0
                                        • d.healeyD
                                          d.healey @Casey Kolb
                                          last edited by

                                          @Casey-Kolb Yeah I think this was fixed ages ago, at least I haven't had any issues with aborting downloads for a long time

                                          Libre Wave - Freedom respecting instruments and effects
                                          My Patreon - HISE tutorials
                                          YouTube Channel - Public HISE tutorials

                                          1 Reply Last reply Reply Quote 1
                                          • First post
                                            Last post

                                          15

                                          Online

                                          1.7k

                                          Users

                                          11.9k

                                          Topics

                                          103.6k

                                          Posts