Aborting downloads = paused

[d.healey]

I can see the abort command triggers the stop command. So I'm guessing that since the download is paused it never reaches the isFinished state and won't be cleared from the download queue.

[d.healey]

Here's a test snippet that demonstrates the issue. Press start to begin downloading a 100mb file. Press stop to abort the download. You'll see the download is paused, the file is deleted, but the paused/aborted download list never clears and won't clear even when pressing the clear button. In my real project the file occassionaly isn't deleted either, I'll try and recreate this in another snippet.

This problem also happens with the pause and abort control in the server control panel.

HiseSnippet 1205.3ocsW01aaaCDlxIJqx6ErNr8cA+IEfDE6sztgMLrTaGO3s3Ti31h8gBzQKQGSDIRARpz5EDf8Sa+j1+fsiTuFGGmLiE+Ic7ti74d3w6NOVvCHRIWfrbd0hDBx5Srmrfol2aNlxPC6ir9Ja7TtPseH+8rHNNbeEQpPcWjfkRRHxxZqeVapky1Hyu+9m5hivr.R0RHza3z.xIzXppZ0wG8qznnA3Pxqnw0r9viFFvY83Q7T.VaY2FkfCt.eN4Tr1rF1HqcNNjp3hIJL.Fj01c4gKlLG.Xl8ugJoSiHZgNnIvFks7.dTnFw5UQ8lSiBGWD9RDrKiqHisxHiuzdDMjVtdEo74FEtUdTmOrZrN30oN7Z+vgmUM3scF7dp8j.AMQUoQisO1dHSQDyvvUPcXkYKpwWricONXAS4GiufLP.Bkd3871s2y8Ysau6OzrIbMHUtJr3bhx8GcGPiHSVHUjXeXACbEd0VredFhrx2TQD3Xq4JUx2evAzjKOzuHOxWMmxtXp.9bJlE5GviOnS61i55+GzjVvNLgHtjH7kD0oowuHJh+dRX4Q30Y2aXRWrj75yNwq3nZoUKHm6Vbbf3rTVfhxYkq0CGEMExs71s4UMcnyb8.LI8CwJr+LJiJmSB2soCny4X14TFwWB2hi.pFxF8ZMH2D8Y4bcyqa17fCbmpXv8tPkS.Eh.KTP5.20iGmvYffWqBCzaRw25.RasfGUBQNqPatFc.RYQ.pbKCraYjWPwIsm6k3nTRYjlK4bkCDcQ7.bj6L.jYW1FLpy.02tdszu3M2J5.0of8.qy4+hULVCW49BRRjNYp51XO2qtdO2Y6cKt+VbGOoN0wSVOywSJINdxZ3Mdx8Sak17.XMfGzxkIyT4YoLFkct2tf5JRx2T7zaonbLNURpBSi35hSiA4Ap466LRMZuuPstQ+eFqRfBMgpCIBBHsSTYeB7ThDV59R9HHxzXxxDTuHBVTQPFw0QPFCxIHy22IAYzdeDTcidXDT9Kg.vQVQcgphU4QWsC4Tth7RVVgGHrcWV0rYqTWNlhfBuqRstQpXcN5wRimRD0iDsgPGka1xx9taYUuiZP18QMC4rgLp5kID1c0HCkeIBe85g8gRs5da4qA1kPDJpFBV8IWBCMj0oywtOQdAjdAHs7lGY8DkQ6mk2GrapRwYHJztqocQkPzGfvwxGNtEUyX7KGoHe.1fOxNyFI9RxP1XHYjnz8JoxQ7X3HvBvIqFDFFhdcK+SfDCl1BzCBFN14UVVEJ9y2lihcrMl7XABCWXdyuJT76yJ4hLaVFFq3bWBY+Gfg4k0pfwewJgQlMa.ab6Ijf4z3goQX0MGdSOwZtB34wMlRROIDSRUKpOQ6ixDcOT39T6wTUv7Ui2Fq.uvCpGa7lOe7mZe7rYj.UEX21dvu83OLL5LdpBZ.MBqDTcxDLg3D3uKDP.jvXP2GcBVCcwlL41ZYMyLgvBMB+C7KWYGsrUtxNEJQw3.A+cAYEN0Sf+DyJ.lXl+Hhi8HsraGjoXJ3mca+1nXHk7cAAZpXe.6q1mudC74a1.eNbC74YafOOeC74a2.e9t05itZvKRU73rmIvBiO1zgwx5XS4BSFI5eko4iwC

[d.healey]

Bump bump - the snippet in the last post demonstates the issue.

[Matt_SF]

@d-healey Hi, I tried your snippet and faced the same issue. I wish I could be of some help but I didn't find any solution.
As you said it seems that the file won't be cleared if its state is not set to 'isFinished'.

I recently watched your c++ tinkering video and started to take a look at HISE's source code, so here it is :
Tell me if I'm completely wrong, but in ScriptingApiObjects.cpp line 649 is this function :

bool ScriptingObjects::ScriptDownloadObject::abort()
{
	shouldAbort.store(true);
	return stop();
}

Wouldn't it be possible to add something like that to set the aborted download to Finished ?

data->setProperty("finished", true);

Really I don't know c++, I'm just taking a shot here :grinning_face_with_sweat:

[d.healey]

Thanks Matt, I already had a look at the C++ myself but I quickly got lost. The abort function calls the stop function which triggers the pause action and some other stuff. I shall wait for master Christoph :)

[Matt_SF]

@d-healey said in Aborting downloads = paused:

I already had a look at the C++ myself but I quickly got lost.

I thought you did. I ended up a bit lost too among these functions

[ustk]

@d-healey Just examined the source, it appears that abort is just a stop with delete file. I partly fixed it but the callback's still fired every 500ms... Will tell if I get somewhere ;)

EDIT sorry I started the message long ago so I haven't seen you looked at the code already :)

[ustk]

I should add that everything works if you call a clean after abort. so it is usable with a simple fix.
But it would be better handled automatically. Having a look...

[ustk]

Another problem, with a bad connection, the download often passes to "finished" state, with no resume option (except clean and start again). A timeout safety could be good, like waiting 10sec before declaring a download stopped (so internally it is not finished and could be resumed manually after fixing the "bad connection))

[d.healey]

Bump bump @Christoph-Hart :)

[d.healey]

@ustk Is this issue solved by your pull request?

[ustk]

@d-healey Yes it should be.

[d.healey]

@ustk Excellent, I'll try it out!

[d.healey]

@ustk Yeah that works great, thanks!

[d.healey]

@ustk said in Aborting downloads = paused:

@d-healey Yes it should be.

Is this still working for you? Seems to be broken in the latest commit for me.

HiseSnippet 1039.3ocsVstiaSDEd7l0.1PKTId.rxubjBNIksEDU.oIYCJhlsQ0sU7upI1i2LZGOi0LiCMTkGRdS3M.Niuj3.YWsJhleD4y8uyEeNdgTDQTJgDY475MYDj0WXGtgqWMdElxQylfrdn8DwuyYBb7DRp.MZSFVoHwHKqV+hQGKmyQE+9qedDlg4Qj8rPn2JnQjWPSo58bWL7WoL1TbL40zzFZewvYQB9XASjC3okceTFN5F70jqvF0NyFY8IWFS0BYnFqIJj04iDwaBWA3qT+2RUzkLhgX.JDbTI6oBVrAwFtnwqnr3E04sBAdYw9pPqxpvWaOmFS2wee03qJD3s2hl0CqyNDdsN.dCZBu9Mf2QfjUCHcdIjdjcXjjlo2KwfmO2dFWSjIXnr2DJk5hN6OaYOV.Zv0Ao3aHSk.wNK7eZ+9c8f+57LW2PhbMQFnH5QXE4Mu5E9sWo0Y+PudsAwPiQo8frROkxHd+nWaZ15KBhqFMBzqn7aVJgGWh4wAQhzdOt+7QA+AMq8ybkjq8vKERMXXBloHP750yaolWOa4R4LJm3kjyizTA2SvaH0jBRAyGbalfCISWu0XVNoi6GbcnId9UTN.oCSDgYdIPnLPMbiRSRCtlnKlBj9MXV6dUGi7htfQpeaSdV.cSgwwopzTmrE5TWJ558gsc8R5tC49.LJvQAvJxZCmRVNPcRETvzG7sgCjaJAiDjIobse6majQhaWJcagJt0dqv5XrFGjP4T0JRbCWWgxHFAymVIdWFdKQqVuCCG7fgdqi6VH+qmeLkn55ue6Fcm1cLSMU8nwXFaI7Zq+wZfc102C0hL2i2zMht2Mbm5wJsLGlptS7Zb7cf0FwEvYCLckPSdoouBw1cqq2+VTRxQkU4KFLycLwlcex6xPedd5RhrYlaTDVHb3VF6aeKSykfQkkkFJJ3y3T8KyH7aa0HppVBO8lYSf4NypoJdfdYDolZff0DxZXOe4hJG6ID0MPwDVYuqAfr9TcgzGVsFaTtVK3HJrs5A1MlTPue+AgIC2rm3mFpIuG7i6t6QHEdMYFegj.sTyROpZtHEBFVB1YcF5dEcG6pdeiHOTbrH+k1F07t2g++tCGtdHhyYX8gmTL2QqD.S.GrG2rqlqn5MMuy9+1cl6KDej8BpNZ0ww3YGAivbxGCLVcc9A1WljPhz6A341S+sONmhQuRjqo7qmi0RJLgXeUdZH7AJQDH5bNgYdCDZ1FSKn6anMUfPBOtf3ugeUBGXnspDNnVHJEGIEuKp78dy8+OqfCfIdwm93XO2P6M.UrK.rytePeTJ7oHuKJxj9eC756ws4wmfMe6IXyEmfMO4Dr4omfMe2IXy2em1X9JvmmqEokuN.LVbYwBRKqK4XXxpXJD8O.QDnMV.

[ustk]

@d-healey the pull request has been made on develop and I'm not sure it has been merged… I thought you had merged it yourself on your own branch. Not at my comp to verify…

[d.healey]

@ustk Ah that explains it! @Christoph-Hart Mergy mergy please :)

[d.healey]

This problem is still there

[d.healey]

@d-healey Bump bump

[Casey Kolb]

@d-healey Did we ever get this fixed?