Develop branch build status

[d.healey]

@Christoph-Hart My old friend has returned with the latest commit :)

../../../../../HISE/hi_dsp_library/snex_basics/snex_TypeHelpers.cpp:160:68: error: call of overloaded ‘var(int64_t&)’ is ambiguous
  160 |  case Types::ID::Pointer: v = var(*reinterpret_cast<int64_t*>(data)); break;

I think it's possibly fixed in this pull request - https://github.com/christophhart/HISE/pull/192

And another error I don't recognise

../../../../../HISE/hi_scripting/scripting/scriptnode/ui/NodeComponent.cpp:90:3: error: cannot convert ‘scriptnode::NodeComponent::Header::Header(scriptnode::NodeComponent&)::<lambda(juce::ValueTree&, bool)>’ to ‘const ChildChangeCallback&’ {aka ‘const std::function<void(juce::ValueTree, bool)>&’}
   90 |  });

[Christoph Hart]

Yes I'm chewing through macOS compilation at the moment and the second one also appears here. I'll commit a fix to those in a few minutes.

[d.healey]

@Christoph-Hart Thanks, just tried the latest and all compiled, but as soon as I tried to go to the script editor HISE crashed, going to try a debug build now and see if I can narrow it down. Unfortunately I'm going to be out all afternoon so won't get to play around with it much until this evening.

Script editor works in debug build - I'll experiment with different optimization levels.

I notcied the home/end keys are screwy in the new editor...

Update: It crashes with optimisation lvl 2 so I should be able to debug this when I get back.

Update 2: Crash is triggered by this function, I recall we had an issue here before
void mcl::HighlightComponent::paintHighlight(Graphics& g)

Line 68 for (auto sr : document.getSearchResults())

[Christoph Hart]

I've changed this line to something else, but I have no idea why it would crash or if the new way fixes it, so please have a go :)

[d.healey]

@Christoph-Hart Thanks, I'll try it this evening :)

[d.healey]

@Christoph-Hart said in Develop branch build status:

I've changed this line to something else, but I have no idea why it would crash or if the new way fixes it, so please have a go :)

Yep that seems to have fixed it (in debug at least, building release now).

End/Home keys are still messed up. Where should I hunt in the codebase to try and fix this myself?

[Christoph Hart]

HISE/hi_tools/mcl_editor/code_editor/TextEditor.cpp at 3c0afbf057a7323458a721ad1967fa4722289d1c · christophhart/HISE

The open source framework for sample based instruments - HISE/hi_tools/mcl_editor/code_editor/TextEditor.cpp at 3c0afbf057a7323458a721ad1967fa4722289d1c · christophhart/HISE

GitHub (github.com)

Try

#if JUCE_WINDOWS || JUCE_LINUX

instead.

[d.healey]

@Christoph-Hart Yep that did it, thanks!

[orange]

@LinuxVst said in Develop branch build status:

Mac OS Big Sur Intel: Updated
Compiled Successfully the Latest Develop ( 22-07-2021) under Big Sur 11.1
on a Mac Pro 4.1 Flashed to 5.1

i Used Xcode 12 and also installed Command_Line_Tools_for_Xcode_12 from
September 17 2020
Works! Under Intel

This is Xcode 12.0

For ARM & Intel universal binaries, minimum version must be Xcode 12.2. So this won't built ARM based plugins on Intel machines.

Building a Universal macOS Binary | Apple Developer Documentation

Create macOS apps and other executables that run natively on both Apple silicon and Intel-based Mac computers.

Apple Developer Documentation (developer.apple.com)

[d.healey]

Exporting projects with latest commit produces an error

HISE/hi_components/markdown_components/MarkdownComponents.cpp:516:17: error: ‘PopupIncludeEditor’ has not been declared

[DanH]

@d-healey Can confirm on OSX as well.

[d.healey]

There's a quirk when dragging to highlight text in the new editor. If you drag from right to left into the margin the cursor and highlight jumps to the end of the line.

[d.healey]

Shift+Tab behaviour is problematic

[d.healey]

Tab spacing is inconsistent. First tab on a line is 6 spaces, after that they're 5 spaces and the cursor doesn't indicate which column the text will be entered.

[d.healey]

Closing quotation mark isn't automatically added

[d.healey]

Console doesn't autoscroll to the end of the output

[d.healey]

Another highlighting glitch. I can't select the closing curly brace with the mouse when line breaks are disabled, re-enabling line breaks solves the issue.

[d.healey]

No horizontal scrollbar when line exceeds editor width and line breaks are disabled.

[Christoph Hart]

Tab spacing is inconsistent.

This might be a linux only problem - I remember fixing tab intention on macOS (I think the new line characters messed it up somehow). Can you reproduce this on windows? (I can't).

No horizontal scrollbar when line exceeds editor width and line breaks are disabled.

Yeah, I haven't added one yet, I'm too lazy.

The rest of the editor things should be fixed.

[MikeB]

A double click on an entry in the APICollection now does not add a new line in the editor with the selected entry.

Is this only the case for me?