sample loop crossfade
-
I have not been able to get a decent crossfade in a basic sample of a waveform. It always seems to "duck" at the loop point. Is there some sort of setting I'm missing for the crossfade?
-
The crossfade is linear. You can write your own (ie a log based crossfade) via https://github.com/christophhart/HISE/blob/2cf72ddab4374aa10fba46da539e9abb945d9470/hi_streaming/hi_streaming/StreamingSamplerSound.cpp#L481
-
There's no branch or pull request done for this? This seems surprising, as it is not terribly useful as it is. One of the reasons I'm diving into HISE is to not have to deal with C++!
-
@pnyboer I've been considering just opening up my branch since I've been moving everything back in to HISE for instrument building and I can just license the instruments themselves instead. I haven't looked too much into the licensing yet (but I was planning on using a commercial one) I've just been getting the code down, I'll take a look over the license and figure out if it'd cause any issues and then if people are interested I'll open it up. I've gutted a feature some people might want and added other things people might not want, so I'm not sure how much it'll help.
-
@LightandSound said in sample loop crossfade:
I'll take a look over the license and figure out if it'd cause any issues
You can publish your changes to the codebase under the GPL v3 license, however if the plan is to move it into the "official" codebase at some point I will need you to sign a CLA so that you grant me the right to sublicense your changes under the proprietary license - but that's fairly common practice in Dual-License Open Source projects.
(Scroll down to Contributing to HISE).
-
@Christoph-Hart Given that I completely removed the scale factor combo box and functionality (in favor of freeform resizing), I don't think you'd want to merge it to the official one ^^
-
@LightandSound I think a lot of people would like free form scaling, would it be possible to add it as an optional pre-processor flag? You don't have to merge everything either, you can just merge the parts you think will be relevant to most people.
Libre Wave - Freedom respecting instruments and effects
My Patreon - HISE tutorials
YouTube Channel - Public HISE tutorials -
@d-healey I noticed some people (such as yourself) had already added the combo box into their UI, often hidden within it by hiding the edges, this would break those for anyone that uses it (it would actually just straight up vanish).
I'll finish up a feature I think is pretty essential first (version checking from an external file) and then just make it public and do a quick tutorial on the changes somewhere, then if people want to merge changes and whatever I'll leave that to them?
-
It could also just be an actual property of the combobox in the interface designer that switches between the scale modes...
-
It could also just be an actual property of the combobox in the interface designer that switches between the scale modes...
I think this is the solution!
-
@Christoph-Hart I think that's a good decision for developers, not for users. When you have the ability to resize as you would any other application (corner or edge component) I dont see why you'd have it any other way!
-
Ah, totally misunderstood that - I think you were talking about the scaling of the popup menu that opens when you click on a ComboBox, not the resizing of the whole interface :)
Yes, in that case a script property doesn't make sense, but I'd rather add a Scripting API call (like
Content.setResizable(true)to enable this so people can test this directly in HISE and switch between this and the fixed size approach without using two different versions of HISE).When you have the ability to resize as you would any other application (corner or edge component) I dont see why you'd have it any other way!
Well, if your plugin is based on images (like most of the plugins still are, those fake wooden side panels are here to stay...) you might want to use an even scale factor because the image interpolation really looks bad at 95,4% - this is the only reason why I went for the fixed scale factor option. If you go all vector, then this doesn't apply of course.
-
@Christoph-Hart And this is why it's good to have people chiming in, I don't use images at all because I just hate the workflow!
-
@Christoph-Hart I like that option, a simple enable script that allows the option for people who want it, best of both worlds.
