Stop pruning default values from XML?

[dannytaurus]

@Christoph-Hart If I patch my build of HISE to stop pruning default values when serialising the XML, will it have knock-on effects?

// hi_scripting/scripting/api/ScriptingApiContent.h

834      Array<Identifier> deactivatedProperties;
835      Array<Identifier> priorityProperties;
836
837 -    bool removePropertyIfDefault = true;
837 +    // meatbeats: stop pruning default values to reduce git noise
838 +    bool removePropertyIfDefault = false;
839
840      CustomAutomationPtr currentAutomationData;

I get a small amount of git noise from the pruning of default values when I save. It's nothing horrible, but I'd like to remove it.

I'm personally fine with default values hanging around in the XML. But will it have side-effects?

[ustk]

@dannytaurus I reckon this has been added quite recently with the intention to remove the noise.
So if it always worked before I see no harm in disabling it.

[dannytaurus]

@ustk I'll try it and see how the XML comes out.

I was getting flip-flop noise in my XML after saving. On some saves, the default params were added, on other saves they were removed.

Something to do with CSS-LAF timing, according to Claude, because I'm setting some values in script that happen to be default values.

[David Healey]

@dannytaurus said in Stop pruning default values from XML?:

because I'm setting some values in script that happen to be default values.

Hmm this might be the source of an issue I was having too, I might try it.