Midi Overlay Panels in Compiled Plugin Crashing DAWS?

[mehmethand]

@Goodflow thank you so much.

[ILIAM]

@Goodflow said in Midi Overlay Panels in Compiled Plugin Crashing DAWS?:

@mehmethand

HISE/hi_components/midi_overlays/MidiOverlayFactory.h

Line 40:

class MidiOverlayFactory: public DeletedAtShutdown

gets changed to

class MidiOverlayFactory

This fixes the Midioverlay Disappearing?
@Matt_SF Matt, Take a look ️‍️

[Matt_SF]

@ILIAM @Goodflow awesome. Thanks!

[d.healey]

@ILIAM Is there a PR for this on github?

[Matt_SF]

@d-healey not yet. I though i'd make a PR tonight after verifying it

[d.healey]

@Matt_SF Noice, yeah good idea to check it doesn't break anything

[ustk]

Is there not a risk to let something pending in memory if it's not deleted?

[Matt_SF]

I haven't faced any weirdness while tesing it, but of course I can't test it on different systems, so that's a questions for @Christoph-Hart : should I make a PR ?

[ILIAM]

@Matt_SF Matt,Hey
So the Disappearing tile fixed?
did you tried on different DAWs ?

[Matt_SF]

@ILIAM Yes. I've tested it in Ableton, FL Studio, Reaper and Cubase

[ILIAM]

@Matt_SF said in Midi Overlay Panels in Compiled Plugin Crashing DAWS?:

t in Ableton, FL Studio, Reaper and Cubase

Yeah Man, Lets goo

[ILIAM]

@Matt_SF So this is what you changed?

MidiOverlayFactory.h

class MidiOverlayFactory: public DeletedAtShutdown
{
public:

Changed to (public DeletedAtShutdown >> Removed )

class MidiOverlayFactory
{
public:

Correct?

[ILIAM]

MidiOverlayFactory.h

class MidiOverlayFactory: public DeletedAtShutdown
{
public:

Changed to (public DeletedAtShutdown >> Removed )

class MidiOverlayFactory
{
public:

Great news, fam! Everything’s runnin’ smooth as butter — no issues at all with the MIDI Overlay Panel on Windows 10.

Tested the plugin in these DAWs so far: Ableton, Reaper, Cakewalk Sonar, and FL Studio — all solid!

big shoutout to @Goodflow for puttin’ in that work, squashin’ the bug, and droppin’ the fix!

[ILIAM]

@Matt_SF You tested on Windows too or Mac?

[Matt_SF]

@ILIAM On windows only - My plugin is not compiling on mac yet because of network compiling errors, on the latest commit.

[ILIAM]

Yo @Matt_SF, I’ma give it a shot. I’m runnin’ the 2024 HISE build right now — don’t think there’s been any major changes to the MIDI Overlay Panel lately, so if it’s solid on the older version, it should be all good on the new one too. I’ll report back with the Mac results in a few hours!

[ILIAM]

@Christoph-Hart @CatABC @Matt_SF @d.healey @ustk @ulrik
Ayy okay okay — major W on Mac! Just built HISE with the MIDI Overlay Panel mods, and everything’s runnin’ flawless. Tested on a Mac M2 (Apple Silicon) across Ableton, Logic, Reaper, and FL Studio — smooth like butter!

I even pushed it harder — multiple VST instances, duplicated MIDI tracks, saved, closed, and reopened projects on both Mac and Windows. Still no issues at all, and performance stayed clean and steady.

Big thanks to everyone who helped out! Can’t wait to see an official HISE fix from @Christoph-Hart