Please Increase parameter limit on Scriptnode custom nodes!

griffinboy

Thanks man. Honestly I'm still hoping it gets officially changed, because I like to share nodes on here. @Christoph-Hart said he is looking to improve certain areas of the c++ node side of hise, so hopefully it'll get sorted at somepoint!

I'll use your fix for now, so that I can continue development.
: )

Christoph Hart

There has to be a better solution to this, but I'm not sure what it is.

Nope, that's the way to go. The problem is the intersection between runtime code and compile time code which causes these monstrous switch statements.

@Orvillain if you sign the CLA, I'm happy to accept this beauty of a pull request.

Orvillain

@Christoph-Hart Will do!!

Allen

@Orvillain said in Please Increase parameter limit on Scriptnode custom nodes!:

and for the next guy, he might be a madman and want 128....

okay so the mad man is here
I just found out one of my node with about 100 parameters won't update the internal value and ready to increase this limit to 256

griffinboy

@Allen

I haven't had the chance to revist this yet

@Christoph-Hart Did we ever get an update for the compile time parameter callbacks? A bit higher in this thread, a solution was proposed to accommodate arbitrary parameter counts.

Allen

@Allen said in Please Increase parameter limit on Scriptnode custom nodes!:

I just found out one of my node with about 100 parameters won't update the internal value and ready to increase this limit to 256

Haven't tested all the params but just wanna comfirm so far it works in both script fx and compiled fx with max 256 params limit! :)

I found there's also a similar param number limit in the rnbo node so don't forget to change that one as well if you're using a rnbo node

Orvillain

Huh.... I'm running into this now, whereas I'm reasonably sure I wasn't before??? Unless this modification is only relevant for the networks themselves, and not the nodes???

SnexSource::SnexParameter::SnexParameter(SnexSource* n, NodeBase* parent, ValueTree dataTree) :
	Parameter(parent, getTreeInNetwork(parent, dataTree)),
	pIndex(dataTree.getParent().indexOf(dataTree)),
	snexSource(n),
	treeInCodeMetadata(dataTree)
{
	// Let's be very clear about this.
	jassert(!treeInCodeMetadata.isAChildOf(parent->getRootNetwork()->getValueTree()));

	auto& pHandler = n->getParameterHandler();

	switch (pIndex)
	{
	case 0:  p = parameter::inner<SnexSource::ParameterHandler, 0>(pHandler); break;
	case 1:  p = parameter::inner<SnexSource::ParameterHandler, 1>(pHandler); break;
	case 2:  p = parameter::inner<SnexSource::ParameterHandler, 2>(pHandler); break;
	case 3:  p = parameter::inner<SnexSource::ParameterHandler, 3>(pHandler); break;
	case 4:  p = parameter::inner<SnexSource::ParameterHandler, 4>(pHandler); break;
	case 5:  p = parameter::inner<SnexSource::ParameterHandler, 5>(pHandler); break;
	case 6:  p = parameter::inner<SnexSource::ParameterHandler, 6>(pHandler); break;
	case 7:  p = parameter::inner<SnexSource::ParameterHandler, 7>(pHandler); break;
	case 8:  p = parameter::inner<SnexSource::ParameterHandler, 8>(pHandler); break;
	case 9:  p = parameter::inner<SnexSource::ParameterHandler, 9>(pHandler); break;
	case 10: p = parameter::inner<SnexSource::ParameterHandler, 10>(pHandler); break;
	case 11: p = parameter::inner<SnexSource::ParameterHandler, 11>(pHandler); break;
	case 12: p = parameter::inner<SnexSource::ParameterHandler, 12>(pHandler); break;
	case 13: p = parameter::inner<SnexSource::ParameterHandler, 13>(pHandler); break;
	case 14: p = parameter::inner<SnexSource::ParameterHandler, 14>(pHandler); break;
	case 15: p = parameter::inner<SnexSource::ParameterHandler, 15>(pHandler); break;
	case 16: p = parameter::inner<SnexSource::ParameterHandler, 16>(pHandler); break;
	case 17: p = parameter::inner<SnexSource::ParameterHandler, 17>(pHandler); break;
	case 18: p = parameter::inner<SnexSource::ParameterHandler, 18>(pHandler); break;
	case 19: p = parameter::inner<SnexSource::ParameterHandler, 19>(pHandler); break;
	case 20: p = parameter::inner<SnexSource::ParameterHandler, 20>(pHandler); break;
	case 21: p = parameter::inner<SnexSource::ParameterHandler, 21>(pHandler); break;
	case 22: p = parameter::inner<SnexSource::ParameterHandler, 22>(pHandler); break;
	case 23: p = parameter::inner<SnexSource::ParameterHandler, 23>(pHandler); break;
	case 24: p = parameter::inner<SnexSource::ParameterHandler, 24>(pHandler); break;
	case 25: p = parameter::inner<SnexSource::ParameterHandler, 25>(pHandler); break;
	case 26: p = parameter::inner<SnexSource::ParameterHandler, 26>(pHandler); break;
	case 27: p = parameter::inner<SnexSource::ParameterHandler, 27>(pHandler); break;
	case 28: p = parameter::inner<SnexSource::ParameterHandler, 28>(pHandler); break;
	case 29: p = parameter::inner<SnexSource::ParameterHandler, 29>(pHandler); break;
	case 30: p = parameter::inner<SnexSource::ParameterHandler, 30>(pHandler); break;
	case 31: p = parameter::inner<SnexSource::ParameterHandler, 31>(pHandler); break;
	case 32: p = parameter::inner<SnexSource::ParameterHandler, 32>(pHandler); break;
	case 33: p = parameter::inner<SnexSource::ParameterHandler, 33>(pHandler); break;
	case 34: p = parameter::inner<SnexSource::ParameterHandler, 34>(pHandler); break;
	case 35: p = parameter::inner<SnexSource::ParameterHandler, 35>(pHandler); break;
	case 36: p = parameter::inner<SnexSource::ParameterHandler, 36>(pHandler); break;
	case 37: p = parameter::inner<SnexSource::ParameterHandler, 37>(pHandler); break;
	case 38: p = parameter::inner<SnexSource::ParameterHandler, 38>(pHandler); break;
	case 39: p = parameter::inner<SnexSource::ParameterHandler, 39>(pHandler); break;
	case 40: p = parameter::inner<SnexSource::ParameterHandler, 40>(pHandler); break;
	case 41: p = parameter::inner<SnexSource::ParameterHandler, 41>(pHandler); break;
	case 42: p = parameter::inner<SnexSource::ParameterHandler, 42>(pHandler); break;
	case 43: p = parameter::inner<SnexSource::ParameterHandler, 43>(pHandler); break;
	case 44: p = parameter::inner<SnexSource::ParameterHandler, 44>(pHandler); break;
	case 45: p = parameter::inner<SnexSource::ParameterHandler, 45>(pHandler); break;
	case 46: p = parameter::inner<SnexSource::ParameterHandler, 46>(pHandler); break;
	case 47: p = parameter::inner<SnexSource::ParameterHandler, 47>(pHandler); break;
	case 48: p = parameter::inner<SnexSource::ParameterHandler, 48>(pHandler); break;
	case 49: p = parameter::inner<SnexSource::ParameterHandler, 49>(pHandler); break;
	case 50: p = parameter::inner<SnexSource::ParameterHandler, 50>(pHandler); break;
	case 51: p = parameter::inner<SnexSource::ParameterHandler, 51>(pHandler); break;
	case 52: p = parameter::inner<SnexSource::ParameterHandler, 52>(pHandler); break;
	case 53: p = parameter::inner<SnexSource::ParameterHandler, 53>(pHandler); break;
	case 54: p = parameter::inner<SnexSource::ParameterHandler, 54>(pHandler); break;
	case 55: p = parameter::inner<SnexSource::ParameterHandler, 55>(pHandler); break;
	case 56: p = parameter::inner<SnexSource::ParameterHandler, 56>(pHandler); break;
	case 57: p = parameter::inner<SnexSource::ParameterHandler, 57>(pHandler); break;
	case 58: p = parameter::inner<SnexSource::ParameterHandler, 58>(pHandler); break;
	case 59: p = parameter::inner<SnexSource::ParameterHandler, 59>(pHandler); break;
	case 60: p = parameter::inner<SnexSource::ParameterHandler, 60>(pHandler); break;
	case 61: p = parameter::inner<SnexSource::ParameterHandler, 61>(pHandler); break;
	case 62: p = parameter::inner<SnexSource::ParameterHandler, 62>(pHandler); break;
	case 63: p = parameter::inner<SnexSource::ParameterHandler, 63>(pHandler); break;
	default:
		jassertfalse;
	}

	auto ndb = new parameter::dynamic_base(p);
	
	setDynamicParameter(ndb);

	auto ids = RangeHelpers::getRangeIds();
	ids.add(PropertyIds::ID);

	syncer.setPropertiesToSync(dataTree, data, ids, parent->getUndoManager());

	parentValueUpdater.setCallback(data, { PropertyIds::Value }, valuetree::AsyncMode::Synchronously, BIND_MEMBER_FUNCTION_2(SnexSource::SnexParameter::sendValueChangeToParentListeners));
}

Orvillain

@Allen said in Please Increase parameter limit on Scriptnode custom nodes!:

I just found out one of my node with about 100 parameters won't update the internal value and ready to increase this limit to 256

So it isn't an issue of there not being the ability to make a node super tall or anything. Actually, I simply don't know why HISE is not showing any more than 18 parameters on a custom c++ node. Quite annoying, coz I need another gajillion!

Well... at least another 16!

I don't want to use slider packs. I hate them.

Christoph Hart

@Orvillain have you tried the new pagination feature? That allows you to subgroup parameters into pages. It looks like this is just an UI problem and having a node with 100 knobs will look very ugly anyways.

Orvillain

@Christoph-Hart said in Please Increase parameter limit on Scriptnode custom nodes!:

@Orvillain have you tried the new pagination feature? That allows you to subgroup parameters into pages. It looks like this is just an UI problem and having a node with 100 knobs will look very ugly anyways.

I haven't actually no. Maybe it will fix this issue. I'll check.

Orvillain

@Christoph-Hart said in Please Increase parameter limit on Scriptnode custom nodes!:

@Orvillain have you tried the new pagination feature? That allows you to subgroup parameters into pages. It looks like this is just an UI problem and having a node with 100 knobs will look very ugly anyways.

Ahhh yeah, this seems like it will work. I did notice when you create a page, any hidden parameters end up going to it, rather than showing up on the unassigned page. But I can work with that.

Orvillain

@Christoph-Hart

Seems to be a limit on the number of pages? If I move a control to an 8th page, I don't see it.

Christoph Hart

@Orvillain haha one more lane, bro! I haven't tested 8 pages but I can imagine that it runs against the same node dimension limitation as the parameters before.

Please Increase parameter limit on Scriptnode custom nodes!

20

2.0k

12.8k

110.6k