About volume bump
-
When I rewrote the modulation system I added a "smooth bypass" function that will send a all notes-off message, waits till the voices have faded out and then executes the operations - this removes the clicks when switching user presets, enabling FX, changing samplemaps etc..
The problem is that for FX plugins there is no concept of a all notes off message so the input signal will continue to get processed. Shouldn't be not too hard to fix and I'll include this in the next update along with some other fixes.
-
Shouldn't be not too hard to fix
Your logic is flawed :p
Does the smooth bypass apply to envelopes too? If not could it also be implemented?
-
Thank god I am not working in a field where logic is important. Oh, wait...
-
@Christoph-Hart I see this commit today's update;
- fixed clicks when switching presets on compiled FX plugins
Has the volume bump issue been solved for the fx plugins?
We're seeing this issue especially on convolution reverb, shape fx and dynamics fx. It would be good to fix it, because waiting for it for a long time actually...
-
Yes I tried it with a simple reverb example, but if you have a use case where it‘s still there, send it to me - this commit was supposed to fix it.
-
@Christoph-Hart Hi
I am using the latest (Hise - 02.05.2019 - Developer Branch) version, There are 2 issues-
Project One : You can hear the clicky volume bump while first initialization on Hise, also even the compiled plugin too. Make a project in a daw with "Clicked" preset, save and close. Then if you reopen the daw project, it gives this volume bump on first initialization only. (It does that when noise-sine generator and shape fx is active)
-
Project two : It gives "IR is not embedded correctly" error on compiled plugin in Hise 2.1.0, but not in Hise 2.0. But even in Hise 2.0, when you swap between the IR samples, it makes a huge volume bump issue while IR sample transitions.
-
-
Alright, I'll take a look tomorrow.
-
@Christoph-Hart Did you managed to fix?
-
OK, I checked the projects:
- This was caused by the simple gain smoothing. I deactivated it on initialisation so now it should be fine.
- The "IR is not embedded" has nothing to do with the version, but that you didn't click on the other ones before export. I've added a safe check that prevents calling the method without loading them into the pool in order to prevent this.
But I can't fix the "Volume Bump", because there is nothing to fix (or it is exponentially hacky for this use case). If you swap an IR, it fades out the old one, then recalculates the impulse and fades in the new one and during that time you hear just the unprocessed signal (or silence, if it's 100% wet). This removes clicks, but is as good as it will get.
-
@Christoph-Hart Thank you!
-
Does Simple gain smoothing on initialization, solve the preset change volume bump issue? Because when you change presets it does that bump too (not only first initialization), especially in Shape FX and Scrpit FX noise generator is activated in the next preset.
-
I understand the IR volume bump (However in Hise 1.6, there was no bump when you swap samples also) I prefer silence when swapping the samples.
-
-
Now the volume bump issue has been closed by @Christoph-Hart with the latest update, you are great man ;)
-
That's great. Now I can develop a guitar amp simulation :)
