Bug with polyphonic filter

[d.healey]

The polyphonic filter is causing me problems. It's holding on to sampler voices. The video will demonstrate more clearly, basically I add a sampler, load in some samples, add a polyphonic filter, if I play a note and release it the voice count goes to 1 and it stays there, then if I play another note it goes to 2, etc. It keeps climbing and the voices are never released. Major problem with my multi-mic samples with 9 voices per key! :)

https://youtu.be/qSp0BdgTq8s

[Christoph Hart]

Ah yes, I've already fixed that on the feature/full-dynamics branch (actually I wanted to commit this change as hot fix directly to the develop branch, but accidentally committed the files as they are).

Luckily the fix is rather trivial, so you can do it yourself:

In hi_modules/effects/fx/Filters.h

line 1364: bool hasTail() const override { return true; };

to:

line 1364: bool hasTail() const override { return false; };

[d.healey]

@christoph-hart Those line numbers don't seem to be correct

[Christoph Hart]

Oops, I was looking on the master branch. Line 181 it is...

[d.healey]

@christoph-hart That worked! :)