addPitchFade() bug?

[ulrik]

@d-healey it doesn't help I'm afraid, and yes the id should be different for each note and the pitchFade function will get the right id before it's changed

[d.healey]

@ulrik i don't hear anything when pressing play

[ulrik]

@d-healey you have to hold down some keys on your keyboard at the same time

[d.healey]

@ulrik It works here. If I turn the pitch knob to max, hold two notes, and press play both notes are pitched up 12 semi-tones.

I'm working on a guitar strummer at the moment. I hadn't thought of using delayed notes, it's a clever idea. I'm doing it using the synth timer.

[ulrik]

@d-healey can you try with some delay set as well?

[d.healey]

@ulrik I have the delay set to 7092

[ulrik]

@d-healey said in addPitchFade() bug?:

@ulrik I have the delay set to 7092

and all pressed notes were affected? Wow, why does it not work for me, strange

[ulrik]

@d-healey which commit are you on?
I'm on latest develop commit

[d.healey]

@ulrik Yeah

[ulrik]

@d-healey said in addPitchFade() bug?:

@ulrik Yeah

same?

[Lindon]

@ulrik not working -in the same way yours isnt - here - so add the delay - set a pitch fade, hold down two notes, press play - only the first note is re-pitched...

[ulrik]

@Lindon Thank you for confirming! Which commit are you on?

[Lindon]

@ulrik oh its quite old - I await teh filter display fix before I can move to anything recent.

[Lindon]

@ulrik ok so the culprit is this:

id = Synth.addNoteOn(1, n, 60, d*count);

the pitchfade apparently doesnt happen until the note is playing...and as you are delaying the onset of the note - its not playing so its not happening..

if you replace that line with this:

id = Synth.addNoteOn(1, n, 60,0);

it works as it should

[ulrik]

@Lindon unfortunately yes, it would be great to assign the pitch fade to the event before it happens and it will remember that when fired
@Christoph-Hart would it be possible?

[ulrik]

@ulrik in other words

we have the opportunity to set NoteOn and NoteOff delayed

local id = Synth.addNoteOn(1, n, 60, amount of delay in samples);
Synth.noteOffDelayedByEventId(id, amount of delay in samples);

Could we have
Synth.addDelayedPitchFade(id, fade time, pitch, fine pitch, amount of delay in samples)

or is it possible to achieve this, if so, how?

[d.healey]

@ulrik said in addPitchFade() bug?:

or is it possible to achieve this, if so, how?

Why not use a timer?

[ulrik]

@d-healey yes that is possible but I think it would be more accurate to work with sample delays as in above examples

[ulrik]

@d-healey I still don't understand how you could make my example work with the delayed NoteOns, can you explain?

[d.healey]

@ulrik I didn't change anything, other than the pitch knob's value. I'll make a video and you can tell me if I'm doing something wrong or misunderstanding.