addPitchFade() bug?

ulrik

@d-healey which commit are you on?
I'm on latest develop commit

d.healey

@ulrik Yeah

ulrik

@d-healey said in addPitchFade() bug?:

@ulrik Yeah

same?

Lindon

@ulrik not working -in the same way yours isnt - here - so add the delay - set a pitch fade, hold down two notes, press play - only the first note is re-pitched...

ulrik

@Lindon Thank you for confirming! Which commit are you on?

Lindon

@ulrik oh its quite old - I await teh filter display fix before I can move to anything recent.

Lindon

@ulrik ok so the culprit is this:

id = Synth.addNoteOn(1, n, 60, d*count);

the pitchfade apparently doesnt happen until the note is playing...and as you are delaying the onset of the note - its not playing so its not happening..

if you replace that line with this:

id = Synth.addNoteOn(1, n, 60,0);

it works as it should

ulrik

@Lindon unfortunately yes, it would be great to assign the pitch fade to the event before it happens and it will remember that when fired
@Christoph-Hart would it be possible?

ulrik

@ulrik in other words

we have the opportunity to set NoteOn and NoteOff delayed

local id = Synth.addNoteOn(1, n, 60, amount of delay in samples);
Synth.noteOffDelayedByEventId(id, amount of delay in samples);

Could we have
Synth.addDelayedPitchFade(id, fade time, pitch, fine pitch, amount of delay in samples)

or is it possible to achieve this, if so, how?

d.healey

@ulrik said in addPitchFade() bug?:

or is it possible to achieve this, if so, how?

Why not use a timer?

ulrik

@d-healey yes that is possible but I think it would be more accurate to work with sample delays as in above examples

ulrik

@d-healey I still don't understand how you could make my example work with the delayed NoteOns, can you explain?

d.healey

@ulrik I didn't change anything, other than the pitch knob's value. I'll make a video and you can tell me if I'm doing something wrong or misunderstanding.

ulrik

@d-healey and you had the DelayKnb set to a value as well?

d.healey

@ulrik Exactly as your snippet

d.healey

Ah I just tested again, you're right, it's only shifting the first note.

ulrik

@d-healey thank you for checking again!

ulrik

@d-healey as you said, I used a timer for the pitch fade part of the strumming

STRUMMING WITH PITCHFADE

HiseSnippet 1495.3oc2X0saaTDEd13rUwtzJJpB0KWEwEaprRsKkBRUP2DGmJqV2XkMMPEBUlr6w1CY8Lalc1zXPUpWxU7xvcbKu.7nz2.3Lytd85TmhqEEQYUTTlYN+7c9cNS5IEAPRhPRrpdv3XfX8A19i4pgsFRYbRmcHVWwNDhnicfSAthr83XZRBDRrrp7.MIVUWkX9d082lFQ4AvzsHjCEr.3QrQL0zc648PVTztzP3.1nRTeGuNABdKQjHEgSE6FjXZvwzAvioZxVwlXco1gLkP5qnJHgXs51hvw9CEOmmQ+grD1QQfdQShOJnrs2UDEpQrdWRqgrnvdSL6DBwxt2TmPkLmv0s6xBYE6O0Y7glCblxQY+g0JyBuJy.ulkgWiRvaNPxpDjVMCRWy1OPxhUSOQimKa2gq.YeJ51KCkLZIq7KqZ2RfTvUaNhdLrqDWTvg6cazntC9qMtWsZnqOQ4bJU5riNb+P9QNeoyDdG.pVhQwBNtvc8IDrNx2T15wTAC0Q02DqkIRyN9IgANGCiSBQ+Dx229c2q1jkaJgDPdJ31TCQMgrvjbZpcqaUMVmWl.mjBXZWMFOhwAm9o7.ESvcD7d349vIaq3ZzHEQtASfRcDyQovF09oZUY8cbyWUEWVEUxlAQ.U5hZsZ0HQ.MxID06DCWaTGpYHif9BoiK2gwKrCTPFIkyafHkqP9KrKFODNau9tbC+4TwzpvT7sIML7wBErG2sYcGtNFU2I7lFwjwQFYbMM86afEDt8315RzNgtrv5NMan+xnVaPwoICwCx1H9HcombyDEUpL+oaWJJPIkO.bayGfNRsQ1EKTY9.FjCS1ESroihifD2B6HB3CTCuY3F0ctciI5rwFFk7hZ3OunHyJWknIlK9.IfkIlM26ne.BTZmYsBjAY3pEMJ5HrMf6jvpqIjYb4nCC84nwoc2ENthTrB2P8YxMKE7p6XbP0ppFxRPmgHNyWfa9BMXtfb3hrp02Piy7bqBjNm7NTXkRKyCsFCoKVKis31jMfKjfI.5pjXpHhqB2rI1MgRDLZA73zQGogpFq0bNuz62OS7kpjFIvBoEUH43NRenVNm63b2zbNYRgF2H4xUYZBwtYy1hz9haQVtCdPVfnDgBdGNSsWLvun95j7nG1NsRNpv+RYZld07loampTBNgEpu2aZTiXPc46wHWjD7iXgfzHgZ1S5ObN9W627VD9upc4zzyig07HOoyNTEUe8PtoglaLHULsmzZG3T7t1rKKphPI4XLe1X64YtDq0VLq+rBs5AdimBgm58bVnZXwFu7Pug.avvR2s+UdrjthQn1nRjSqUTvY3wWxt2i15oZuXAVpsH9wRH46KiDBYVjfmddjzwKIsee1YZ44jj03hLhNUh+7u6knfXe1OBkGhYDKLLB5IRX5L5oT+qdKF5OWTbp9d4Iu0VPY3RbeafK4FEluMZ9XQvqOQANKiHLMhplc.G8Tc4GnkX4oJzSNvQMMtLB9GapmEEhWKyCOeLtxbvHVw7t.i4yJdE6186iWeMEfqZu627tYvvxp+pYp+x193sola+LJ+iMqc9Z5ofyC.NH0Nulug41+iEct83Edt88BTn5O.mlHIVjLif8gQrCvhnjxa9jDbxT3j80Qyx62RPky8nWc+cQibt73SUoRSZwVizyKMSZPk2z6GZtjueX0+y89g2CJ1m4INUmfQeltOca9oPDdylAieDdaPeZZjZxtylK2UvEwCEbVP4.89fRxFL.jkw9bMnsTJblso6bcu8Abz+xIseh2ivjMpD8SvR5KZ9V+bu4FutgcFbczEfNu+1jtx+uaRuuHUw3CvWTIMW.iSY6i8FC.T6bNDom60ZEc+sr0MzqyZNxCMK9S7K+vl50V4G1bxg+qniQz.o3YAYStpySWyrCZ2by+Qlp1c0qcZ95yKiikvdVPvrh50X71KKie5xx3cVVF+rkkw6trL94KKieweOi5Kg1JUIFkUZRHc60171BKq1bJlkapHH+Ew5WhH.

Lindon

@ulrik said in addPitchFade() bug?:

@ulrik in other words

we have the opportunity to set NoteOn and NoteOff delayed
local id = Synth.addNoteOn(1, n, 60, amount of delay in samples);
Synth.noteOffDelayedByEventId(id, amount of delay in samples);

Could we have
Synth.addDelayedPitchFade(id, fade time, pitch, fine pitch, amount of delay in samples)
or is it possible to achieve this, if so, how?

To be honest I'd like this too... in my case Im already running a timer - its a custom arp - so it would be MUCH more convenient to not have to fiddle with the timer to get this effect - or add a second timer... ugly...

ulrik

@Lindon said in addPitchFade() bug?:

@ulrik said in addPitchFade() bug?:
@ulrik in other words

we have the opportunity to set NoteOn and NoteOff delayed
local id = Synth.addNoteOn(1, n, 60, amount of delay in samples);
Synth.noteOffDelayedByEventId(id, amount of delay in samples);

Could we have
Synth.addDelayedPitchFade(id, fade time, pitch, fine pitch, amount of delay in samples)
or is it possible to achieve this, if so, how?
To be honest I'd like this too... in my case Im already running a timer - its a custom arp - so it would be MUCH more convenient to not have to fiddle with the timer to get this effect - or add a second timer... ugly...

Yes, I'm building a custom arp as well, and having problems with the combination of strumming and pitch fade together.

I have tried using timers and it works but not very good in my case, (might be bad coding...)
Anyway I tried using a midi player with some good results (haven't tried it in real situations yet

Here's a test, implementing in it my arp will make it more reliable when the seq is already is set, here I just test it with pressed keys but I think it's promising.

HiseSnippet 2495.3oc6Z0saabbEdojV6PZ2Fm.azd4Vg1hU1BqDkUjkQfgo92BQRj1TVI0AoIq2cVxwZ4Lr6NqrUJLZtL20Wg9JzmfFfdWupn8EH8MvuAsmyL6OyRRIQqZ231JAAANm4bNy24m4blYnZEw8Hww7HiJU2+39DiJW0r8wLQ2055RYFautQkOzbkn9VO2ZWpOsen6wjHiUOtuabLw2nRkI2B4qR0oLj+7p6upanKyiTPxv3.N0irCsGUTPsUiOgFFtoqOYeZOMtWrw1db1Z7PdBfoIMm2nuq2gtcH64hrMgoQkKsgOUviZKbEjXiJSsJ2+31c4Omo3+.ZL8ogDbPci1fhTj2jG5iHF+rwZcog9sxr8XCiJlsJ7DSp7DW2DM4b5EdjqImvpPBc+QkIJCuIKAu55vadM3MBHMgFjtbVvQBIUT.gRUycaMbLYsjnHBSzl7aRHkhEu59oSseD3U0ouCm2eClKfLe8PGp7mBr1tOQehWc+JSN1lY8S0LMPKZSZHAM4JYC.tQyCB2q6JbMp7UlKsrCa+k9jkW6E68q1xwY2GtwSd1JNNNeliyJNsb5QeT682dgm.TbNzw4Y24YGDbWm8exJezws3avZt0gGDt4JOnoy5rlNqzJ3t6rtCL2CcbN5VINNF3hVjhUASJaS6vbEIQ.sKsWRuUcA3p4A1i2iByK25j4uZrNgMLYk2E7TQBceqxkWxqtOoWedAgecCCsbfoT4.efYauHZeQwLnm5JlayDjn.WHbqmJn30Xh+VUy03.GLgSO2CIaFACxkvdo4meVK3Oy7w0pEQ5XcH43XeHVZcOqO+K93LRGQB4dTAkDCz2f0gxHNdQDHA.Ca6PiE1nBf8uwBqz7RfSY8DmNDQQtq8zoSOcg.sEQI8.1yfIHvZbvcvfA1SKmE4Vw7dbAYGBqin6IJQAKEh0hJ75hEcNQox4nPnrhTmnLYLTVjlrvi2wMVf33TEUmQo+Xt4pQYgf20JHg4InblULQj54lo1usVUHN3FZQNBzQbZLpZspyMWUHcPXQCrhQ2EjH1wJtKOIz2pC2JHh2yJj+bKA2pKsSWKFrf0plEqcPYw.Hno.djkMyhxxyDloVUXcSWXOdBS.qatnTlO4EMCrYn3oLEmFOkQNzrOvMLgXOi0MUxiblyLmMTJEjaCk8e.V1NxVSu7ffwfW3WNXRDAtowF9H5capvmZBndNiQBsqqQCYB1p+TPK5rdfJw+X6RaBJrI1LZLiYBwB2d8skdfbzDDT.G3yR7DDnDTM2.HRQbXHkpnxKi0sxbI.pZCjgBpaxidXBTzgDsJ3khs26.njygOt+mWr0PKt7E2bwYx.qJyxoeRbWv2IoVhjB2uDSUzB1gYaHKPh95CvIEX1ClSLyMySkTJQlElVi.sVr7r8zSOqEHHYVq.2vXBBgLVT4A165BljGgFdV15sz.7LyZUG9UWcAgfYllUIqqordcVviBYiELeYMUMyrUD2OtLTMcVqEm051yZs.p9Z2dNXT84vAycab3x3mjzVBGVeI7iRh0W.IbaIqJxKrHRYII2J5KtLrkenpDbVg0h0ah3g1dYEal05Hz3k0OxIh9V6oEjWH.eaQXS1GBaGZqjAMSX8N6BsxzX0JulaXHdzA6QfJrJ2.ntISuzFDNCYpBmogAbQ01KnpSAU5r+YYLPiWIRPCndT2PHkRUvJexNLdDYCLLZi4PYY544cxD6rkUNa4M6wYIOY7LqNxxqPn1BoUtNaeBAxXUPBAcdaF8MAvb37RFFrwv.7oXTx4I3ert28x8hRIpVU0H102Oe00EV5a112F1Nj0PSaQm0ZTPdVq4k1qzUVM0FesVp4OCE+xZoJOW2u8rhWhgpWVav8SPUZUpYdtRDoG+HxI44k0DzURZReXV26AlFw3nmIaOLSpY8MvHivIBKeFbyw6L3dpcwZLxYaynhl8IoiGwozS25i2TJEU.qB4AR+woGHscHEZ+ZPgycdYSYEdCIfyOOa0+XCiwP3qZVTuX.MXb8wRCWwLOLOnBLFKETyL+lokk+aRNY4WMQH3Lo7en4f6eGBGFFOda4cafSom5bAGdeRDVsAnsN4H3Vypi7W0bcR7gBdeo2OsvKfxyz++hhE7m23X8AOm5Cd2LBM9pFcIvQB0tex1M5Q88CIs3wTLcLelu8O2nmagh+1+diXAoea5WW5dlwIAAzWfdRqXUSeLGZLfdonewx7cO80G+Znz3NiDkmfIZ7KafsDAusIzBtDvuxXkzUrvVQu13dz.UCc1eWISy9jhTvOYgASHLHFSCQK4uXU99u9eK+eie+qi+uwuqQFvmxrWrQOtOdIbSIlzMhK+5rCTKYROn7MGLfwX3OjwrdZ9vMjZ0BUo7JnV3BXLhKoeMyc49Ig36.n+tQ3ikkNAZu5WTGuLNC7CGW5UVl3zdqqS7wjJdqqQVKeLg6GnRnGMdmXD3Eeyp2x3M8o49QlaDDP7DEfcJyM+rS8c3diCk2uz6ktUDOouDIWWQfDSiIQVR50eS7hoyO1uXp5c71bWcMtlaTDkDsMdQcsE+OkG2GZlGynwbFWBkU5g2XWGKoytNQjvx.yeXq+we49oSztOb3yRusEh91D.p9RUFeZuln438ltk2NoEbO8nXk26s0i89ez8m+.TN4Lem5pY3sMEa5uACuAEPQUOYcRfaRnHmpNf2ERZ52kynd5osOhHhnc5PJ8Zpiz1VQHJ8j1WuwiHgD2XhdWqcf625FsqrcxI6VN2ukckJiYn6mZpfqk7cEempiv6ofcMyrqzJA7MxGZkaN0Oaz93Xx9tR3nG8NBNja4ulg0IdzmRBKGXfxfoqoTGpuHfeg4BK5T9miZB+I3V3Gu6ZK530sowarH5ajdkS9+88JOMW2UMUMQvDq2wOQDzqW1V6cDndCETuh4m5dDQdniz8p33.dTOqsHLRzv6UKeBj+53dBj9i8IPZ5I.HrejKKtOOlTWWyCL2BkqCfYB0GlTItPyaSv7z36ZMxHtfNwVtrRJCFWRS6R0Nxy2ee0AmTGRoYrGXrC9E40JILl7o30EpqKXA4EzI+.2HeHtTpi1fG0YpwqzzYbhlKcwIZdG6BRWTz+zizvVOq+qIR+SLgxAKnd7Xqe3i2OhmHnrN65BGNFebm8R50Fp85QR+FDwaPUYB7VepwyiiQ3zlv7kC9mvOoSVGGWIcx5YSdN6yrvE8YtnOyE8YtnOyE8YtnOyX0m4+UVidtdQ7uzS8cCJejQIEv2xj+aEV0bWbrU8g+l.6AkI+ROuxpZHAW37J3sOuBt34UvO57J3RmWAuy4UvkOaAwtXqjH38T6Egt4s1P8XTUx+OlsxjF+KPAX+jC

addPitchFade() bug?

26

1.8k

12.0k

104.5k