Zipper noise with group XF
-
Can't replicate it here, but it might have something to do with the other modulation issue that was specific to Linux.
I've uploaded a simple test project with two files, one with static 1.0 and one with static -1.0. If you crossfade them, you should see the pure modulation values in the waveform that you export using our most favorite One second dump tool.
https://www.dropbox.com/s/5afys6vpiud33n7/ZipperTest.zip?dl=0
As with all test sounds, make sure your sound system is silent, they produce nasty clicks.
This is how it looks on my system.
In your case, there should be some nasty zippery going on. If you can replicate it like this and send me the .wav file, we're almost there :)
And you can try if adding a simple envelope to the crossfading chain fixes it (internally it works differently if there are envelopes, so maybe it's just that code path that's causing issues).
-
@christoph-hart Mine doesn't look anything like yours so I assume I'm doing something wrong.
https://www.dropbox.com/s/thyunb6u53pv6ai/HISE_One_Second_Dump.wav?dl=0
-
I pressed just one note, hold it and move the "Default Value" knob (which is the same as moving the modwheel). Did you press multiple notes?
-
@christoph-hart Yes. But this time I only pressed a single key once and moved the mod-wheel - https://www.dropbox.com/s/thyunb6u53pv6ai/HISE_One_Second_Dump.wav?dl=0
-
Oh, maybe the sample looping is not enabled in my example patch?
-
@christoph-hart aha that would make sense, I will enable it
-
Yup that was it. I also noticed two strange things. When I click the enable loop button the loop area doesn't display in the waveform view and the loop button icon doesn't change (although it does turn looping on and off). I tried this in another project with some looped samples and the result was the same. In fact none of the button icons in the wave editor change when the controls are toggled.
The other strange thing is there is no playback cursor over the waveform now in the sample editor.
Libre Wave - Freedom respecting instruments and effects
My Patreon - HISE tutorials
YouTube Channel - Public HISE tutorials -
@d-healey It's hard to tell but it sounds like the issue is there with your demo. I'll see if my brother can test it on Windows for me later today.
Here is the one second audio file - http://www.filedropper.com/hiseoneseconddump
The issue with the wave editor buttons is still present in the latest version.
-
Hmm, no the dump looks normal - the curves do not have any weird zipper noises in them.
-
@christoph-hart Tested on Windows now, the issue is the same. Here is an example project that has the issue - https://www.dropbox.com/s/3gu0fpmkzj5ezth/zipper.zip?dl=0
I found the issue is not present when I use only two dynamic layers/groups
-
Nice, that might explain it! I haven‘t tested something crazy like more than two dynamic levels :)
-
Alright, I think what you heard looks like this:
Shouldn't be too hard to fix now that I can reproduce it, I'll keep you posted with my newest findings as Sherlock McCrossfade...
-
@christoph-hart Looks funky, might have some practical uses :p
-
Nothing beats a Square LFO with 512 sample period length...
-
Alright, I've pushed a fix to develop. Please confirm that the problem / "super sound FX" is gone.
-
@christoph-hart said in Zipper noise with group XF:
Alright, I've pushed a fix to develop. Please confirm that the problem / "super sound FX" is gone.
Wonderful! The problem seems to be resolved now :) thank you!
-
Nice. Anything left? I‘d like to merge dev into master in the next week (it is derailed for quite some time now).
-
@christoph-hart Only thing I can think of is the buttons in the wave editor don't change state when you click them, but it's just cosmetic, they seem to still perform their function.
-
Ah yes that is annoying...
-
Fill note gaps appears broken
