Midi note 60 (hostIsPlaying) FX_Only ? Why ?

[Christoph Hart]

Could get rid of that but would love to know why this is ?

I think that is a super old code snippet that causes the LFO to restart when the playback starts.

Given the new synchronisation options with the TransportHandler class I actually don't see why it needs to be there anymore.

[lalalandsynth]

@d-healey @ulrik Our CC Output is working for Reaper and Live, havent tested midi output from anything else like the arp etc.

I am at work at the moment but I can put up a snippet later if that will help.
EDIT: our plugin uses a timer to make the CC data, so that is definitely different than what you are trying to achieve.

[ulrik]

@lalalandsynth said in Midi note 60 (hostIsPlaying) FX_Only ? Why ?:

@d-healey @ulrik Our CC Output is working for Reaper and Live, havent tested midi output from anything else like the arp etc.

I am at work at the moment but I can put up a snippet later if that will help.
EDIT: our plugin uses a timer to make the CC data, so that is definitely different than what you are trying to achieve.

Yes but still, you manage to get the CC out from the plugin, so I guess it's the same procedure with getting notes out so I would love a small snippet if you're able to :)

[lalalandsynth]

@ulrik Using a timer would not be advisable for midi, its not very precise and quite jittery. But I will make a snippet :)

[Christoph Hart]

its not very precise and quite jittery.

The timer with the onTimer callback is sample accurate (you can get the exact sample position of the timer event with Message.getTimestamp() inside the callback).

The other timers Engine.createTimerObject() etc. are UI timers so they are jittery by design.

[ulrik]

@lalalandsynth said in Midi note 60 (hostIsPlaying) FX_Only ? Why ?:

Could get rid of that but would love to know why this is ?!

How did you do to remove midi note 60, do you have a solid solution?
I would really appreciate it.

[lalalandsynth]

@ulrik It can be removed from the code and then just build Hise again, but it would be better if it were fixed in master so we dont have to maintain our own fork.

Having said that, @jonhallur is the programmer in our projects, maybe he can chime in.

[ulrik]

@lalalandsynth

[d.healey]

@lalalandsynth Make a pull request :)

[lalalandsynth]

@d-healey Yes, we discussed that :)

[jonhallur]

@d-healey said in Midi note 60 (hostIsPlaying) FX_Only ? Why ?:

@lalalandsynth Make a pull request :)

Do you have an guidelines or rules one must follow when doing pull requests?

[d.healey]

@jonhallur As far as I know there are none, except you'll need to sign an agreement to give Christoph permission to use your code. You can take a look at some of the previous pull requests - https://github.com/christophhart/HISE/pulls

I would recommend you keep the pull request as clean as possible - use git cherry-pick to include your changes on top of the latest develop branch.