[bug] Hydra tabs

[Christoph Hart]

Oh and that would drive-by solve the issue of external file references getting lost when a compile error occurs, which is also very annoying.

[Christoph Hart]

I've pushed a few commits to the hydra_season_finale branch which kind of implements this workflow. I've also vastly improved the jump-to-definition function, it should now work reliable with all symbol definitions in all namespaces (except for local variables).

[d.healey]

@Christoph-Hart Excellent, thank you! I look forward to trying it.

[d.healey]

Trying this out now. First thing I notice, after I close HISE and reopen it (but before I load my XML) I'm seeing the last script (.js) I had open in the script editor.

Perhaps when opening a new instance of HISE all tabs should be cleared.

[Christoph Hart]

@d-healey nooooooo! That‘s not even a bug, that‘s the entire feature I was working on for days!!!

[d.healey]

@Christoph-Hart Oh, I don't get it :) Why do we need to see the last file we had open before we've loaded a project's xml?

[Christoph Hart]

@d-healey That's usually how all IDE's I work with do it. Visual Studio, Xcode, Sublime Text - they all keep the edited files open when reopening the app.

It doesn't really matter what you see before you load the XML - but if you load it I want it to show the same files as last time.

[d.healey]

@Christoph-Hart Does Visual Studio open the last file even when no solution is open?

[Christoph Hart]

@d-healey No, it shows you a dialog where you can select which project to open, but let's not go down that road :)

[d.healey]

@Christoph-Hart In that case I think the current implementation is fine :)

[d.healey]

I don't think we have yet fully cured the problem.

I haven't narrowed down exactly what's causing this but I think it's something to do with switching between multiple projects.

[Christoph Hart]

Yes, I think I'll give up and do it like you said (remove all tabs on startup).

All praise to our new Hydra tabs overlord.

[d.healey]

@Christoph-Hart I like having 4 or 5 tabs ready to go, I just don't want HISE creating more.

[d.healey]

This gets weirder, I was working on a project with a bunch of tabs open, I switched to another project which only had 1 tab, when I went back to my previous project I now only have 1 tab there too.

[Dan Korneff]

@d-healey I just had 35 tabs open on my project :beaming_face_with_smiling_eyes:

[d.healey]

@Dan-Korneff Good luck!

[Christoph Hart]

OK, next attempt:

1. HISE will remove all tabs in the code editor tabs on app close.
2. HISE will add editors to this tab if needed. So if you goto a script processor workspace and the code tabs doesn't have a HiseScript code editor, it will add one. If you select a SNEX node to be edited and the code tabs doesn't have a SNEX editor, it will add one. If you select a Faust file to be edited and the code tabs doesn't have a Faust editor, it will add one. I think this is the solution with the best UX and the days of having to add code editors of any type manually should be finally gone.
3. The only exception to Rule 1 is that HISE will not remove tabs which are a container. So if you have any tab that you don't want to be closed by HISE on shutdown (eg. a server controller or OSC logger), you have to put it in a container (vertical or horizontal tile) so that it survives the tab massacre when the sun sets on the HISE app and the hydra tabs starts crawling out of the darkness.

I've also changed the X1/X2 buttons to work with goto undo / redo, fixed the Ctrl+Backspace shortcut not working on Windows and other minor things related to code navigation.

[d.healey]

@Christoph-Hart Sounds promising, I will rebuild now :)

[d.healey]

Little typo I think

../../../../../HISE/hi_scripting/scripting/api/ScriptingApi.cpp:1643:9: error: expected ‘,’ or ‘;’ before ‘auto’
 1643 |         auto s = dynamic_cast<GlobalSettingManager*>(getScriptProcessor()->getMainController_())->getSettingsObject().getSetting(Identifier(defName)).toString();
      |         ^~~~
../../../../../HISE/hi_scripting/scripting/api/ScriptingApi.cpp:1647:13: error: ‘s’ was not declared in this scope
 1647 |         if (s.contains(","))

[Christoph Hart]

@d-healey haha this is maybe one of 12 lines in the entire codebase that is not covered by my CI script and I managed to mess this up...