SFZ import error Line 9: no valid parent for group

[mwplugs]

@d-healey so the structure of an sfz is simple

<group>
lovel=0
hivel=127

<region> trigger=attack  pitch_keycenter=60 lokey=30 hikey=61 sample=SubDir/01C4.wav
<region> trigger=attack  pitch_keycenter=62 lokey=62 hikey=63 sample=SubDir/02D4.wav
<region> trigger=attack  pitch_keycenter=64 lokey=64 hikey=64 sample=SubDir/03E4.wav
<region> trigger=attack  pitch_keycenter=65 lokey=65 hikey=66 sample=SubDir/04F4.wav
<region> trigger=attack  pitch_keycenter=67 lokey=67 hikey=68 sample=SubDir/05G4.wav
<region> trigger=attack  pitch_keycenter=69 lokey=69 hikey=70 sample=SubDir/06A4.wav
<region> trigger=attack  pitch_keycenter=71 lokey=71 hikey=71 sample=SubDir/07B4.wav
<region> trigger=attack  pitch_keycenter=72 lokey=72 hikey=73 sample=SubDir/08C5.wav
<region> trigger=attack  pitch_keycenter=74 lokey=74 hikey=75 sample=SubDir/09D5.wav
<region> trigger=attack  pitch_keycenter=76 lokey=76 hikey=108 sample=SubDir/10E5.wav

importing an sfz with that structure yields this error

Line 1: no valid parent for group

like i said in my version from a few months ago that worked. for some reason now it isnt working. it seems it wont create a group from parsing the sfz no matter what is inserted code wise :(

[mwplugs]

@mwplugs if you see here in this thread this is what i did to be able to import them

Import Sfz From Sf2

I try in during a couple a day with "no result to import SF2 to SFZ "using Awave Studio." (nothing in the sampler after drag and drop the SFZ)" You need to...

Forum (forum.hise.audio)

but for some reason now it isnt working

[mwplugs]

@mwplugs @Christoph-Hart any thoughts as to why it is throwing this

no valid parent for group

error now?

<group>
lovel=0 hivel=127

<region> sample=sampledinst\sampledinst_000.wav lokey=0 hikey=37 end=220416 loop_mode=loop_continuous loop_start=146944 loop_end=220400 pitch_keycenter=36 bend_up=200 bend_down=-200 amp_veltrack=39.370079 ampeg_decay=0.5 ampeg_release=0.528 

<region> sample=sampledinst\sampledinst_001.wav lokey=38 hikey=39 end=220416 loop_mode=loop_continuous loop_start=146944 loop_end=220400 pitch_keycenter=38 bend_up=200 bend_down=-200 amp_veltrack=39.370079 ampeg_decay=0.5 ampeg_release=0.528 

<region> sample=sampledinst\sampledinst_002.wav lokey=40 hikey=41 end=220416 loop_mode=loop_continuous loop_start=146944 loop_end=220400 pitch_keycenter=40 bend_up=200 bend_down=-200 amp_veltrack=39.370079 ampeg_decay=0.5 ampeg_release=0.528 

<region> sample=sampledinst\sampledinst_003.wav lokey=42 hikey=43 end=220416 loop_mode=loop_continuous loop_start=146944 loop_end=220400 pitch_keycenter=42 bend_up=200 bend_down=-200 amp_veltrack=39.370079 ampeg_decay=0.5 ampeg_release=0.528 

<region> sample=sampledinst\sampledinst_004.wav lokey=44 hikey=45 end=220416 loop_mode=loop_continuous loop_start=146944 loop_end=220400 pitch_keycenter=44 bend_up=200 bend_down=-200 amp_veltrack=39.370079 ampeg_decay=0.5 ampeg_release=0.528 

<region> sample=sampledinst\sampledinst_005.wav lokey=46 hikey=47 end=220416 loop_mode=loop_continuous loop_start=146944 loop_end=220400 pitch_keycenter=46 bend_up=200 bend_down=-200 amp_veltrack=39.370079 ampeg_decay=0.5 ampeg_release=0.528 

<region> sample=sampledinst\sampledinst_006.wav lokey=48 hikey=49 end=220416 loop_mode=loop_continuous loop_start=146944 loop_end=220400 pitch_keycenter=48 bend_up=200 bend_down=-200 amp_veltrack=39.370079 ampeg_decay=0.5 ampeg_release=0.528 

<region> sample=sampledinst\sampledinst_007.wav lokey=50 hikey=51 end=220416 loop_mode=loop_continuous loop_start=146944 loop_end=220400 pitch_keycenter=50 bend_up=200 bend_down=-200 amp_veltrack=39.370079 ampeg_decay=0.5 ampeg_release=0.528 

<region> sample=sampledinst\sampledinst_008.wav lokey=52 hikey=53 end=220416 loop_mode=loop_continuous loop_start=146944 loop_end=220400 pitch_keycenter=52 bend_up=200 bend_down=-200 amp_veltrack=39.370079 ampeg_decay=0.5 ampeg_release=0.528 

<region> sample=sampledinst\sampledinst_009.wav lokey=54 hikey=55 end=220416 loop_mode=loop_continuous loop_start=146944 loop_end=220400 pitch_keycenter=54 bend_up=200 bend_down=-200 amp_veltrack=39.370079 ampeg_decay=0.5 ampeg_release=0.528 

<region> sample=sampledinst\sampledinst_010.wav lokey=56 hikey=57 end=220416 loop_mode=loop_continuous loop_start=146944 loop_end=220400 pitch_keycenter=56 bend_up=200 bend_down=-200 amp_veltrack=39.370079 ampeg_decay=0.5 ampeg_release=0.528 

<region> sample=sampledinst\sampledinst_011.wav lokey=58 hikey=59 end=220416 loop_mode=loop_continuous loop_start=146944 loop_end=220400 pitch_keycenter=58 bend_up=200 bend_down=-200 amp_veltrack=39.370079 ampeg_decay=0.5 ampeg_release=0.528 

<region> sample=sampledinst\sampledinst_012.wav lokey=60 hikey=61 end=220416 loop_mode=loop_continuous loop_start=146944 loop_end=220400 pitch_keycenter=60 bend_up=200 bend_down=-200 amp_veltrack=39.370079 ampeg_decay=0.5 ampeg_release=0.528 

<region> sample=sampledinst\sampledinst_013.wav lokey=62 hikey=63 end=220416 loop_mode=loop_continuous loop_start=146944 loop_end=220400 pitch_keycenter=62 bend_up=200 bend_down=-200 amp_veltrack=39.370079 ampeg_decay=0.5 ampeg_release=0.528 

<region> sample=sampledinst\sampledinst_014.wav lokey=64 hikey=65 end=220416 loop_mode=loop_continuous loop_start=146944 loop_end=220400 pitch_keycenter=64 bend_up=200 bend_down=-200 amp_veltrack=39.370079 ampeg_decay=0.5 ampeg_release=0.528 

<region> sample=sampledinst\sampledinst_015.wav lokey=66 hikey=67 end=220416 loop_mode=loop_continuous loop_start=146944 loop_end=220400 pitch_keycenter=66 bend_up=200 bend_down=-200 amp_veltrack=39.370079 ampeg_decay=0.5 ampeg_release=0.528 

<region> sample=sampledinst\sampledinst_016.wav lokey=68 hikey=69 end=220416 loop_mode=loop_continuous loop_start=146944 loop_end=220400 pitch_keycenter=68 bend_up=200 bend_down=-200 amp_veltrack=39.370079 ampeg_decay=0.5 ampeg_release=0.528 

<region> sample=sampledinst\sampledinst_017.wav lokey=70 hikey=71 end=220416 loop_mode=loop_continuous loop_start=146944 loop_end=220400 pitch_keycenter=70 bend_up=200 bend_down=-200 amp_veltrack=39.370079 ampeg_decay=0.5 ampeg_release=0.528 

<region> sample=sampledinst\sampledinst_018.wav lokey=72 hikey=73 end=220416 loop_mode=loop_continuous loop_start=146944 loop_end=220400 pitch_keycenter=72 bend_up=200 bend_down=-200 amp_veltrack=39.370079 ampeg_decay=0.5 ampeg_release=0.528 

<region> sample=sampledinst\sampledinst_019.wav lokey=74 hikey=75 end=220416 loop_mode=loop_continuous loop_start=146944 loop_end=220400 pitch_keycenter=74 bend_up=200 bend_down=-200 amp_veltrack=39.370079 ampeg_decay=0.5 ampeg_release=0.528 

<region> sample=sampledinst\sampledinst_020.wav lokey=76 hikey=77 end=220416 loop_mode=loop_continuous loop_start=146944 loop_end=220400 pitch_keycenter=76 bend_up=200 bend_down=-200 amp_veltrack=39.370079 ampeg_decay=0.5 ampeg_release=0.528 

<region> sample=sampledinst\sampledinst_021.wav lokey=78 hikey=79 end=220416 loop_mode=loop_continuous loop_start=146944 loop_end=220400 pitch_keycenter=78 bend_up=200 bend_down=-200 amp_veltrack=39.370079 ampeg_decay=0.5 ampeg_release=0.528 

<region> sample=sampledinst\sampledinst_022.wav lokey=80 hikey=81 end=220416 loop_mode=loop_continuous loop_start=146944 loop_end=220400 pitch_keycenter=80 bend_up=200 bend_down=-200 amp_veltrack=39.370079 ampeg_decay=0.5 ampeg_release=0.528 

<region> sample=sampledinst\sampledinst_023.wav lokey=82 hikey=83 end=220416 loop_mode=loop_continuous loop_start=146944 loop_end=220400 pitch_keycenter=82 bend_up=200 bend_down=-200 amp_veltrack=39.370079 ampeg_decay=0.5 ampeg_release=0.528 

<region> sample=sampledinst\sampledinst_024.wav lokey=84 hikey=127 end=220416 loop_mode=loop_continuous loop_start=146944 loop_end=220400 pitch_keycenter=84 bend_up=200 bend_down=-200 amp_veltrack=39.370079 ampeg_decay=0.5 ampeg_release=0.528 

[d.healey]

@mwplugs

like i said in my version from a few months ago that worked. for some reason now it isnt working

Try using a build of HISE from that time and see if it works. If it does just build your sample maps in that version until the bug is fixed.

[mwplugs]

@d-healey i dont think chris would pointlessly remove the bit of sfz functionality hise had. im hoping to just be able to import sfz files. its a button on the sampler and has been for a long time i hope someone can help me figure out how to actually import them as it would take years to manually make these hise samplemaps...

[mwplugs]

@mwplugs but yes using the old scriptnode codegen version worked again. seems strange it was broken but ok :/

[d.healey]

@mwplugs

i dont think chris would pointlessly remove the bit of sfz functionality hise had.

Me neither, but he might have broken it :)

If you can find the last commit where it worked then we can narrow down the cause.

[d.healey]

@mwplugs Looks like this is relevant to you https://github.com/christophhart/HISE/issues/311

[Casey Kolb]

@d-healey @mwplugs Funny that we just ran into this issue at the same time (it's fairly niche). I'm trying to allow SFZ imports in the compiled version of my plugin, but a lot of the SFZ files on Pianobook won't work as they don't have the parent group.

For importing, you'll just need to add <global> to the top of the SFZ file.

@Christoph-Hart Any chance we could add <global> automatically when importing SFZ files?

[d.healey]

@Casey-Kolb

Any chance we could add automatically when importing SFZ files?

Wouldn't it make more sense to just remove the requirement that is present in the SFZ?

[d.healey]

I reckon this has something to do with it - https://github.com/christophhart/HISE/blob/develop/hi_sampler/sampler/SfzImporter.cpp#L231

[Casey Kolb]

@d-healey Not sure what the appropriate course of action is there. Too deep for me ;)