Panel keyPressCallback and focus

ustk

@Christoph-Hart Gentle bump :) any chance you get the time to fix this?

I tried several fixes with no luck. It seems that the focus is lost as it should but when clicking anywhere in the interface editor, the first component automatically gets it back.
The keypress creates an "OS error" sound, thus making this callback unusable in an end product
Also noticed that since a few commits, the letters are printed 3 tttiiimmmeeesss... :)

HiseSnippet 1228.3ocsVstaZbDEdVauQYoMUMR8AXp+0hJl.j3jHa01fwPkkuDjwIpsQQQi2cfcBCyrZ2YsMpxuC8QsuAsmyLfArwVsnlUBXOy4x7w2btLcyzQ77bcFwK3rwobh2W62arxjzJgITjC1m38M9GyxM7Lpao8Fmxxy4wDOu0+EbAufMH1m+5m2iIYpH9rkHj2qEQ7iDiDlYq18MGJjxNrX9YhQyY8KdyAQZUKsTW.3Yc+ZjTVzP1.9ILzr07IdOpcrvny5YXFdNwai8zwi6knuT4r+8hbw4RNJTmzCBja4NZYLhXbURqDgLt6z+24DHJcmwBq6Xguy+XQr3l0mwFeqUAclGyyGdqsH7VeA3Ued3UaN3sDH4MGj1vAom52KJSjZloAwyW4efBNb5y.Zedn3rkr1O462RCVnLUGwFx6jAB23Q3KqUqBE9p7tkJUB39bC8BVFMUIyo+H8CS8jEG2ko3xvMs+TeyJz5nmvWkqThdmm6wuFS864feeD1Rbe9PsOVMma98i3WfFZA3l.dr5pubck5qyngoTgxB0xk9iRAonkcgiIyo5BiPwC6WnhLBsJbP4RAfEACp1Gx6ZJkg0tpQiN1GHZnBvWWdGnZ6smoBTJ5GZRD4UiYFV0DVdGcTArkAnawYrKOkGYbVLfaNRGwj6oKTw4g.2PqWs1jvL+d39Iu5kIBCeBBvP0TJFn3wmwuxL2dZ.wJz6aG1LBX5LdLxKAW61LKWbHeb2LHQoESJOGpilwG5y+bYpiRd1ynmAoETFUp0CoLicePh0jvoXFgVxA6Z4dqZZFPvglLL4ACiE7NRBDqJbrCTtnFvQNB2if6RePxEZ9TQLHWCe3xb9TmxuTXhRrQcHebKcrMdNcHra2qUyts2gtOWxMbKbQhxpNhkyoMd0NNRSpy41sIr7tTp0f.aZ54Yb1vcmFvSae16N8D5gs+scnet.pDP+rwsO57r.W+4OPfCtUT2qYqC60sYK.omxGouvEQIzQkFkv.dDJEmE5WuCkt3AOvTKtP07hyyMvwvfvZUtsNIWMvjrU8x6tbzzLMkqhoL0XpRq1JOkGIXxagjXdeVgzrCENT+dj+mXFjPUdRXCtEH+A244MwYWzFz1qmbxhBVex3oXMZ3zr0qKgOSSMoZ0IZC+spPaMMnkdaU86uTcXKmLsTxyVpZbPS1C4XnpXz47rJP+OYA+FCgtuK1R2+9aoO+DmHWGv4LTqNPILuE3+6aNDYRaS3s2cv9.2hyAlrFXWJOyHPH3sO+BXnpapPf+977gFcJLerkdTpVgQv6QFq1mLclA19kHfICO120BmbE7ewKF1qwSe4RQrIAE9SOBIgKFjXlph7eHzMtUnq38vg9tS5fYr53BIyr3fW71FST.GcKLsCmnoxElwyeaj+2lF+uEhO0uK1yZ4XbskfQ3.9KAFmbGlm32teeX3zL.tgeme8KyEVHtgtCNlAslvy+SJF0ClwEwwYAPVAV53sFlI4jqgxHCzCZHYE9a3Yhx5nr2Dk0mpjLhEko+TjqfEukzisq.XRYufX.bSUPlVmXKhA+7qUsFYDbgsOEEg+82Bp6VtOMVAed9J3yKVAe1dE74kqfOuZE740OnO3ckaVXzibkCvBcaa6r440VwfLKaVH4e.CLja4.

ustk

Trying another bump...

Christoph Hart

@ustk You need to return true from that function so that the system knows it consumed the key stroke. This solves problems 2 and 3.

The first one is a bit more tricky because JUCE propagates the key focus by default to its first children and it's super annoying to find the spot where you need to disable this.

ustk

@christoph-hart Oh cool for the return true thing, it works...

As for the focus issue, why is the callback called when clicking outside of the object anyway?
Because the focus is lost as it should when using this.loseFocus();, so why would the callback be called again from a click that didn't occur onto the panel?

Christoph Hart

@ustk it will get executed as soon as the panel gains focus and clicking on it is just one of the possibilities (Eg. Tab key cycles trough the siblings)...

This is deeply embedded into JUCE and debugging this is super annoying...

ustk

@christoph-hart said in Panel keyPressCallback and focus:

This is deeply embedded into JUCE and debugging this is super annoying...

please tell me it's doable
Or we can say goodbye the entire API

Christoph Hart

@ustk it's definitely doable (probably a one line fix at the right location), but finding it is the hard thing...

ulrik

@ustk said in Panel keyPressCallback and focus:

I tried several fixes with no luck. It seems that the focus is lost as it should but when clicking anywhere in the interface editor, the first component automatically gets it back.

This works okey

It has 5 Panels just for testing
At init, all Panels will be set to the same KPC, PR & MCB

for (p in Panels)
{
	p.setPaintRoutine(PR);
	p.setMouseCallback(MCB);
	p.setKeyPressCallback(KPC);
}

then in MCB

if (event.clicked)
	{
		for (p in Panels)
			p.setKeyPressCallback("");
	}

and in

if (event.clicked && event.shiftDown)
	this.setKeyPressCallback(KPC);

HiseSnippet 1507.3ocyX80aaaCDWJIpsxaEaEXe.37CExXIN1IY8OIXXwwwoKHModwoEqurBFIZK1HSpQRkTih.rG19Jrm2CaeE1yCaeg12fsihx1xNxooAsC0.Iv7t62we7tijGcaA2mHkbgks6QChIV1erSmALUXyPLkYs61V1kbNgLHV.VYs0fXrTRBrrsm+QZ81tKXk94e95svQXlOYrHKqmwo9jGS6SUik1dy8nQQ6fCHGQ6my501bWeNqIOhm.bYdmZVwX+Sv8HGf0lMmik8MZEPUbQGEVQjV1KrEOXPmP9YLi8OiJoGGQzCpa0AbjQ7N7n.Mi0RsZFRiBZObMKs.uzdbDXdSD3yb1mFPGIebj3SSUfFiHe7vdtIo27SPu54oWsbzq.JYmiRKXnzcb53KnwpwZz74ib1koHhtXHrmmJFasl6utoSSNXASUsO9DxNBXvHDd2qVsEQv+prQoRPnWpPmhEn1XFIRh9JzPj8HpFQQM48i4LXrzqbpIk0vxv09PvdutILeEky75UozqK41qZWHQCP8LIUY0ynpvFQwg3QR5IHCVDUq5JU.u4pwHIJixwnBoJhVcupAB7YMhn8XjfiHuR4oBoRM+dFNJg3UYQzPAOl6ii1hmvBjd0.4k8AlKHAkm8zf+gDberfxtr4J.qvUUvvq1TU57bAo8at0DQIxofgoQJZWjYTU+Hp+IjfJkbAwtc4BjWLhxxRJfXW2XM22iLnsdCYSbTzwv1Duxoqry0KtK3MzcuKxHPFR6p1FpHylfz0PQtau1MM9yr.VdY2GQXDANBMsotKMqOYKavUSrr4G+xJH8pFpuj7HR0XHlCgWgtjTqTOwzt5uVkJ2g6mHgMfrdj7bNMODhMpA2qMd3PSb.BWDC.IT14Gl5O3brl7.smR03t7xnVcZ1ncq0QaShHJBjUg+f7qVqOVRPqb+0QSl5goqb4MPZKbOVPvmrQlqNr0QO8vCP6054qidYBrzi3RiG6p40HWVe0LWp0mRYuJo9P6jugHHHHkjhiQNC1SB01HEGUVio7hHnn.l0.TWAuepUwvwSBdhBJcS8xvrpYWQLVHI6xlt.tR1TVzZKUQgEeWd42zAjsZzbuNsazDBuGR5yO0DLhvPnwODCIb3jnwQEcj9hg5IETUlbrTAEL87ps3z5hHrdpvkpeApXRjq7fKjI+BX492+V4Bsu9CuWw1+Skmg+eXw1+6yx+2uX6+4Y3+0lAe9iYXe80J19eobAopFwwDV.ByFfXb1RxXhOE1sOQZJfzEmDoVGA6N+b81oLqfpgrhC2KNeZ6F4kMz1.ldd5VT3ao1KH5JXkm4rYAQkHXHkHgrg43mKVIBadSqCaqwcnoz2q8gZGjJeedhjLp3DN3cjlYbR24COdBwYGvUjmv7RmkRmWBMsptcKTm95RAOJhHJTstYGwkAzikz+XhXQyF9QFBc.LYaENytsh7c83at8Nmgb1tLp5IPddV8BYkckOzBhSFq.SUoMfb6gMfnSAVTnMia5X9dJey20m0aF6sLXqOMXuMu5fWYJv+42+V.d0Qfuwqeqo8ZiAWxMC7S2canrW27VVPDBrwDghpyY1aSNE5D1zJmqy1D4IJdbZTNqqJP7aJN+pwgI5lCxO3LZfJbrfmuYHg1KTkWBTtyOaXQOvnOwAZLCMVfDeJbIgdqAAvYOWe7qxC25pPzQI0wP+wu8CYltxLioG8AFSWMGS+U0Gxwz0lYLU8+ASu3Kmf2rwCRhvpIeHm90qYJfigm30S5WHwjT0f7ut8c1q6tpT7NNs08sVLGmq.NBm879fiYuI91Ns51k3qFSvEb146d+7.XKyU581GCs5A4WmCR52AdjlOQ+R.cK.fL64zGYaFWSOVGA5.MwjN3egOYJqqGamor9PkV8w9B9K7Mm4qe08sRk.bhk9CN35rudLZzcTNN0pVypOMf9Bee8xeI3Nzhwrx0.ypWCLqcMv7kWCL26Zf49WCLO3Rwn+sWZjn38MaG.AsakdoqscKFFprRqBs9OJy5GYB

ulrik

@ulrik a better example

HiseSnippet 1529.3ocyXEraabCDcWauIYUaPa.5G.qNDrB0VVx1MNwFs0xxxoFN1Q0xIn4T.8tTZY7JxsjbsiPgAxg168TO2Cs+B8Gn+P8RO2Nj6JoUxqbcLZJh.rg3Lya3iyLjbnZK39DojKrrcOdPLwx9Cc5LfoBaFhoLq81wxtjyojAwBvJqsGDikRRfks87OVq21cAKym+7q1FGgY9jwhrrdNm5SdBsOUMVZ6s1mFEsKNfbLseNqWaq874rl7HdBvk4cpYEi8OE2ibHVa1bNV12pU.UwEcTXEQZYuv17fAcB4myRs+4TI8jHhdPcqNfiREuKOJPyXsTqlgznf1CWyRKvKsGGAlOMB7INGPCnijONR7wFEnwHxGOrmaR5M+Dzqdd5UKG8JfR14nzBoT5dNc7EzX0XMZ97AN6wTDQWLD1ySkTasl6utsSSNXASUsO9TxtBXvHDdOnVsEQv+prYoRPnWpPmgEn1XFIRh9BzPj8HpFQQM48i4LXrzqrwjxZXY3ZeDXuW2DluhxYd8pT56K41qZWHQCP8RSpxpmSUgMhhCwijzSPFrHpV0Up.dysjKsKxSERkUCvJbUE40ppQDVOUH5KQ0pTxEbK3WIQk5fQ9A+cI39XAkQz9ALIPfOuQDsGiDbL3kob5hHyXXk8DtONZadBKP5Uqxhnx9vRTPBzqN2KJ4BgBxrm1yCopqbFgY343nDhWkq8TdQt35AM2dh.K4LvTSvUGnLip5GQ8OkDjEb5xEHuXDkkkGAwttwZpuOYPa8d3l3nnSfcVdkGtFKvan6eeTp.YHsqZGnHNaBLqhhb29saleAr7xtOlvHBbDZZScWZVexV1fqlXYyO4UUP5UMTRJ4QjpwPlFhvBcUrVodhoc0esJUtK2OQB6YY8H44rI4GhSUCtWa7vgSmqkPkpenwevQeM4AZOYz3t7xnVcZ1ncqMP6PhHJBjWg+fLtVqOVRPqr9FnIq2foqb4MQZKbOQPvmtYlqNp0wO6nCQ625EafdUBrzi3xTO1UyqQtr9pYtTq2PYOSYmwIeMQPPPJwfiQNG1FCkbHEGUVio7hHnn.l0.TWAuuwpX3DMAOQAaXLdYXVMsXMFKjj8XSuqoR1TVzZynnvhuqt7a5.x1MZtem1MZBg2iH84mkFLhvPnwODCIb3vqwQEcj9xg5oN.QlbhTAEL87psHpvCWVp9knRZhbkGdoL4mAK2+3WKWn80ezCJ19en7L7+iJ19eaV9e8hs+Gmg+WaF742mg80WqX6+4xEjpZDGSXAHLa.hwYKIiI9TX29Doo.RWbRjZCDr67S0amxrBpFxJNbu77osajW1TaCX5Elsnv2L1KH5JXkW5sFBhJQvPJQBYyzietbkHr40TG1Vi6nzReu1GocfQ9A7DIYTwIbv6HMy3jtKFd7DhyNjqHOk4YlkRWTBMsptcKTm9FVAOJhHJTst+HwUAzikz+DhXwzM7iLDZZXxNQblcmH4aTxO8B+bFxY6wnpmB44Y09jUVWBPWKNYrBLUY5Y4tC6YQmBrnPmI21I86F9Bs9cq2b2rNE+2wdmTr0GANquQust9fWYJv+TxaA3UmdlW+s.7ZSCd+srd1d6.k8598xBhPfMlHTTcNydGxYPyyoc+45rCQdphGahxYMhAh+2hyud77Q2ZP9AmSCTgiE7hsBIzdgp7Rfxc94CK5AF8QNPubnwBj3yfKIzaMH.N645iecd3VWGhNJoNF5a9l2mY5JyLld76YLc0bL8WTuOGSWalwT0+GL8xO1BdlGOHIBql7se5G7lo.NFdhGboeTESRUCx+f3+ydP30kh2yostu0h43bEvQ3rm2EbL6Yz20oU2tDe0XBtfyte66l2LakdkduCvPqdP904vj9cf2n4SzuDP2B.HydN8MMoiqoGqi.cflXLC9a3Slx55w1YJqOToUeruf+R+zy70OT+NFI.mXleiBWmCziQitixwoV0ZV8oAzW56qW9KA2gVLlUtAXV8FfYsa.lO+Ff4A2.LqeCv7vqDi9mqoQhh2Oc6.HncKykt11sXXnxxTEZ8ODo3tTM

ustk

@ulrik that's a cool hack, however I am not sure it is safe to kill the CB from within itself...

ulrik

@ustk Yeah it feels a bit risky, I wish it could work as it's supposed to
I could need it in a project

ustk

@ulrik I'm waiting for a proper implementation for my current project so I won't risk a bug, the release is soon...

Christoph Hart

@ustk I think I've found the spot where to put that line. On the other hand, it's bad coding week, so nobody knows what I'm breaking with this :)

https://github.com/christophhart/HISE/commit/cbdab1d60823f213db4f87a81ff19edd8b927e79

ulrik

@christoph-hart Yes, but it can only get better now, right? ;)

Lindon

@christoph-hart said in Panel keyPressCallback and focus:

@ustk I think I've found the spot where to put that line. On the other hand, it's bad coding week, so nobody knows what I'm breaking with this :)

https://github.com/christophhart/HISE/commit/cbdab1d60823f213db4f87a81ff19edd8b927e79

perhaps more testing before commits?

ustk

@christoph-hart trying to build...

ustk

@christoph-hart So that seems to work. But can't we lose focus when clicking anywhere outside of the panel?
If not, then it's not much of a big deal since hitting "enter" works

ulrik

@christoph-hart this was what I needed, thank you

Christoph Hart

@ulrik Then let's hope it doesn't break Lindon's computer :)

ulrik

@christoph-hart 🥶

Panel keyPressCallback and focus

21

1.8k

10.4k

90.8k