Expansions / Combo Box + SampleMaps

[DanH]

@d-healey said in Expansions / Combo Box + SampleMaps:

void PresetBrowser::expansionPackLoaded(Expansion* currentExpansion)
{
if(expansionColumn != nullptr && currentExpansion != nullptr)
selectionChanged(-1, -1, currentExpansion->getRootFolder(), false);
else
selectionChanged(-1, -1, File(), false);
}

Testing... It's line 737 in Master Branch for anyone else following..

[d.healey]

@DanH What crazy fool is using the master branch! :p

[DanH]

@d-healey Cos its stable! There's a few things in Develop that don't match up with what I've already made so waiting for things to be ironed out

[d.healey]

@DanH I've found develop to be more stable than master, especially with look and feel stuff. What parts have you found that are unstable?

[DanH]

@d-healey Well it began with tableprocessors but that's been fixed. Waiting for table laf to be enabled now plus I can't compile plugins on it yet but need to test more to find out why

[d.healey]

@DanH said in Expansions / Combo Box + SampleMaps:

Waiting for table laf to be enabled

Does that work on Master branch?

[ustk]

Plugins are compiling with develop branch. If it's not the case the issue's on your side.
But I heard some plugins exported from develop can be undetected by the DAW. This has to be confirmed though.

[DanH]

@d-healey yup. I did @ christoph in a post about it recently

I also find the editor (I know I can reset this) and the windows resizing to be a bit of a pain currently in Dev.

[d.healey]

@DanH Window resizing was fixed and the new editor is awesome, it just doesn't remember some settings properly yet :p

[ustk]

@DanH The more we are for testing, the more the bugs will be fixed :)

[DanH]

@ustk I'm dipping in and out :)

[DanH]

@d-healey works great :) Thank you! Worth pushing to Christoph?

[d.healey]

@DanH I already have an open pull request and everytime I add something it automatically gets added to it - https://github.com/christophhart/HISE/pull/192 - I have no idea how it works but it's a mess :p

[Lindon]

@d-healey said in Expansions / Combo Box + SampleMaps:

@DanH I've found develop to be more stable than master, especially with look and feel stuff. What parts have you found that are unstable?

-- So the laggy EQ display problem is fixed?

[DanH]

@Lindon just tried and seems ok

[DanH]

@d-healey So all working nicely. When an extension is active and the sample maps are loaded into the combo box the names of the maps have a prefix of '{EXP::expansionname}'

which is a little annoying!

I've had a look in ScriptExpansion.h/.cpp but I can't see anything to potentially change in there and I wonder if it's the baseline wildcard reference.

Any ideas of how to change the prefix most welcome!

[d.healey]

@DanH Run through the names in a loop and use the replace command to remove the extra text. I used the replace command in a recent LAF video on Patreon if you need guidance on that function.

[DanH]

@d-healey will have a crack :)

[d.healey]

@d-healey said in Expansions / Combo Box + SampleMaps:

everytime I add something it automatically gets added to it - https://github.com/christophhart/HISE/pull/192 - I have no idea how it works but it's a mess

I just figured out how to make cleaner pull requests for individual changes, which should be much more pleasant for Christoph to merge. So here it is - https://github.com/christophhart/HISE/pull/195

[DanH]

@d-healey Morning, hope you had a good weekend!

Looking into this solution and struggling to make it work with what I've got.

So you've suggested running the names in a loop. My names (sample map names) are (I guess?) inside my 'sampleMap' array (which changes every time you switch expansion).

I'm at a loss of how to access any kind of 'text' parameter of the sample maps, like you have done in your laf video with the icons.

I also wondered if I need to define the bit I want to remove as below. I got this far befoe realising I'm missing a couple of pieces of the puzzle

    local prefix = ("EXP::");

        for (i = 0; i < sampleMaps.length; i++)
    {
        sampleMaps[i].replace("EXP::");
        prefix[i].replace("");
    }