Expansions / Combo Box + SampleMaps

[d.healey]

@DanH Window resizing was fixed and the new editor is awesome, it just doesn't remember some settings properly yet :p

[ustk]

@DanH The more we are for testing, the more the bugs will be fixed :)

[DanH]

@ustk I'm dipping in and out :)

[DanH]

@d-healey works great :) Thank you! Worth pushing to Christoph?

[d.healey]

@DanH I already have an open pull request and everytime I add something it automatically gets added to it - https://github.com/christophhart/HISE/pull/192 - I have no idea how it works but it's a mess :p

[Lindon]

@d-healey said in Expansions / Combo Box + SampleMaps:

@DanH I've found develop to be more stable than master, especially with look and feel stuff. What parts have you found that are unstable?

-- So the laggy EQ display problem is fixed?

[DanH]

@Lindon just tried and seems ok

[DanH]

@d-healey So all working nicely. When an extension is active and the sample maps are loaded into the combo box the names of the maps have a prefix of '{EXP::expansionname}'

which is a little annoying!

I've had a look in ScriptExpansion.h/.cpp but I can't see anything to potentially change in there and I wonder if it's the baseline wildcard reference.

Any ideas of how to change the prefix most welcome!

[d.healey]

@DanH Run through the names in a loop and use the replace command to remove the extra text. I used the replace command in a recent LAF video on Patreon if you need guidance on that function.

[DanH]

@d-healey will have a crack :)

[d.healey]

@d-healey said in Expansions / Combo Box + SampleMaps:

everytime I add something it automatically gets added to it - https://github.com/christophhart/HISE/pull/192 - I have no idea how it works but it's a mess

I just figured out how to make cleaner pull requests for individual changes, which should be much more pleasant for Christoph to merge. So here it is - https://github.com/christophhart/HISE/pull/195

[DanH]

@d-healey Morning, hope you had a good weekend!

Looking into this solution and struggling to make it work with what I've got.

So you've suggested running the names in a loop. My names (sample map names) are (I guess?) inside my 'sampleMap' array (which changes every time you switch expansion).

I'm at a loss of how to access any kind of 'text' parameter of the sample maps, like you have done in your laf video with the icons.

I also wondered if I need to define the bit I want to remove as below. I got this far befoe realising I'm missing a couple of pieces of the puzzle

    local prefix = ("EXP::");

        for (i = 0; i < sampleMaps.length; i++)
    {
        sampleMaps[i].replace("EXP::");
        prefix[i].replace("");
    }

[d.healey]

@DanH That looks good to me, just remove the prefix thing, you don't need that, and remember that replace returns a new string so you need to assign that to the array element

[DanH]

@d-healey Thanks David, how do I assign the new string?

[d.healey]

@DanH

sampleMaps[i] = sampleMaps[i].replace(blahablahblah);

You could use a for in loop here if you want to be fancy efficient.

[DanH]

@d-healey brilliant, that works, thank you :)

The name of the expansion is prefixed as well - which I might keep. But would there be a way of referencing that within the brackets?

So currently it looks like:

{*nameofexpansion}*sampleMapname

eg {DAN EXP 1}BASS 1

[d.healey]

@DanH Just add a second replace command on the next line.

[DanH]

@d-healey that's clever!

[DanH]

@d-healey Argh :face_with_tears_of_joy:

So possibly by changing the naming system the sampler now can't find the sample maps :man_facepalming:

Hmmmm... So this whole thing was to display the names nicely in the combo box which is used for switching sample maps. Perhaps I can link another combo box to actually select the sample maps and this one just displays the names nicely?

Or a knob?

Actually that would probably break the system I'm already using

EDIT - Actually a parallel combo box might be the one

[d.healey]

Add the {EXP: part back in when you load the sample map.