BUG (& FIX) in Midi Learn panel value displays

[dannytaurus]

TL;DR the last row painted in the MIDI Learn panel uses raw values instead of formatted.

Here's a PR fix.

MIDI learn a CC to knob then open the MIDI Learn panel. The values are normalised to 0.0-1.0, regardless of the knob's range:

Type Min 0.5 RETURN to set the min value to half the range and it changes to 1%:

To actually change Min to half the range I have to type 50:

That now works as expected, but the Max still shows the normalised range. Confusing!

If I MIDI Learn two params, then open the MIDI Learn panel, the first one shows correctly, and the second one shows the correct number range but still omits the units:

When I learn third param, the second one's units show and the third rows values are normalised:

After the PR fix all rows show correct ranges and units:

[David Healey]

@dannytaurus said in BUG (& FIX) in Midi Learn panel value displays:

MIDI learn a CC to knob then open the MIDI Learn panel. The values are normalised to 0.0-1.0, regardless of the knob's range:

I don't see that (possibly I already fixed it in a PR but don't recall).

[dannytaurus]

@David-Healey Yeah, very possible you already hit this a long time ago and fixed it on your fork.

Yours doesn't seem to show any rows that would have units, or is the 0-20000 in ms?

[David Healey]

@dannytaurus said in BUG (& FIX) in Midi Learn panel value displays:

is the 0-20000 in ms?

Correct. I'm styling it with laf so possibly I removed the units to make it fit better

[dannytaurus]

@David-Healey Makes sense