Change Slider Value via MIDI + Velocity

[d.healey]

@aaronventure said in Change Slider Value via MIDI + Velocity:

wanted to point out that ChatGPT will not only write the code, but will explain all the reasoning behind all the decisions it made

I think this is great if you know that what it's giving you is correct. The problem is as a beginner you don't know if the info is accurate or not. It could provide a wonderful explanation that is totally wrong and code doesn't work.

[aaronventure]

@d-healey Yeah absolutely, it's also still not following HISEScript coding practices (maybe I should hardcode that in the settings).

I guess what I'm trying to say is, we don't deserve the robots; we could've pasted the post into it, and just copied back the response without the code

The issue you're encountering seems to stem from a couple of misunderstandings about how to check if a note is in your keySwitchesC array and how to properly use the cAnimation function. Here's a breakdown of what needs to be fixed:

The issue you're encountering seems to stem from a couple of misunderstandings about how to check if a note is in your keySwitchesC array and how to properly use the cAnimation function. Here's a breakdown of what needs to be fixed:

1. Checking for Key Presses: You are using Message.getVelocity() to check if a key is in your keySwitchesC array, but Message.getVelocity() returns the velocity of the note being played, not its pitch. You should use Message.getNoteNumber() to check if the played note's pitch matches any of the Cs in your array.

2. Using indexOf Properly: The indexOf method returns -1 if the element is not found in the array. Any other returned value (i.e., 0 or above) means the element was found. Therefore, you need to check if the result of indexOf is not equal to -1 to confirm the presence of the note number in your array.

3. The cAnimation Function: Your cAnimation function seems to be designed to set the slider's value, but it's missing the value parameter. You need to decide what value you want to set the slider to when a C note is pressed. Since the function takes an index, you might want to use this index or the note number itself to determine the slider's value.

which we basically did write, a lot more sparsely and over a bunch of posts where it appears scattered and might be tough to navigate, just because we're lazy to go in depth in the first place, ultimately wasting more time than necessary.

The response still requires the OP to take a look at their own code, check the docs etc. to figure out the proper syntax for things if they don't know.

Just musing; my fever might be coming back.

[trillbilly]

@d-healey One last issue. When releasing a key, it forces all animations back to 0. I'd like if a key is released, only that animation is returned to 0 while the others stay out.

I tried using an "if/else" statement in the onNoteOff but it throw an error on the "else".

Could you point me in the right direction?

[d.healey]

@trillbilly said in Change Slider Value via MIDI + Velocity:

I tried using an "if/else" statement in the onNoteOff but it throw an error on the "else".

Snippet

[trillbilly]

@d-healey
Here is snippet. This one is broken because of the if/else in onNoteOff. If you remove that, everything works but when you Play C & D together, then release one, both animations return to 0.

HiseSnippet 1341.3oc4XE2SaaDE+bRbWi6FpcpaZ+4Iz9ifTFMFn.UnoFHAphVCDgoroUsgNrujbB667ru.jMUo8QaeD1Gk9MX6c1Nw1fAxhJUSpQBTdu6987u68d268b5EHroggh.jV0iF6SQZett0XtbXqgDFG0oMRaA8tjPIM.GqZmw9jvPpCRSq7qTJzpVAE848ubGhKgaSSUgPGKX1zWy7XxTs8Z9CLW28HNziXdY18ZM6XK3sDthQ.eJq2.4SrOiLftOQssR5HsGrqCSJBrjDIMDoUYGgyXqghK3w6+XVH6TWpRvDYAFJV8dBWGEiUeG0ZHy0o2jycHBoo2K0KTN1K7T8tLG1T8odiGGs.NEQV+gVo7zqbN5YdSzq.JokgRUhozSzsrCX9xzUT74Q5c3PvoOAb6YoR7dQkbpn2R.6fKW1ibFcu.PXJhZq2nQcL7uk1xv.b8gR74j.bnKyAh2eOdBxATYKgmufCB0VLd4EALWEh4cfwbw7OnynistfIsGRCaAPeKPFyUpiWYs53UWuNdsMUjqNdCP2lftW.5LaroZSM9ksvO6YsBK1XsUFC.YBfVA.sJf44pSJnaCP2lftWnriYzSbkHi0NzvfwcYbJt+HtsjI3X6s4LOh5q0XbG5kKY7GXL1.9K4DubHUdLwcDMY8sxtl8PBe.0oFn8cW21N2ksMuMialy5SMpfuuPROfWCrlQUvCYXTk0GWKqmdYvmIg74vZcg7H35kJVofs+HuSoA0VZokLpBnyd5ygOhMGz+lguE.VcVpVjiJCpiotBalbbsHHuKBgh0suFoaOyjF93THuaOW71b1HNFhv3qFE52ONLv5W6bkE.FZTclcGy9y2nJ0Mjlw34R7xRK0ky.gqq53pX1UVVUNt3UR.ViG4qpiSNOIaDpQkuv2ClsBe1w0JxrQAuCmIOvmlHmV41rfxjnjhMPAyRILD1pLpb4BIkKshbIHFXjGpG6ePQrGp6qE01YFPVMAo4Uf9lNsIRhpdcBS.14SCjLkSPqM8bn4Wb06p5sogmIE9QTMotHn9tI6koMH+0limJ7mus4ELG4PEW9YPdHkMXnTIcIH4QRg8WmzD5e6aw9cEw0MWtAxi433R6IBYp3apMOnIZlHWp+HyiwMC6.pduvtq2VDZHKbF4Rj46RqFMIYAkMx1ZT09iC1db1QWtZq6J2bFbiBmrnv7yYjtOQumpFUw7sTA7UkveOy2jAg9B8c62mZKSIaE889oacpmO3TYgXp7HcKnAZzzoQD4qijw+H4bJ9UTNMP4TMukAT+6Yc.U+Yd.0Crkvi+n.BOzWDlyvVTO1QvMovrJeSHLBF82NTEkypukfDT3Ru+k6AGxBwXQjiBhRW11SLhKykdTdliIYKHm+VSl8WvHpUtulZ9i5Uu60JE+GdGjR8t1ah8XH+1y2ktK+bncOnQw2uD5izmLxUNQa9D9tBtvenfyrylMbHUFvFLfFj8bT3gaaoDdkqTMOs4gTWJIal82170PFII.7Yzayu7A8keJL18M5wzEqtkh+eU09OKl1F5SlTKhve0TQ7zii4cyVnnwQjH5jFR6.g+.oBTpt1Ta1oT27Alq2pXtCLePZmU9Sy1YGJFIY7AcIvMQX3Gc3kNrftH1TfIbNL+tZ1nRpNAwxMlLioEk6DI7OvmjEMUxZIKZNYwOJOCOhcf3D63QlUWVeXjF3byi9QZpp2UIiSmTVuQ7HcrSrsUt6uyDgJFyJyAlUmCLqMGXd9bfY84.yFyAlMuULpNuaORJheiXHf1s2tQu0hl1tbUYknrdz+B+FZVW

[d.healey]

@trillbilly Your if statement is missing curly braces

[trillbilly]

@d-healey I get the same error

! Line 8, column 2: Found 'else' when expecting a statement

[d.healey]

@trillbilly Show me your if statement

[trillbilly]

@d-healey This is where Im starting and trying to work my way out.

function onNoteOff()
{
	if (keySwitchesC.contains(Message.getNoteNumber()))
{	
	slider.setValue(Message.getVelocity());
	slider.changed();
	
	slider1.setValue(Message.getVelocity());
	slider1.changed();
	
}	
}

[d.healey]

@trillbilly Show me the one that doesn't work

[trillbilly]

@d-healey Any else statement I do like this.

function onNoteOff()
{
	if (keySwitchesC.contains(Message.getNoteNumber()))
{	
	slider.setValue(index);
	slider1.setValue(index);
	
	else
	
	slider.setValue(Message.getVelocity());
	slider1.setValue(Message.getVelocity());
	
}	
}

I get the error:

! Line 8, column 2: Found 'else' when expecting a statement

[d.healey]

@trillbilly I just had a similar conversation with another forum member a few minutes ago :)

Code is written in blocks. Blocks are defined by opening and closing curly braces {}

Your if statement is a block, and so requires {}

if (something)
{
}

Your else is also a block, so it also needs curly braces.

else
{
}

[trillbilly]

@d-healey ahhhh, yes. Now I see.

Im confusing myself on the order I should be doing this in.

*Example:
If slider changes value

else

these slider stay same value*

Im confused which way I call for the slider in the IF statement. Do I call just the slider or do I call the "cKeySwitch" Variable or "cAnimation" Function. I've tried them all and cant seem to figure it out. The animation compiles and still works but the issue is not fixed,

[d.healey]

@trillbilly Write it out as a list, in English.

Do this,
Then do this,
If this, do this,
Otherwise do this
etc.
etc.

It might make it easier to figure out the flow of the program.