HISE Logo Forum
    • Categories
    • Register
    • Login

    Scriptnode - External Display Buffer when plugin bypassed

    Scheduled Pinned Locked Moved Scripting
    20 Posts 3 Posters 1.4k Views
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • Dan KorneffD
      Dan Korneff @Christoph Hart
      last edited by

      @Christoph-Hart I am noticing one thing. I made a simple test like this:

      const var th = Engine.createTransportHandler();
      
      th.setOnBypass(function(isBypassed)
      {
      	if(isBypassed)
      	{
                Console.print("bypassed");   
      
      	}
      	else
      	{
                Console.print("running"); 
      	}
      });
      

      the state of setOnBypass seems to have a mind of it's own. This is what I'm seeing when the plugin is enabled and just sitting idle:

      bypass state.gif

      Dan Korneff - Producer / Mixer / Audio Nerd

      Christoph HartC 1 Reply Last reply Reply Quote 0
      • Christoph HartC
        Christoph Hart @Dan Korneff
        last edited by

        @Dan-Korneff oh then maybe the watchdog interval is set too low. What buffer size and sample rate are you using?

        Dan KorneffD 2 Replies Last reply Reply Quote 0
        • Dan KorneffD
          Dan Korneff @Christoph Hart
          last edited by

          @Christoph-Hart 96K 512

          Dan Korneff - Producer / Mixer / Audio Nerd

          Christoph HartC Dan KorneffD 2 Replies Last reply Reply Quote 0
          • Christoph HartC
            Christoph Hart @Dan Korneff
            last edited by

            This is what I'm seeing when the plugin is enabled and just sitting idle:

            Ah you mean HISE as a plugin? I haven't checked that - I just tested the bypass simulator in the HISE controller and as compiled plugin.

            Does it still fire if you switch to 44.1Khz?

            Dan KorneffD 2 Replies Last reply Reply Quote 0
            • Dan KorneffD
              Dan Korneff @Christoph Hart
              last edited by

              @Christoph-Hart I'm sorry for not being clear. I'm talking about HISE standalone. When I refer to enable/disable plugin, I meant via "bypass simulator" in the HISE controller.

              Dan Korneff - Producer / Mixer / Audio Nerd

              1 Reply Last reply Reply Quote 0
              • Dan KorneffD
                Dan Korneff @Christoph Hart
                last edited by

                @Christoph-Hart Just a quick update. This may be having adverse effects on the display buffer when the exported plugin is active. I can't recreate it here yet, but I'll report my findings as soon as I can.

                Dan Korneff - Producer / Mixer / Audio Nerd

                Dan KorneffD 1 Reply Last reply Reply Quote 0
                • Dan KorneffD
                  Dan Korneff @Dan Korneff
                  last edited by

                  @Christoph-Hart OK. Figured out a clue. It's not playing nice with low buffer sizes and can be recreated in HISE. Same goes for the latest version of Reaper
                  Anything below 128 will make the meters flicker. Higher buffer sizes work as expected.
                  Are you able to see the same on your end?

                  Dan Korneff - Producer / Mixer / Audio Nerd

                  1 Reply Last reply Reply Quote 0
                  • Dan KorneffD
                    Dan Korneff @Christoph Hart
                    last edited by

                    @Christoph-Hart said in Scriptnode - External Display Buffer when plugin bypassed:

                    oh then maybe the watchdog interval is set too low

                    I think this is the issue. Whenever the console reports that the plugin is bypassed, my script kicks in and kills the meter. Where can I find this interval to test?

                    Dan Korneff - Producer / Mixer / Audio Nerd

                    1 Reply Last reply Reply Quote 0
                    • Dan KorneffD
                      Dan Korneff @Dan Korneff
                      last edited by

                      @Christoph-Hart

                      raw.gif

                      Dan Korneff - Producer / Mixer / Audio Nerd

                      Christoph HartC 1 Reply Last reply Reply Quote 0
                      • Christoph HartC
                        Christoph Hart @Dan Korneff
                        last edited by

                        @Dan-Korneff Just checked with 64 samples here and it works correctly in HISE (the detection does factor in the buffer size). You can play around with the numbers here:

                        Link Preview Image
                        HISE/hi_core/hi_core/MainController.cpp at 0b1d1512d4af43232e44d60f62d072c8e621d531 · christophhart/HISE

                        The open source framework for sample based instruments - HISE/hi_core/hi_core/MainController.cpp at 0b1d1512d4af43232e44d60f62d072c8e621d531 · christophhart/HISE

                        favicon

                        GitHub (github.com)

                        If you manage to find a better value, let me know :)

                        Dan KorneffD 1 Reply Last reply Reply Quote 0
                        • Dan KorneffD
                          Dan Korneff @Christoph Hart
                          last edited by Dan Korneff

                          @Christoph-Hart After doing a bunch of testing, I've found that the magic number appears to be 48.
                          When I do the math:

                          auto numSamples = (double)getMainController()->getOriginalBufferSize();
                          auto sampleRate = (double)getMainController()->getOriginalSamplerate();
                          auto blockLengthSeconds = numSamples / sampleRate;
                          auto deltaForBypassDetection = roundToInt(1000.0 * 48.0 * blockLengthSeconds);
                          
                          buffer = 64
                          sample rate = 48000
                          
                          1000 * 48 * blockLengthSeconds = 64
                          

                          Is it a coincidence that the magic number is equal to the buffer size of my audio card or that the value is a multiple of my sample rate?

                          Now the part that is driving me crazy....
                          Even with the increased sampling time, I can get the transport handler to trigger false positives when I move an item on my screen. Check out the console:

                          false positive.gif

                          It appears to not only be affected by the buffer, but also the way getApproximateMillisecondCounter is being calculated.

                          Dan Korneff - Producer / Mixer / Audio Nerd

                          1 Reply Last reply Reply Quote 0
                          • Dan KorneffD Dan Korneff referenced this topic on
                          • First post
                            Last post

                          37

                          Online

                          1.8k

                          Users

                          12.0k

                          Topics

                          104.1k

                          Posts