Custom DSP Network Crashes DAW
-
Hello,
I'm having an issue where a scriptnode network is compiling fine (dll) but when exported (vst3) it crashes the DAW (Cubase). It's a custom delay effect. I can't figure out where the problem might be. If anyone has any idea in which direction to move to fix this it would be great. Thank You!
Download: Delay.xml
-
Have you compiled it to a hardcoded FX before exporting (I would recommend doing this for effects with this complexity and no outside dependency).
Also, please use the snippet format to post example codes - I had to download the XML, put it in the folder, rename it and create a network for it to replicate what could have been a single "File -> Import HISE Snippet" command.
-
@Christoph-Hart Oh actually I can replicate the crash when I load the compiled network into a HardcodedMaster FX. It seems that it wrongly scales the initial delay time to a bogus value which then eats up all the memory when trying to allocate the delay buffers. I'll investigate more..
-
So the reason why it's crashing is that you're using different ranges for the delay time parameter knobs and their targets. In order to solve it, always make sure that you're using the same range on both ends or it will create a conversion (which in this time, failed).
I'll think about a way to display this to the user so that it doesn't crash silently, but in the meantime, all you need to do to solve this problem is to open the range editor of the target knobs (the one that displays the curve over the knobs) and then right click and choose "Copy range to source". This will make sure that there is no range conversion going on.
-
@Christoph-Hart Thats awesome, thank you sir! :)
-
Alright, I've added a warning icon next to the parameter knob if there is a range mismatch between source and target.
I don't want to fix it automatically as there are a few reasons why you would want a different input range (eg. the soft_bypass templates map an integer range 0-4 to 0.0...1.0 of the fader node) but in most cases it's a subtle difference that will make the compiled node slightly less performant (or in this case even crash).
Clicking on the button will show you a dialog with the source and target range and you can easily copy the target range back to the source to make the warning go away (if it's reasonable). Note: if the source range and the target range appear the same, it's most likely a difference in step size that causes the warning.
-
Ranges are the same, but still get this warning. Is it safe to use like this?
-
@orange check the skew values
-
@Matt_SF said in Custom DSP Network Crashes DAW:
@orange check the skew values
Skew values are the same too, also as it's shown in the image, middle points are even the same :)
-
@orange ah don't mind my sillyness. I assume you've check the other properties by right-clicking on the parameters? (stepSize, etc...)
-
@Matt_SF Yes all of the properties are the same.
Threshold knob is connected to the converter node (dBtoGain mode)