confusing convolution
-
-
@d-healey Wish I was a c++ wizard :(
-
@iamlamprey You can be, if you start now and work at it for 5+ years :)
-
bumpy :)
-
Still need help with this... any new Commit I get stuck in a "The Sample directory could not be located" loop.
And any older commit past Master looks for audiofiles in the Expansion folder, despite me using
{PROJECT_FOLDER}
wild card.This is the last thing bottlenecking my MacOS release, I haven't changed a line of code since moving from Master to Develop
-
@iamlamprey said in confusing convolution:
And any older commit past Master looks for audiofiles in the Expansion folder, despite me using {PROJECT_FOLDER} wild card.
So this issue is fixed now?
-
@d-healey Sorry, any newer* commit
Anything on Develop branch is either looking for the audiofiles in the Expansion's subfolders, or its not embedding them in the first place
-
I might make a barebones expansion project and see if it can do what I need it to
-
@iamlamprey said in confusing convolution:
@d-healey Sorry, any newer* commit
Yeah that sounds similar to the issue I'm having.
-
Yep confirmed it with a barebones version:
- Convolution works fine without an expansion loaded.
- After installing & loading an expansion, it keeps the IR loaded (still works).
- If you try to select a new IR, the convolution stops (I assume because it's looking in the wrong folder).
- If you go back to no expansion loaded, it works again and you can switch files all you want.
@Christoph-Hart could you please take a look at this when you get the chance? I think something's wrong with the {PROJECT_FOLDER} wildcard or something :)
-
bump, could we please get some acknowledgement that something's up with expansions? seen several threads about it now and this is the last thing i need working before i can push my mac release
-
bump, officially reached 1 month of my convolution not being usable
-
It's fixed now, it was indeed looking in the audio files folder of the expansion.
-
@christoph-hart Does this solve the includes issue with full expansions?
-
@d-healey I don't think so but if you can make a minimal example, I'll take a look (not sure if you did that already).
-
@christoph-hart said in confusing convolution:
not sure if you did that already
Me neither :) but I shall whip one up very soon.
-
@Christoph-Hart Here's the full expansion project and also the test expansion with the included scripts. I notice that the scripts are inlined when the expansion is loaded. I'm not sure if the issue is caused when the hxi is generated or when the expansion is loaded.
I also noticed the using
Engine.loadFontAs("{PROJECT_FOLDER}FontName.ttf", "pretty-name");
causes issue too because once the expansion loads it's still looking in thePROJECT_FOLDER
instead of the expansion folder. Even if I include the font in the shell's images folder it won't work. I assume the best way to handle this would be to have the hxi exporter replace PROJECT_FOLDER with EXP::EXPNAME ? That way it would work while developing the expansion but also work when loaded as an expansion...I haven't tested but I think this would affect anything that's using PROJECT_FOLDER paths, like additional source code, sample maps, and images.
-
@d-healey Oh wow, that might be the commit with the weirdest looking fix in the history of HISE...
https://github.com/christophhart/HISE/commit/2bdd95a60d094c577dd7a0199130756c7de955c3
Like you see the code change and immediately know, "yeah, that makes total sense".
-
@christoph-hart Haha, you gotta love regex :D
Thanks, I'll give it a try this evening.
-
@christoph-hart Thank you