Setting server headers for downloads

[ustk]

@d-healey So the pendingDownload doesn't take a extraHeader parameter like the pendingCallbackdoes...
I don't see how to add this though, because their structures are different... @Christoph-Hart's the guy we need :)

[David Healey]

@ustk Yeah I had a look myself and came to the same conclusion :)

[ustk]

@d-healey In fact it seems doable, but then I can't test it as my woo-commerce isn't ready...

Try to add

String extraHeader;

inside the ScriptDownloadObject struct (between line 384-389 in ScriptingApiObjects.h)

and

newDownload->extraHeader = extraHeader;

at line 54 of GlobalServer.cpp

And cross your fingers

[David Healey]

Thanks, I'll try it now!

@ustk said in Setting server headers for downloads:

I can't test it as my woo-commerce isn't ready...

You should setup a local server for testing using something like XAMPP if you're going to be working with the Server API a lot.

[ustk]

@d-healey Yeah thanks, I don't know anything about servers and web stuff, but I take your words for it :)

[David Healey]

Didn't work unfortunately.

[ustk]

@d-healey Oh I think that's because the extraHeader has to be linked to the pendingCallback one, or we need to create a new one somehow. I think we're close ;)

[ustk]

@d-healey So I think you we need to create a new method for setting the header specific to downloadObject, so try adding a method like this to the ScriptingApiObjects.h

void setDownloadHttpHeader(String newHeader)
{
    extraHeader = newHeader;
}

[David Healey]

@ustk The download object doesn't exist until after the call to Server.downloadFile. So by then it will be too late to set the header.

[ustk]

@d-healey I don't understand why two extraHeader are declared, one in the pendingCallback and one below in private. I imagine the one that is used is the private one. So we shouldn't declared it in the ScriptingApiObject.
This means that just passing it insed the addDownload (newDownload->extraHeader = extraHeader;) should be enough, just before adding a pending download as it is done for the pendingCallback.

[ustk]

@d-healey I think it should be passed to these inputStream calls instead of String():

in start

auto wis = downloadURL.createInputStream(false, nullptr, nullptr, String(), HISE_SCRIPT_SERVER_TIMEOUT, nullptr, &status);

and in resume

auto wis = downloadURL.createInputStream(false, nullptr, nullptr, String(), 0, nullptr, &status);

[David Healey]

@ustk Replacing String() with the token didn't work :(

[ustk]

@d-healey I'm definitely out of ideas now

[David Healey]

@ustk I have one idea - nag Christoph :p

[David Healey]

@Christoph-Hart Got any pointers about this issue?

[tomekslesicki]

@d-healey @Christoph-Hart I'm running into a similar problem where I need to include some headers in the download call. Have you found a solution to this issue?