• Dark Theme
    • Categories
    • Register
    • Login
    HISE Logo Forum
    • Categories
    • Register
    • Login

    Mark notes that contain samples by coloring keyboard keys

    Scheduled Pinned Locked Moved General Questions
    colorkeyboard
    34 Posts 6 Posters 2.5k Views
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • C
      Christoph Hart
      last edited by 22 Feb 2019, 15:59

      Ok this was one time too much that people stumble over this. I‘ll add a button and a discard warning ;)

      1 Reply Last reply Reply Quote 1
      • G
        gorangrooves @gorangrooves
        last edited by 22 Feb 2019, 15:59

        @gorangrooves I tested the script and it works for a sampler :) Yay!

        Is there a way to specify that it uses the master container that contains all of the samples instead of a single sampler? Or do I need to replicate the script for each sampler?

        Goran Rista
        https://gorangrooves.com

        Handy Drums and Handy Grooves
        https://library.gorangrooves.com

        D 1 Reply Last reply 22 Feb 2019, 19:58 Reply Quote 0
        • D
          d.healey @gorangrooves
          last edited by 22 Feb 2019, 19:58

          @gorangrooves If there is more than one sampler you will need to modify the code. Put all of the samplers in an array and loop through all of them, test if any of them have a sample mapped to i and if so colour the key - so you will have a loop inside another loop.

          Libre Wave - Freedom respecting instruments and effects
          My Patreon - HISE tutorials
          YouTube Channel - Public HISE tutorials

          G 1 Reply Last reply 24 Feb 2019, 22:29 Reply Quote 0
          • G
            gorangrooves @d.healey
            last edited by 24 Feb 2019, 22:29

            @d-healey Thank you! I spent the last couple of days thinking of your answer. While I understand every word individually, I can't say I do when they are combined in such a way 😀 I am sorry.
            Could you please give me some pointers with regards to "array and loop"? I assume I am supposed to do this with code and not with the way they are arranged within sampler container, no?

            Goran Rista
            https://gorangrooves.com

            Handy Drums and Handy Grooves
            https://library.gorangrooves.com

            D 1 Reply Last reply 24 Feb 2019, 22:40 Reply Quote 0
            • D
              d.healey @gorangrooves
              last edited by d.healey 24 Feb 2019, 22:40

              @gorangrooves Yes code.

              So you need to use this part of the code which gets the sampler const var Sampler1 = Synth.getChildSynth("Sampler1");

              But instead of storing one sampler in one variable you need to store all of the samplers you are interested in using in an array. There are several ways to do this but the simplest is manually one line at a time.

              const var samplers = []; //Declare the array
              samplers[0] = Synth.getChildSynth("Sampler1"); //Add sampler 1 to the array (index is 0)
              samplers[1] = Synth.getChildSynth("Sampler2"); //Add sampler 2 to the array (index is 1)
              samplers[2] = Synth.getChildSynth("Sampler3"); //Add sampler 3 to the array (index is 2)
              

              Then you need to loop through all of the samplers. Again there is more than one way to do this, here is how I would probably do it.

              for (s in samplers)
              {
              }
              

              Then inside this loop you have the original loop I posted that checks every key and colours the right one, only this time it will do this for every sampler in the samplers array.

              reg i;
              
              for (s in samplers)
              {
                  for (i = 0; i < 127; i++)
                  {
                      if (s.asSampler().isNoteNumberMapped(i)) //s is the sampler being checked, we get s from the outer loop
                          Engine.setKeyColour(i, Colours.withAlpha(Colours.blue, 0.3));
                  }
              }

              Libre Wave - Freedom respecting instruments and effects
              My Patreon - HISE tutorials
              YouTube Channel - Public HISE tutorials

              G 1 Reply Last reply 25 Feb 2019, 04:29 Reply Quote 1
              • G
                gorangrooves @d.healey
                last edited by 25 Feb 2019, 04:29

                @d-healey Thanks so much for your kindness and for teaching me! I will be playing around with this and hopefully will manage to get it going :) I'll report back.

                Goran Rista
                https://gorangrooves.com

                Handy Drums and Handy Grooves
                https://library.gorangrooves.com

                G 1 Reply Last reply 25 Feb 2019, 20:52 Reply Quote 0
                • G
                  gorangrooves @gorangrooves
                  last edited by 25 Feb 2019, 20:52

                  @d-healey I got it working! Thank you sooo much! I still don't fully understand how you came up with the logic for the code. Good on you. Quite simple and most importantly, it works :) Thank you. Thank you. Thank you!

                  Goran Rista
                  https://gorangrooves.com

                  Handy Drums and Handy Grooves
                  https://library.gorangrooves.com

                  D 1 Reply Last reply 25 Feb 2019, 21:26 Reply Quote 0
                  • D
                    d.healey @gorangrooves
                    last edited by 25 Feb 2019, 21:26

                    @gorangrooves No problemo

                    I still don't fully understand how you came up with the logic for the code.

                    By reading lots of code and writing lots of code ;)

                    Libre Wave - Freedom respecting instruments and effects
                    My Patreon - HISE tutorials
                    YouTube Channel - Public HISE tutorials

                    J 1 Reply Last reply 21 Jan 2021, 23:26 Reply Quote 1
                    • J
                      Jerems134 @d.healey
                      last edited by 21 Jan 2021, 23:26

                      @d-healey I've many sample maps on one sampler and all keys are coloured at the same time, have an idea to do with sample map ?

                      //I've try replace 
                      const var Sampler1 = Synth.getChildSynth("Sampler1");
                      
                      reg i;
                      
                      for (i = 0; i < 127; i++)
                      {
                          if (Sampler1.asSampler().isNoteNumberMapped(i))
                              Engine.setKeyColour(i, Colours.withAlpha(Colours.blue, 0.3));
                      }
                      //by
                      const var Sampler1 = Synth.getChildSynth("Sampler1");
                      const var sampleMaps = Sampler.getSampleMapList();
                      
                      reg i;
                      
                      for (i = 0; i < 127; i++)
                      {
                      if (Sampler.getSampleMapList().isNoteNumberMapped(i))
                              Engine.setKeyColour(i, Colours.withAlpha(Colours.blue, 0.3));
                      }
                      

                      Not working

                      D U 2 Replies Last reply 21 Jan 2021, 23:43 Reply Quote 0
                      • D
                        d.healey @Jerems134
                        last edited by 21 Jan 2021, 23:43

                        @Jerems134 I don't understand the question, could you rephrase it?

                        Libre Wave - Freedom respecting instruments and effects
                        My Patreon - HISE tutorials
                        YouTube Channel - Public HISE tutorials

                        1 Reply Last reply Reply Quote 0
                        • U
                          ustk @Jerems134
                          last edited by ustk 21 Jan 2021, 23:43

                          @Jerems134 It is not the SampleMap you need to check but the sampler itself Sampler1.asSampler() assuming your sampler is called "Sampler1"
                          Perform this each time you load a new sampleMap

                          Can't help pressing F5 in the forum...

                          1 Reply Last reply Reply Quote 1
                          • J
                            Jerems134
                            last edited by Jerems134 22 Jan 2021, 09:19

                            @d-healey @ustk On Sampler1 I have 2 sample maps loaded and I switch with presets/combo box.
                            How to color keys only for samplemap1 and match coloured keys on samplemaps2 when I switch presets ?
                            Actualy all keys from all sample maps are coloured no matter different sample maps mapping.
                            They are layered.

                            Full code :

                            Content.makeFrontInterface(1200, 370);
                            
                            const var Panel1 = Content.getComponent("Panel1");
                            const var Panel2 = Content.getComponent("Panel2");
                            const var Button1 = Content.getComponent("Button1");
                            
                            //Tab button callback function
                            inline function onButton1Control(component, value)
                            
                            {
                                if (value == 1) 
                            	    Panel2.showControl(true);
                            	    else
                            	    Panel2.showControl(false);
                            	};
                            
                            Content.getComponent("Button1").setControlCallback(onButton1Control);
                            
                            //Presets ComboBox Function
                            //Sampler
                            const var Sampler1 = Synth.getChildSynth("Sampler1");
                            
                            //Sample maps array
                            const var sampleMaps = Sampler.getSampleMapList();
                            
                            //Combo box
                            const var cmbSampleMap = Content.getComponent("cmbSampleMap");
                            cmbSampleMap.set("items", sampleMaps.join("\n"));
                            
                            
                            inline function oncmbSampleMapControl(component, value)
                            {
                            	Sampler1.asSampler().loadSampleMap(sampleMaps[value-1]);
                            };
                            
                            Content.getComponent("cmbSampleMap").setControlCallback(oncmbSampleMapControl);
                            
                            //Coloured Keys
                            //const var Sampler1 = Synth.getChildSynth("Sampler1");//(Repetiton)
                            
                            reg i;
                            
                            for (i = 0; i < 127; i++)
                            {
                                if (Sampler1.asSampler().isNoteNumberMapped(i))
                                    Engine.setKeyColour(i, Colours.withAlpha(Colours.blue, 0.3));
                            }
                            
                            U 1 Reply Last reply 22 Jan 2021, 10:25 Reply Quote 0
                            • U
                              ustk
                              last edited by 22 Jan 2021, 10:23

                              Add a hidden panel on the interface. Wrap your key colour code in the panel callback.
                              Don't forget to enable saveInPreset so when you change preset the callback is called

                              Can't help pressing F5 in the forum...

                              1 Reply Last reply Reply Quote 0
                              • U
                                ustk @Jerems134
                                last edited by 22 Jan 2021, 10:25

                                @Jerems134 sorry you already have sample map selection in a callback so just place your code after that, no need for another panel…

                                Can't help pressing F5 in the forum...

                                J 1 Reply Last reply 22 Jan 2021, 10:34 Reply Quote 0
                                • J
                                  Jerems134 @ustk
                                  last edited by 22 Jan 2021, 10:34

                                  @ustk Key color code is working, but I use 1 sampler with 2 sample maps, I would like color each sample maps on the same sampler when I switch sample maps

                                  D 1 Reply Last reply 22 Jan 2021, 11:28 Reply Quote 0
                                  • D
                                    d.healey @Jerems134
                                    last edited by 22 Jan 2021, 11:28

                                    @Jerems134 You mean you want to color blue keys to match the range of the loaded sample map? If so I'd use two hidden knobs, or a range slider, to set the range of keys to be colored and save this with your preset.

                                    Libre Wave - Freedom respecting instruments and effects
                                    My Patreon - HISE tutorials
                                    YouTube Channel - Public HISE tutorials

                                    J 1 Reply Last reply 22 Jan 2021, 11:48 Reply Quote 0
                                    • J
                                      Jerems134 @d.healey
                                      last edited by Jerems134 22 Jan 2021, 11:48

                                      @d-healey I’ve to set the range with knob or it’s just for saving preset ?
                                      Its possible to make it automatic ?
                                      I already have the code to save a preset. For now just the first samplemaps color the keys, when I change samplemap/preset, keyboard stay coloured like samplemap1, it dosent match with samplemap2.

                                      1 Reply Last reply Reply Quote 0
                                      • D
                                        d.healey
                                        last edited by 22 Jan 2021, 12:00

                                        Oh I get it now. You're only coloring the keys in on init, you need to recolour them each time a preset is loaded, try moving the loop into the combo box callback.

                                        Libre Wave - Freedom respecting instruments and effects
                                        My Patreon - HISE tutorials
                                        YouTube Channel - Public HISE tutorials

                                        J 1 Reply Last reply 22 Jan 2021, 12:03 Reply Quote 1
                                        • J
                                          Jerems134 @d.healey
                                          last edited by Jerems134 22 Jan 2021, 12:03

                                          @d-healey Trying this doesn't work, now all sample maps color keys at same time, no matter I change sample map

                                          //Combo box
                                          const var cmbSampleMap = Content.getComponent("cmbSampleMap");
                                          cmbSampleMap.set("items", sampleMaps.join("\n"));
                                          
                                          
                                          inline function oncmbSampleMapControl(component, value)
                                          {
                                          	Sampler1.asSampler().loadSampleMap(sampleMaps[value-1]);
                                          };
                                          reg i;
                                          
                                          for (i = 0; i < 127; i++)
                                          {
                                              if (Sampler1.asSampler().isNoteNumberMapped(i))
                                                  Engine.setKeyColour(i, Colours.withAlpha(Colours.blue, 0.3));
                                          }
                                          Content.getComponent("cmbSampleMap").setControlCallback(oncmbSampleMapControl);
                                          
                                          1 Reply Last reply Reply Quote 0
                                          • D
                                            d.healey
                                            last edited by d.healey 22 Jan 2021, 12:45

                                            As I said, try putting the loop inside the combobox callback function.

                                            Libre Wave - Freedom respecting instruments and effects
                                            My Patreon - HISE tutorials
                                            YouTube Channel - Public HISE tutorials

                                            1 Reply Last reply Reply Quote 0
                                            • First post
                                              Last post

                                            59

                                            Online

                                            1.9k

                                            Users

                                            10.8k

                                            Topics

                                            94.2k

                                            Posts