HISE Logo Forum
    • Categories
    • Register
    • Login

    fixed expansion hr1 archiving

    Scheduled Pinned Locked Moved General Questions
    expansions
    21 Posts 6 Posters 1.6k Views
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • d.healeyD
      d.healey
      last edited by

      Darn it :(

      Libre Wave - Freedom respecting instruments and effects
      My Patreon - HISE tutorials
      YouTube Channel - Public HISE tutorials

      1 Reply Last reply Reply Quote 1
      • A
        arminh
        last edited by

        My heart always beating faster when i see information about expansion in commits :D

        1 Reply Last reply Reply Quote 1
        • d.healeyD
          d.healey
          last edited by

          Is there anything stopping us from making our own expansion type system now we have the various file APIs (which I have yet to explore)? The main thing expansions solved for me was being able to change which presets showed up in the preset browser based on the selected expansion, is that possible via the new APIs?

          Libre Wave - Freedom respecting instruments and effects
          My Patreon - HISE tutorials
          YouTube Channel - Public HISE tutorials

          Casey KolbC 2 Replies Last reply Reply Quote 0
          • Casey KolbC
            Casey Kolb @d.healey
            last edited by

            @d-healey You can totally build your own preset browsers now with the new FileSystem API. I just finished building out a sub-preset loader / saver which stores the files in a different preset folder within AppData 😀

            Now that we can read / write any file and load it as an object, you can build pretty much whatever you need to from what I can tell.

            Casey Kolb
            Founder & CEO of Lunacy Audio
            Composer | Producer | Software Developer

            1 Reply Last reply Reply Quote 1
            • Casey KolbC
              Casey Kolb @d.healey
              last edited by Casey Kolb

              @d-healey Though to answer your question, I think you still need to edit the C++ to change which presets are shown in the preset browser. Unless of course you just build your own preset browser.

              Casey Kolb
              Founder & CEO of Lunacy Audio
              Composer | Producer | Software Developer

              1 Reply Last reply Reply Quote 1
              • Christoph HartC
                Christoph Hart
                last edited by

                Well sample maps and embedded midi files will require the „real“ expansion system, but for simple use cases like Casey described you might get somewhere.

                d.healeyD 1 Reply Last reply Reply Quote 1
                • d.healeyD
                  d.healey @Christoph Hart
                  last edited by

                  @Christoph-Hart Any ETA on fixing the proper expansion system?

                  Libre Wave - Freedom respecting instruments and effects
                  My Patreon - HISE tutorials
                  YouTube Channel - Public HISE tutorials

                  1 Reply Last reply Reply Quote 1
                  • Christoph HartC
                    Christoph Hart
                    last edited by

                    What would actually be helpful would be a list of things that don‘t work (or what you are trying to do and what prevents you from doing so). It‘s basically finished (from the inside), but I kind of lost the overview over all use cases so this might be the most efficient way to fix all the trivial issies so you can work with it.

                    d.healeyD 1 Reply Last reply Reply Quote 0
                    • d.healeyD
                      d.healey @Christoph Hart
                      last edited by

                      @Christoph-Hart

                      These are the main issues I'm aware of:

                      • If you click the button to create a new expansion folder, the file browser will open to choose a destination, but then when you click save HISE will just close.
                      • The dropdown list of expansions in the sampler workspace is always empty (even for old projects that have expansions already).
                      • Engine.getExpansionList(); always returns an empty array
                      • I'm not sure if expansion loading is working (needs testing).

                      If these issues are fixed then I think we would have a usable system.

                      Other additions that would be nice:

                      • A method to extract hr files to ch from within a script so that we could implement an integrated downloader/installer.
                      • The settings tile has a button to change sample location, it would be good if this updated when the expansion was changed.

                      If anyone else knows of other expansion related issues please chime in.

                      Libre Wave - Freedom respecting instruments and effects
                      My Patreon - HISE tutorials
                      YouTube Channel - Public HISE tutorials

                      C 1 Reply Last reply Reply Quote 0
                      • C
                        coreyu21 @d.healey
                        last edited by

                        @d-healey I still have the c++ saveInPreset preset issue as before. It’s really important for users when loading the plugin on a saved project in the daw. The plugin should be able to load the used expansion preset onInit so the user doesn’t have to spend amounts of time finding out what preset they used for their project.

                        ..unless their had been a fix for this I’m unaware of. Thank you lots🙂

                        1 Reply Last reply Reply Quote 1
                        • Christoph HartC
                          Christoph Hart
                          last edited by

                          These are the main issues I'm aware of:

                          Speaking of trivial issues, you haven't enabled the Expansion Support checkbox in your project's preferences in HISE :)

                          d269a9ab-429e-4ea9-b9ec-3e134b6c4c81-image.png

                          I changed it during the rewrite so that you don't need to recompile HISE with another flag in order to use projects with Expansions, (so the HI_ENABLE_EXPANSIONS flag isn't necessary anymore as long as you don't use any custom C++ expansions you don't need to mess with compiler flags anymore).

                          The default setting is "Disabled", which will be the case for projects created before this change. Just change it (restart HISE) and all the things you mentioned are working.

                          d.healeyD 1 Reply Last reply Reply Quote 1
                          • d.healeyD
                            d.healey @Christoph Hart
                            last edited by d.healey

                            @Christoph-Hart Well that was a sneaky thing to do :cat_face: Thank you!! Maybe replace the silent crashing with a popup message though.

                            Libre Wave - Freedom respecting instruments and effects
                            My Patreon - HISE tutorials
                            YouTube Channel - Public HISE tutorials

                            1 Reply Last reply Reply Quote 0
                            • d.healeyD
                              d.healey
                              last edited by

                              New issue (or maybe there is a solution already :p )

                              Loading an expansion used to update the preset browser with the expansion's presets but this doesn't seem to be working now.

                              Libre Wave - Freedom respecting instruments and effects
                              My Patreon - HISE tutorials
                              YouTube Channel - Public HISE tutorials

                              A 1 Reply Last reply Reply Quote 0
                              • A
                                arminh @d.healey
                                last edited by

                                @d-healey @Christoph-Hart i noticed issue on builded plugin. I copied expansions to plugin folder in AppData but they're not visible in plugin.

                                1 Reply Last reply Reply Quote 0
                                • DalartD
                                  Dalart
                                  last edited by

                                  Did anyone manage to get expansions working correctly since latest fixes ?

                                  d.healeyD 1 Reply Last reply Reply Quote 0
                                  • d.healeyD
                                    d.healey @Dalart
                                    last edited by

                                    @Dalart There hasn't been any fixes. Turns out expansions were (mostly) working all along, Christoph just hadn't told us we needed to change a setting. There are some other issues @arminh reported but there haven't been any expansion related commits since then so I assume those issues are still present.

                                    Libre Wave - Freedom respecting instruments and effects
                                    My Patreon - HISE tutorials
                                    YouTube Channel - Public HISE tutorials

                                    DalartD 1 Reply Last reply Reply Quote 0
                                    • DalartD
                                      Dalart @d.healey
                                      last edited by

                                      @d-healey Alrighty.

                                      1 Reply Last reply Reply Quote 0
                                      • First post
                                        Last post

                                      11

                                      Online

                                      1.7k

                                      Users

                                      11.8k

                                      Topics

                                      103.2k

                                      Posts