Latest Build Errors

d.healey

I'm seeing some build errors with the most recent changes.

In file included from ../../../../../HISE/hi_components/hi_components.cpp:42:0,
                 from ../../JuceLibraryCode/include_hi_components.cpp:9:
../../../../../HISE/hi_components/plugin_components/PresetBrowser.cpp: In member function ‘virtual void hise::PresetBrowser::resized()’:
../../../../../HISE/hi_components/plugin_components/PresetBrowser.cpp:912:50: error: ‘bankColumnWidth’ was not declared in this scope
    bankColumn->setBounds(listArea.removeFromLeft(bankColumnWidth).reduced(2, 2));
                                                  ^~~~~~~~~~~~~~~
../../../../../HISE/hi_components/plugin_components/PresetBrowser.cpp:912:50: note: suggested alternative: ‘bankColumn’
    bankColumn->setBounds(listArea.removeFromLeft(bankColumnWidth).reduced(2, 2));
                                                  ^~~~~~~~~~~~~~~
                                                  bankColumn
../../../../../HISE/hi_components/plugin_components/PresetBrowser.cpp:915:54: error: ‘bankColumnWidth’ was not declared in this scope
    categoryColumn->setBounds(listArea.removeFromLeft(bankColumnWidth).reduced(2, 2));
                                                      ^~~~~~~~~~~~~~~
../../../../../HISE/hi_components/plugin_components/PresetBrowser.cpp:915:54: note: suggested alternative: ‘bankColumn’
    categoryColumn->setBounds(listArea.removeFromLeft(bankColumnWidth).reduced(2, 2));
                                                      ^~~~~~~~~~~~~~~
                                                      bankColumn
../../../../../HISE/hi_components/plugin_components/PresetBrowser.cpp:917:51: error: ‘presetColumnWidth’ was not declared in this scope
   presetColumn->setBounds(listArea.removeFromLeft(presetColumnWidth).reduced(2, 2));
                                                   ^~~~~~~~~~~~~~~~~
../../../../../HISE/hi_components/plugin_components/PresetBrowser.cpp:917:51: note: suggested alternative: ‘presetColumn’
   presetColumn->setBounds(listArea.removeFromLeft(presetColumnWidth).reduced(2, 2));
                                                   ^~~~~~~~~~~~~~~~~
                                                   presetColumn
In file included from ../../../../../HISE/hi_components/hi_components.cpp:42:0,
                 from ../../JuceLibraryCode/include_hi_components.cpp:9:
../../../../../HISE/hi_components/plugin_components/PresetBrowser.cpp: At global scope:
../../../../../HISE/hi_components/plugin_components/PresetBrowser.cpp:1036:67: error: no ‘void hise::PresetBrowser::setColumnWidthRatio(double)’ member function declared in class ‘hise::PresetBrowser’
 void PresetBrowser::setColumnWidthRatio(double newColumnWidthRatio)
                                                                   ^
../../../../../HISE/hi_components/plugin_components/PresetBrowser.cpp: In member function ‘void hise::PresetBrowser::setOptions(const hise::PresetBrowser::Options&)’:
../../../../../HISE/hi_components/plugin_components/PresetBrowser.cpp:1155:2: error: ‘setColumnWidthRatio’ was not declared in this scope
  setColumnWidthRatio(newOptions.columnWidthRatio);
  ^~~~~~~~~~~~~~~~~~~
../../../../../HISE/hi_components/plugin_components/PresetBrowser.cpp:1155:2: note: suggested alternative: ‘columnWidthRatio’
  setColumnWidthRatio(newOptions.columnWidthRatio);

ustk

@d-healey Mmmm… My bad!
Seeing what I can do, but I might need help…
I don't have these scope errors when compiling on mac though

ustk

@d-healey In fact, I get the error too since @Christoph-Hart's merge. A mistake when resolving a conflict maybe?

d.healey

I see some stuff in the commit history, maybe I buggered it when I merged scriptnode a few days ago :(

ustk

@d-healey Yeah I've just fixed some missing parts in the FrontendPanelTypes.
There are also a few things going on with the expansion addition... I'm on this part

d.healey

@ustk said in Latest Build Errors:

@d-healey Yeah I've just fixed some missing parts in the FrontendPanelTypes.
There are also a few things going on with the expansion addition... I'm on this part

If you get it working make a pull request direct to Christoph's repo.

ustk

@d-healey What is the expansion column? or how is it used?
I'm asking because I might use the bank column width for the expansion column too...
Does it appear on the left of the browser? Or should I treat it like the preset column?

d.healey

@ustk I don't know anything about it, @Christoph-Hart added it recently.

ustk

@d-healey Ok, will try... Apparently in the code, it is a fourth column...

arminh

@d-healey which build is now most stable? :D

ustk

@arminh Before the last merge, I guess... Just wait before using the very last one...

ustk

@d-healey Ok so I fixed the preset browser issue but I can't compile to test it because there are other errors:

@Christoph-Hart?

ustk

@d-healey It's a real mess to create a pull request directly since it automatically wants to sync with your fork first (77 pushes + 25 pulls...)
So I think it's better if @Christoph-Hart fixes the preset browser himself (before fixing the issue above):

Christoph Hart

I fixed but I don't understand what the column width property is for?

ustk

@Christoph-Hart It is a ratio for the bank and category column
If you set it to 0.25 in 3 columns mode, then bank and category will take 25% of the browser width each, while the preset column will use the remaining 50%

And with two columns, a 30/70% example:

It could have been an array for more flexibility, but I thought we essentially need to give the preset column more space while the other columns can share the same width... Anyway, feel free to modify it as you wish ;)

ustk

@Christoph-Hart Oh wait! I've just seen the commit, you apparently haven't made the good changes...
columnWidth (the original one) should disappear and be replaced with columnWidthRatio and there are 3 files that need to be modified
Have a look at my post above (all the green stuff should be added)

coreyu21

does The expansion preset column box take the place of a combo box when loading expansions to resolve the save in preset issue?

ustk

@Christoph-Hart Do you have the time to fix that by any chance? :)

Christoph Hart

I've added it but with a proper array that you can use to define all ratios.

ustk

@Christoph-Hart I've just seen the commit
There might be some more bugs though https://forum.hise.audio/topic/2848/latest-build-errors/12

Latest Build Errors

60

1.7k

11.7k

101.8k