Latest Build Errors

ustk

@arminh Before the last merge, I guess... Just wait before using the very last one...

ustk

@d-healey Ok so I fixed the preset browser issue but I can't compile to test it because there are other errors:

ustk

@d-healey It's a real mess to create a pull request directly since it automatically wants to sync with your fork first (77 pushes + 25 pulls...)
So I think it's better if @Christoph-Hart fixes the preset browser himself (before fixing the issue above):

Christoph Hart

I fixed but I don't understand what the column width property is for?

ustk

@Christoph-Hart It is a ratio for the bank and category column
If you set it to 0.25 in 3 columns mode, then bank and category will take 25% of the browser width each, while the preset column will use the remaining 50%

And with two columns, a 30/70% example:

It could have been an array for more flexibility, but I thought we essentially need to give the preset column more space while the other columns can share the same width... Anyway, feel free to modify it as you wish ;)

ustk

@Christoph-Hart Oh wait! I've just seen the commit, you apparently haven't made the good changes...
columnWidth (the original one) should disappear and be replaced with columnWidthRatio and there are 3 files that need to be modified
Have a look at my post above (all the green stuff should be added)

coreyu21

does The expansion preset column box take the place of a combo box when loading expansions to resolve the save in preset issue?

ustk

@Christoph-Hart Do you have the time to fix that by any chance? :)

Christoph Hart

I've added it but with a proper array that you can use to define all ratios.

ustk

@Christoph-Hart I've just seen the commit
There might be some more bugs though https://forum.hise.audio/topic/2848/latest-build-errors/12

d.healey

I have a few compile errors too. Christoph, it's your birthday, why are you working! Go have fun... and fix bugs! :P

Compiling include_hi_snex_25.cpp
In file included from ../../../../../HISE-new/hi_snex/hi_snex.cpp:24:0,
                 from ../../JuceLibraryCode/include_hi_snex.cpp:9:
../../../../../HISE-new/hi_snex/snex_core/snex_CallbackCollection.cpp: In lambda function:
../../../../../HISE-new/hi_snex/snex_core/snex_CallbackCollection.cpp:442:38: error: call of overloaded ‘mov(asmjit::x86::Mem&, juce::int64)’ is ambiguous
   if (IS_MEM(v)) cc.mov(n, INT_IMM(v));
                                      ^
../../../../../HISE-new/hi_snex/snex_jit/snex_jit_ComplexTypeLibrary.h:262:67: note: in definition of macro ‘ADD_INLINER’
 #define ADD_INLINER(x, f) fc->addInliner(#x, [obj](InlineData* d_)f);
                                                                   ^
In file included from ../../../../../HISE-new/hi_snex/src/asmjit/././x86/x86assembler.h:11:0,
                 from ../../../../../HISE-new/hi_snex/src/asmjit/./x86.h:16,
                 from ../../../../../HISE-new/hi_snex/src/asmjit/asmjit.h:36,
                 from ../../../../../HISE-new/hi_snex/hi_snex.cpp:5,
                 from ../../JuceLibraryCode/include_hi_snex.cpp:9:
../../../../../HISE-new/hi_snex/src/asmjit/././x86/../x86/x86emitter.h:606:18: note: candidate: asmjit::Error asmjit::x86::EmitterExplicitT<This>::mov(const asmjit::x86::Mem&, int) [with This = asmjit::x86::Compiler; asmjit::Error = unsigned int]
   ASMJIT_INST_2i(mov, Mov, Mem, Imm)                                   // ANY
                  ^
../../../../../HISE-new/hi_snex/src/asmjit/././x86/../x86/x86emitter.h:68:16: note: in definition of macro ‘ASMJIT_INST_2i’
   inline Error NAME(const T0& o0, int o1) { return _emitter()->emit(Inst::kId##ID, o0, Support::asInt(o1)); } \
                ^~~~
../../../../../HISE-new/hi_snex/src/asmjit/././x86/../x86/x86emitter.h:606:18: note: candidate: asmjit::Error asmjit::x86::EmitterExplicitT<This>::mov(const asmjit::x86::Mem&, unsigned int) [with This = asmjit::x86::Compiler; asmjit::Error = unsigned int]
   ASMJIT_INST_2i(mov, Mov, Mem, Imm)                                   // ANY
                  ^
../../../../../HISE-new/hi_snex/src/asmjit/././x86/../x86/x86emitter.h:69:16: note: in definition of macro ‘ASMJIT_INST_2i’
   inline Error NAME(const T0& o0, unsigned int o1) { return _emitter()->emit(Inst::kId##ID, o0, Support::asInt(o1)); } \
                ^~~~
../../../../../HISE-new/hi_snex/src/asmjit/././x86/../x86/x86emitter.h:606:18: note: candidate: asmjit::Error asmjit::x86::EmitterExplicitT<This>::mov(const asmjit::x86::Mem&, int64_t) [with This = asmjit::x86::Compiler; asmjit::Error = unsigned int; int64_t = long int]
   ASMJIT_INST_2i(mov, Mov, Mem, Imm)                                   // ANY
                  ^
../../../../../HISE-new/hi_snex/src/asmjit/././x86/../x86/x86emitter.h:70:16: note: in definition of macro ‘ASMJIT_INST_2i’
   inline Error NAME(const T0& o0, int64_t o1) { return _emitter()->emit(Inst::kId##ID, o0, Support::asInt(o1)); } \
                ^~~~
../../../../../HISE-new/hi_snex/src/asmjit/././x86/../x86/x86emitter.h:606:18: note: candidate: asmjit::Error asmjit::x86::EmitterExplicitT<This>::mov(const asmjit::x86::Mem&, uint64_t) [with This = asmjit::x86::Compiler; asmjit::Error = unsigned int; uint64_t = long unsigned int]
   ASMJIT_INST_2i(mov, Mov, Mem, Imm)                                   // ANY
                  ^
../../../../../HISE-new/hi_snex/src/asmjit/././x86/../x86/x86emitter.h:71:16: note: in definition of macro ‘ASMJIT_INST_2i’
   inline Error NAME(const T0& o0, uint64_t o1) { return _emitter()->emit(Inst::kId##ID, o0, Support::asInt(o1)); }
                ^~~~
In file included from ../../../../../HISE-new/hi_snex/hi_snex.cpp:24:0,
                 from ../../JuceLibraryCode/include_hi_snex.cpp:9:
../../../../../HISE-new/hi_snex/snex_core/snex_CallbackCollection.cpp: In lambda function:
../../../../../HISE-new/hi_snex/snex_core/snex_CallbackCollection.cpp:454:38: error: call of overloaded ‘mov(asmjit::x86::Mem&, juce::int64)’ is ambiguous
   if (IS_MEM(v)) cc.mov(n, INT_IMM(v));
                                      ^
../../../../../HISE-new/hi_snex/snex_jit/snex_jit_ComplexTypeLibrary.h:262:67: note: in definition of macro ‘ADD_INLINER’
 #define ADD_INLINER(x, f) fc->addInliner(#x, [obj](InlineData* d_)f);
                                                                   ^
In file included from ../../../../../HISE-new/hi_snex/src/asmjit/././x86/x86assembler.h:11:0,
                 from ../../../../../HISE-new/hi_snex/src/asmjit/./x86.h:16,
                 from ../../../../../HISE-new/hi_snex/src/asmjit/asmjit.h:36,
                 from ../../../../../HISE-new/hi_snex/hi_snex.cpp:5,
                 from ../../JuceLibraryCode/include_hi_snex.cpp:9:
../../../../../HISE-new/hi_snex/src/asmjit/././x86/../x86/x86emitter.h:606:18: note: candidate: asmjit::Error asmjit::x86::EmitterExplicitT<This>::mov(const asmjit::x86::Mem&, int) [with This = asmjit::x86::Compiler; asmjit::Error = unsigned int]
   ASMJIT_INST_2i(mov, Mov, Mem, Imm)                                   // ANY
                  ^
../../../../../HISE-new/hi_snex/src/asmjit/././x86/../x86/x86emitter.h:68:16: note: in definition of macro ‘ASMJIT_INST_2i’
   inline Error NAME(const T0& o0, int o1) { return _emitter()->emit(Inst::kId##ID, o0, Support::asInt(o1)); } \
                ^~~~
../../../../../HISE-new/hi_snex/src/asmjit/././x86/../x86/x86emitter.h:606:18: note: candidate: asmjit::Error asmjit::x86::EmitterExplicitT<This>::mov(const asmjit::x86::Mem&, unsigned int) [with This = asmjit::x86::Compiler; asmjit::Error = unsigned int]
   ASMJIT_INST_2i(mov, Mov, Mem, Imm)                                   // ANY
                  ^
../../../../../HISE-new/hi_snex/src/asmjit/././x86/../x86/x86emitter.h:69:16: note: in definition of macro ‘ASMJIT_INST_2i’
   inline Error NAME(const T0& o0, unsigned int o1) { return _emitter()->emit(Inst::kId##ID, o0, Support::asInt(o1)); } \
                ^~~~
../../../../../HISE-new/hi_snex/src/asmjit/././x86/../x86/x86emitter.h:606:18: note: candidate: asmjit::Error asmjit::x86::EmitterExplicitT<This>::mov(const asmjit::x86::Mem&, int64_t) [with This = asmjit::x86::Compiler; asmjit::Error = unsigned int; int64_t = long int]
   ASMJIT_INST_2i(mov, Mov, Mem, Imm)                                   // ANY
                  ^
../../../../../HISE-new/hi_snex/src/asmjit/././x86/../x86/x86emitter.h:70:16: note: in definition of macro ‘ASMJIT_INST_2i’
   inline Error NAME(const T0& o0, int64_t o1) { return _emitter()->emit(Inst::kId##ID, o0, Support::asInt(o1)); } \
                ^~~~
../../../../../HISE-new/hi_snex/src/asmjit/././x86/../x86/x86emitter.h:606:18: note: candidate: asmjit::Error asmjit::x86::EmitterExplicitT<This>::mov(const asmjit::x86::Mem&, uint64_t) [with This = asmjit::x86::Compiler; asmjit::Error = unsigned int; uint64_t = long unsigned int]
   ASMJIT_INST_2i(mov, Mov, Mem, Imm)                                   // ANY
                  ^
../../../../../HISE-new/hi_snex/src/asmjit/././x86/../x86/x86emitter.h:71:16: note: in definition of macro ‘ASMJIT_INST_2i’
   inline Error NAME(const T0& o0, uint64_t o1) { return _emitter()->emit(Inst::kId##ID, o0, Support::asInt(o1)); }
                ^~~~
In file included from ../../../../../HISE-new/hi_snex/hi_snex.cpp:24:0,
                 from ../../JuceLibraryCode/include_hi_snex.cpp:9:
../../../../../HISE-new/hi_snex/snex_core/snex_CallbackCollection.cpp: In lambda function:
../../../../../HISE-new/hi_snex/snex_core/snex_CallbackCollection.cpp:466:38: error: call of overloaded ‘mov(asmjit::x86::Mem&, juce::int64)’ is ambiguous
   if (IS_MEM(v)) cc.mov(n, INT_IMM(v));
                                      ^

Natan

Failed Here Too :(

ustk

@d-healey I re-cloned the repo and scriptnode does compile, but it systematically crashes when opening my project...
I commented all scripts but no luck...
(the project does open with your fork though)

d.healey

@ustk Ok I'll try a reclone

d.healey

I'm still getting the same errors

ustk

@d-healey Mmm... Strange....

ustk

@d-healey Have you tested on macOS?

d.healey

@ustk No only on GNU/Linux

Christoph Hart

@ustk said in Latest Build Errors:

I re-cloned the repo and scriptnode does compile, but it systematically crashes when opening my project...

There are two options to figure out stuff like that (both are annoying):

Gradually remove elements from your project to find the culprit module
Subsequently move back in the Git timeline until you can pinpoint the exact commit that broke it for you. Be aware that sometimes there are intermediate commits which do not compile though.

Let me know if you find the issue / rogue commit, then I'll fix it.

ustk

@Christoph-Hart Yep I commented out all my scripts but that didn't do it...
And going back in time in the commits behave weirdly as I can't revert the commits back to a certain point (nothing to commit error), but I'll retry ;)

Latest Build Errors

24

1.9k

10.7k

93.0k