Installing Samples Dialog....

[d.healey]

@Lindon Does it work if you remove the serial code stuff?

[Lindon]

@d-healey well it also didnt work for my very very simple example, with no serial work, I posted the snippet for so I cant see thats the problem - but I will try - tomorrow.

[d.healey]

It will be good if someone else can test.

[Lindon]

@d-healey OK I took out all the authorisation code...

..no difference it still fails to do ANY sample set up, now it just pops thru to the UI and cant find any ch files ...

I think perhaps I have been misleading you - the sample set up is supposed to pop BEFORE the authorisation....first thing.

[Lindon]

OK a morning (so far) of tedious compiling to test every scenario, in every case I deleted all the config data from AppData and deleted the entire contents of the binaries folder in the project here's the results:

HISE_SAMPLE_DIALOG_SHOW_INSTALL_BUTTON=1
HISE_SAMPLE_DIALOG_SHOW_LOCATE_BUTTON=1

-- shows both buttons

HISE_SAMPLE_DIALOG_SHOW_INSTALL_BUTTON=0
HISE_SAMPLE_DIALOG_SHOW_LOCATE_BUTTON=1

--show just the locate button

HISE_SAMPLE_DIALOG_SHOW_INSTALL_BUTTON=1
HISE_SAMPLE_DIALOG_SHOW_LOCATE_BUTTON=0

-- shows nothing

HISE_SAMPLE_DIALOG_SHOW_LOCATE_BUTTON=0

-- shows nothing !!!

HISE_SAMPLE_DIALOG_SHOW_LOCATE_BUTTON=1

-- shows both buttons

HISE_SAMPLE_DIALOG_SHOW_INSTALL_BUTTON=1

-- shows both buttons

HISE_SAMPLE_DIALOG_SHOW_INSTALL_BUTTON=0

-- shows the locate button

So if you explicit set the locate button to OFF it shows you nothing

So I'm begining to think its something in this logic:

#if HISE_SAMPLE_DIALOG_SHOW_INSTALL_BUTTON
		installSampleButton->setVisible(true);
		installSampleButton->setBounds(b.removeFromTop(32));
#else
		installSampleButton->setVisible(false);
#endif

#if HISE_SAMPLE_DIALOG_SHOW_LOCATE_BUTTON
		resolveSamplesButton->setVisible(true);
		resolveSamplesButton->setBounds(b.removeFromBottom(32));
#else
		resolveSamplesButton->setVisible(false);
#endif

which sorta says to me that if you dont set either then nothing would show....and thats not the case (cause I just checked..)

[d.healey]

The behaviour you've described is exactly the same as it was before my fix, no? If so that would lead me to believe that you are compiling your plugin against a different version of the source code, how many copies of the source do you have on your system?

For your testing are you using debug builds? They are much faster to build so take out a bit of the tedium of testing.

[Lindon]

@d-healey said in Installing Samples Dialog....:

The behaviour you've described is exactly the same as it was before my fix, no? If so that would lead me to believe that you are compiling your plugin against a different version of the source code, how many copies of the source do you have on your system?

For your testing are you using debug builds? They are much faster to build so take out a bit of the tedium of testing.

Perhaps I am - how would I check other than to look at the path in the preferences?

I may have built the wrong version of HISE - but I did the "normal" things - opened projucer - pointed it at the standalone project INSIDE the folder structure for Hise-develop - compiled from there....

In any case we checked that your effect.isBypassed(0 worked properly - to assure ourselves I was using the correct HISE ... and I was/am...

[Lindon]

@d-healey -- right I went and removed all your logic from FrontendBar.cpp and replaced it with:

	if (currentState[SamplesNotInstalled])
	{
		resolveLicenseButton->setVisible(false);
		registerProductButton->setVisible(false);

		auto b = getLocalBounds().withSizeKeepingCentre(200, 50);

		installSampleButton->setVisible(true);
		installSampleButton->setBounds(b.removeFromTop(32));
		resolveSamplesButton->setVisible(false);

and a similar thing for the text:

	case DeactiveOverlay::SamplesNotInstalled:
        return "Please click below to install the samples from the downloaded archive.";
		break;

and compiled that... then opened it and compiled the project: I get this:

• So I think we can say I'm using the correct HISE

[d.healey]

@Lindon said in Installing Samples Dialog....:

In any case we checked that your effect.isBypassed(0 worked properly - to assure ourselves I was using the correct HISE ... and I was/am...

That confirmed that you used my version of the source code to build HISE, but not that you used it to build your project.

So I think we can say I'm using the correct HISE

Yup, so something weird is happening. Need more testers :)

@d-healey -- right I went and removed all your logic from FrontendBar.cpp and replaced it with:

Are you sure it was my logic and not Christoph's? The changes I made were fairly minor and could be mistaken for the original code. (although what you posted before was definitely mine).

[Lindon]

@d-healey agreed more testing would be good - but I think this area need s a re-evaluation - its a bunch of confusing double negative flags (probably my fault as much as any one):

I suggest we dump these two flags:

HISE_SAMPLE_DIALOG_SHOW_INSTALL_BUTTON=1
HISE_SAMPLE_DIALOG_SHOW_LOCATE_BUTTON=0

to be replaced by:

HISE_SAMPLE_DIALOG_INSTALL_ONLY

(you get ONLY the install button and text)

and

HISE_SAMPLE_DIALOG_LOCATE_ONLY

(you get ONLY the locate button and text)

• if as a developer you put both in then - firstly : silly you and secondly you get what you get

if you put in neither you get both buttons.

This leads to this logic in FrontendBar.cpp

	case DeactiveOverlay::SamplesNotInstalled:

#if HISE_SAMPLE_DIALOG_INSTALL_ONLY
        return "Please click below to install the samples from the downloaded archive.";
		break;
#elif HISE_SAMPLE_DIALOG_LOCATE_ONLY
		return "Please click below to point to the location where you've already installed the samples.";
		break;
#else
		return "Please click below to install the samples from the downloaded archive or point to the location where you've already installed the samples.";
		break;

#endif
     

..and similar for the button displays

[d.healey]

@Lindon

but I think this area need s a re-evaluation - its a bunch of confusing double negative flags (probably my fault as much as any one):

True, but it's still working for me and not for you, I don't think changing the flags would fix that.

Do you have multiple copies of the source code on your machine?

[Lindon]

@d-healey I have old copies on a separate external drive...

[d.healey]

@Lindon I don't think that's the problem then... I'm out of idea until we get some more testers

@ustk @hisefilo ?

[hisefilo]

@d-healey I can test it on Macos, what should I do?

[d.healey]

@hisefilo Thanks.

• Build my develop branch - https://github.com/davidhealey/HISE/tree/develop
• Run HISE (the one you just made from my branch)
• Make a new project folder
• Add a script and sampler
• Open up project preferences and add these lines in the Extra Definitions OSX box

HISE_SAMPLE_DIALOG_SHOW_INSTALL_BUTTON=1
HISE_SAMPLE_DIALOG_SHOW_LOCATE_BUTTON=0

• Make sure the project is pointing to my develop branch's source code
• Export as a standalone app
• Run the app and let us know if it prompts you to install or locate the samples (or both).

[hisefilo]

@d-healey all of my clang boys working on it

[hisefilo]

@d-healey got this. Pointed the right Hise-develop folder also

Compiling Standalone application Tester ...
xcodebuild: error: 'Builds/MacOSX/Tester.xcodeproj' does not exist.
Compiling finished. Cleaning up...
logout
Saving session...
...copying shared history...
...saving history...truncating history files...
...completed.

[Process completed]

[d.healey]

Can you usually export standalone projects ok?

[hisefilo]

@d-healey for some reason is not creating OSX folder on Binaries

[hisefilo]

@d-healey said in Installing Samples Dialog....:

Can you usually export standalone projects ok?

of course