Installing Samples Dialog....

[d.healey]

@Lindon said in Installing Samples Dialog....:

In any case we checked that your effect.isBypassed(0 worked properly - to assure ourselves I was using the correct HISE ... and I was/am...

That confirmed that you used my version of the source code to build HISE, but not that you used it to build your project.

So I think we can say I'm using the correct HISE

Yup, so something weird is happening. Need more testers :)

@d-healey -- right I went and removed all your logic from FrontendBar.cpp and replaced it with:

Are you sure it was my logic and not Christoph's? The changes I made were fairly minor and could be mistaken for the original code. (although what you posted before was definitely mine).

[Lindon]

@d-healey agreed more testing would be good - but I think this area need s a re-evaluation - its a bunch of confusing double negative flags (probably my fault as much as any one):

I suggest we dump these two flags:

HISE_SAMPLE_DIALOG_SHOW_INSTALL_BUTTON=1
HISE_SAMPLE_DIALOG_SHOW_LOCATE_BUTTON=0

to be replaced by:

HISE_SAMPLE_DIALOG_INSTALL_ONLY

(you get ONLY the install button and text)

and

HISE_SAMPLE_DIALOG_LOCATE_ONLY

(you get ONLY the locate button and text)

• if as a developer you put both in then - firstly : silly you and secondly you get what you get

if you put in neither you get both buttons.

This leads to this logic in FrontendBar.cpp

	case DeactiveOverlay::SamplesNotInstalled:

#if HISE_SAMPLE_DIALOG_INSTALL_ONLY
        return "Please click below to install the samples from the downloaded archive.";
		break;
#elif HISE_SAMPLE_DIALOG_LOCATE_ONLY
		return "Please click below to point to the location where you've already installed the samples.";
		break;
#else
		return "Please click below to install the samples from the downloaded archive or point to the location where you've already installed the samples.";
		break;

#endif
     

..and similar for the button displays

[d.healey]

@Lindon

but I think this area need s a re-evaluation - its a bunch of confusing double negative flags (probably my fault as much as any one):

True, but it's still working for me and not for you, I don't think changing the flags would fix that.

Do you have multiple copies of the source code on your machine?

[Lindon]

@d-healey I have old copies on a separate external drive...

[d.healey]

@Lindon I don't think that's the problem then... I'm out of idea until we get some more testers

@ustk @hisefilo ?

[hisefilo]

@d-healey I can test it on Macos, what should I do?

[d.healey]

@hisefilo Thanks.

• Build my develop branch - https://github.com/davidhealey/HISE/tree/develop
• Run HISE (the one you just made from my branch)
• Make a new project folder
• Add a script and sampler
• Open up project preferences and add these lines in the Extra Definitions OSX box

HISE_SAMPLE_DIALOG_SHOW_INSTALL_BUTTON=1
HISE_SAMPLE_DIALOG_SHOW_LOCATE_BUTTON=0

• Make sure the project is pointing to my develop branch's source code
• Export as a standalone app
• Run the app and let us know if it prompts you to install or locate the samples (or both).

[hisefilo]

@d-healey all of my clang boys working on it

[hisefilo]

@d-healey got this. Pointed the right Hise-develop folder also

Compiling Standalone application Tester ...
xcodebuild: error: 'Builds/MacOSX/Tester.xcodeproj' does not exist.
Compiling finished. Cleaning up...
logout
Saving session...
...copying shared history...
...saving history...truncating history files...
...completed.

[Process completed]

[d.healey]

Can you usually export standalone projects ok?

[hisefilo]

@d-healey for some reason is not creating OSX folder on Binaries

[hisefilo]

@d-healey said in Installing Samples Dialog....:

Can you usually export standalone projects ok?

of course

[d.healey]

Did you save the project before trying to export?

[hisefilo]

@d-healey yep

[hisefilo]

@d-healey

[d.healey]

Does it export if you point it to your usual source code?

[hisefilo]

@d-healey yes

Filos-MacBook-Pro:~ filo$ /Users/filo/Filo/VST\ Project/TEster/Binaries/batchCompileOSX ; exit;
Re-saving file: /Users/filo/Filo/VST Project/TEster/Binaries/AutogeneratedProject.jucer
Finished saving: Visual Studio 2017 - Builds/VisualStudio2017/
Finished saving: Xcode (MacOSX)
Finished saving: Linux Makefile
Compiling Standalone application Tester ...
▸ Building Tester/Tester - App [Release]
▸ Check Dependencies
▸ Compiling PresetData.cpp
▸ Compiling CopyProtection.cpp
▸ Compiling include_hi_components.cpp

[d.healey]

Weird, you found a new issue :p Let us know if the app asks about installing/locating samples :)

[hisefilo]

@d-healey i.e. I cannot compile if a source code is in Download or trash folder. I guess it's a permission issue. But just a guess

[hisefilo]

@d-healey