[Solved] Where's my reverb?

[d.healey]

@ustk Snippet...

[ustk]

@d-healey I'm not sure a snippet will help, I am just testing with a sine generator and a convolution module, so there's no code because I manually insert an IR for testing purpose.
This preset will work or not depending on the Hise build I open

What I could do is provide you with two Hise builds (a good and a bad one) so you can test them on a mac?

[d.healey]

@ustk I see. What is the difference between the two builds? No need to share them with me, without knowing the source code each came from I wouldn't be able to do much.

[ustk]

Ok, after some investigations, the only commit that works is the commit from the 19th July, all the commits I possess after this date don't work (28th, 2nd, and today's commit).
Does someone have one of these to test the convolution reverb, please?

[d.healey]

I don't see a commit from the 19th

[ustk]

What??? @Christoph-Hart didn't work on the 19th???

@d-healey oh sorry then, it is the 18th actually...
I have made many tests for hours, apparently, there had been several updates related to convolution in the source files since then
So I just need to know if it works for you guys after the 18th, so 23rd till today, so I'll be fixed if it is on my end or a bug in Hise

[ustk]

Side question: How do you download a previous commit? I tried but had an error instantly when building...

[d.healey]

[ustk]

Thanks, that's what I did back then, but it didn't work. Anyway, I just succeed in building a commit from 4th of July with the convolution working, so I think it is a recent bug in Hise... A commit from the 26th shows modifications of the convolution...
@Christoph-Hart Are you aware of that?

[Christoph Hart]

I rewrote the module so that I could reuse the convolution reverb as node in scriptnode but it might be possible that something old broke. What are the steps to reproduce? Just load any IR into it and play a sine wave through, and the wet signal is silent?

[ustk]

@Christoph-Hart Yep just load an IR with with any sound module, the signal is not affected by the IR
The dry signal is passing through

[Christoph Hart]

Here's your reverb :)

- fixed typo in convolution reverb · christophhart/HISE@a17b107

The open source framework for sample based instruments - - fixed typo in convolution reverb · christophhart/HISE@a17b107

GitHub (github.com)

[ustk]

@Christoph-Hart Youhou thanks! Working! I can submit my project end of the week...

By the way, there's another typo I think that leads to an error, but if I replace sr by half_sr, it works...

[Christoph Hart]

@ustk said in Where's my reverb?:

there's another typo

HUH? That's so deep in the JUCE codebase that I didn't even know that code exists. If it fails, it must have something to do with your XCode versions. What OS version and XCode are you using?

[ustk]

@Christoph-Hart Weird...

• 10.13.6 High Sierra
• XCode 8.3.3 (8E3004b)

[Christoph Hart]

Nevermind, it was indeed an issue here - I remember running a search and replace during refactoring, and this was also accidentally renamed, so all good with your OS :)