Hardcoded Polyphonic FX - Filters - some observations.

[Lindon]

Ok so apart from the fact that applying an LFO modulator to any of the controls in this gives a really nasty distorted sound...

I note that with or without an envelope applied to the freq there is a faint click at note termination in the compiled (hardcoded) filter that isnt present in the uncompiled scriptNode.... For some reason I cant fathom, applying an envelope to the resonance makes this go away....even with attack times set to their very minimum....

a bit odd, so I then tried re-ordering the LFO modulator (before the envelope) for the freq...but no - not playing any better.

I also note turning up the LFO Smoothing makes the problem more obvious.

.edit: and now when I reload the project the click is back again... no matter what envelope I try adding..

So I think the hardcoded polyphonic FX area needs some love......

[Christoph Hart]

@Lindon have you added the hasTail flag?

[Lindon]

@Christoph-Hart yep..

[Lindon]

@Lindon heres a snippet to demonstrate:

HiseSnippet 1866.3oc6X0sSbbCEdF.CAxeMJoMR8p4hdAoJEMyr+qdQf.rATCv1rjetKxLi2rVLq8zY7BYaUk5k8snuIs4QnOB8QnuAsGaO6NdfM.ZCjPhxhDZ74X6ymO+YeNsR3AjzTdhk8B6NHlXYeMT6ALQ2U6hoLqMWyx9pnfn.59BRpv5gChwoojPKa6oejbB1yOik52+9fGhivr.RNIKqmwoAjGS6QE4Tas7OPihZhCI6R6YL6xKuY.msJOh2G.yzHWqXbv93WQ1FKm1THqMvocsr+VT0vN3pg0p35QJUOrluWsJMJWqpqamv5d01q1dkvg3p0bsrmc8PpfmzVfAzaYOyC4gCZ2keHSKfmQSo6EQjC7rZCRVStIOJTdDkTsVsKMJr0PsTpkkMpUtNaZsN6NnsngzQzy0ceghgS9JLUf1SUDdSW.ddlvy0.diAR1FPZFMjtEpcPBMVjyQaK2jIHIcvfcxDJ54ZY+FzpbXBLwR8v6SZl.CFsfEAM78cf+cuuuSeVffxYNb11bAYG1h2ageYg4W3WWv4nr5zYr7jhIgGEQRFKaoqQxIsvEY86sGI49NGfi5SFMQ33WTmhd65TSSdf9TaLQNaSFUrSLg81bDrxTUvWOcy0vBrzPjQClWLIQPkPvdMxAPXf1rLOZMR59BdLDHbLaF3svC6GgEEcgjAZYL.cPA6lz3vRohAlAhma9UmUHdKTKpHn63w3TiAifl5h.iYQiWGsdmNj.QN.mA07EWLgdlh+lERf9nDd+Xkzuil.IklRRbTz8NOxjFelyjtNCCmllaYtiqhSRnjjMYgjWaH7+Zj88XbdJilxYbETVoGuOSXB5LtqQD8YEfdFi1wIDbn4JjnuMAfZnZKSK3CO8Ik51aBScO2ktT2eDjEnvsKY93ygVYi0Z+jrne02NqyNfDAo8J5auEX5i6xYz.SehmPDIzW8JRhIhG6wXEg.dFvp8SNnfS0Zj.7fiQUOYyHAMkGS.nYNwM.+j7weyxpsaDg2jrb69ohBQkRLGQvoEhyVOfClDxDp18NY0N5L5Zbcj9P5nxBb461gaLDeZqvkO.dMjx7eYU+cSTly3kVE3MPYwFWVUgm3CTl9S5GnXOkg7mUK+6h1.mDF.YtBawiFnSOC.PhjuNmmSNSmlunXZ8sIhC4I6KqnX0HZft5vNIjeJSG9a+4eryxIm7c5SdpwYNygNs7bdWtzblylZ+je1wYOPuk+GUnszGUns7k.z9DdeAk8psvvyef2Vi1teu1vqzCH.RYLRjrhU6ojuNWO1UNVBn1DVnZv+A+xX5IGamwzaHSSMBRqQVHqW.Yg3WKa3QCpmBPSSZDTte5ncNqu.+NJuFb3c7w3Dxt7VQ3AKlh6EGQdBnjtuydQ7f8aS+YxwKbOVCpGJmwhAYG1Io99YOmxg7dwTj2gfr7kpmSOJ24b5Vxjm.cknH9gqx6ESybSUGCE07bwYGTvJolwbH2kf+rzKaH5GVel9HrANcWLMRZig2RDCXbGVaXxphLgKar2V8J14ZhC.c6fVXQW4klxth.APjjkBL5FXNby8cj5Xce5L4KsKsvI.csOkD2RIMrzTs9D.dOoRR1hO3hEfuVKofzrRYNGRK+SAdiCNCW5jHVDJ8fNEE50QczAHKIYMNApWzoINowJh75gcMZXT2nOgOxJ+V48ZnDArMZD78VT1yjQHvmHeoavV3WmQXdf.7Cn0dexg5igrdW2k78azvsbkp99kJWuV8JYF1lv028AehAP0Ucv8iDYazUPd58Yk9BdOHtaX9swCjaCRnjq5mmWCe2F9MLP0sQMVpdC4upd0qTx0uVoiiupkq4UqtWsRtUq3UupBeSi9wifKDx6jA0L4fZNz24Uuf5YVjhfbqmUUbs0nsUdVM2GT99nYluKZLbzCPIWOWoJnQi5kaTy0KSA2tGmK5BIcFJpuRtatMz+pUqZ459Up6e1kcYorEjXYN2gXQefTkk9NbfFylNOR2FoPqBS0xnWmE8TKvQ0EA4H3V1oz2BsY5yjbCvQC2QHYUAW8oL8vzGL0aLOe75G4QBVHvmrT4RUKUwy20u5XczTM2kQTWTkZUXHfTYD+lgCi+GgaIIyHqBVAcRF4qjuPidNeNEx3uIxhdQ1bbYo6x9MJeZ2o0z4OHcVP20yOfv6tZ3cUzywGPT8gVgruTMtCOomyiHvUnRbeRMk9uO+aJ8NAB.B6lfYow7Thm4N2lzitKmQRKP8HqverqvuXaBkdGdGmTgYIUEMAUgw7txxCI5aRrElUXyfwE1osnFcL+edfNgotG26jF.JFrJLM2l2peTJ44zPQWOyElS12jrrzbvFVnUpWLcJe1O2o7O2NpOnVQHTx4RsU7tHHj12QYJc9vXKeeTC6mJxnGNHg+x.c6Ejo3thhBnaYpB2lGskbrim0AYujbjAqGjd6kAAE2pisP+IcgklzEVdRWXkIcgUmzEVaRWX8SegxaexpBTF+A2B2Zc0SNssGVwBDJZ8+.4HaLg

You prob. have to compile the scriptnode, and its less obvious than some filters but move the freq down to 5K or less and there it is...

[Lindon]

@Lindon Ok well more investigations..... and a "work around" solution....

So you need to put your Hardcoded Polyphonic FX in an Effects chain in the same container as your Gain AHDSR envelope, and add a small (around 100-150) ms of release and this clicking goes away....

So for example lets say you have this structure:

You must put your AHDSR envelope (here AHDSR Envelope1) in the Syntesiser Group1 where you must also place your Hardcoded Polyphonic FX

Put the FX down in the Waveform Generator and leave the AHDSR where it is? - nope no worky...
Put the Poly Hardcoded FX down in the Waveform Generator and leave the AHDR where it is? - again - not gonna work reliably....