Multiple expansions with the same name

[David Healey]

@Christoph-Hart The expansion system works if every expansion has a different name. If expansions are only being created by a single developer then this is no problem, but for something like Rhapsody, which is open to all, I can see the potential for two or more expansions from different developers to have the same name.

One idea I've thought of is if within the Expansions folder we have a sub-folder for each company.

Before I try to implement this, do you think it's a good idea, or is there perhaps another solution I'm not seeing?

[David Healey]

Well I couldn't wait :)

I've made a PR that allows expansions to be placed in company subfolders. This is behind a HISE_USE_EXPANSION_COMPANY_SUBFOLDERS definition.

I've also added another PR for a new option in the Package sample monolith files dialog to exclude samples from the package... hear me out .

Sometimes you want to send an update to users that only includes data. You don't want them to have to redownload all the samples again, especially with a big sample library.

[Christoph Hart]

Hmm I need to look at the PR, I haven't really catered in the fact of expansion name collisions, there are quite a few calls in the codebase that just say "fetch me the expansion with the name XXX" and a simple company / expansion subfolder structure won't solve that.

But yeah for a general purpose Full Instrument Player like Rhapsody this should be addressed at some point.

Sometimes you want to send an update to users that only includes data.

Can't you then not just update the .hxi file?

[David Healey]

@Christoph-Hart said in Multiple expansions with the same name:

fetch me the expansion with the name XXX"

The change I made affects getExpansionTargetFolder which I think would handle most situations that are accessing expansions, but I'll take a closer look.

I also noticed I messed up the commits in my PR so I'll close and reopen.

@Christoph-Hart said in Multiple expansions with the same name:

Can't you then not just update the .hxi file?

Not if I want to use installExpansionFromPackage() :) I'm looking into using the hr1 format instead of zip files because I've ran into some limitations. The fact that the hr1 has meta data I can access without unpacking it is proving helpful.

[David Healey]

@Christoph-Hart I've fixed the PRs.

https://github.com/christophhart/HISE/pull/821
https://github.com/christophhart/HISE/pull/822

Let me know if you have a better idea regarding handling expansions with the same names.